Repository navigation
fix(dashboard): show Obsidian context source card - #7500
diegosouzapw merged 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request integrates the ObsidianSourceCard into the dashboard's context sources tab and refactors several tunnel phase type definitions for improved readability. The review identified a missing UI test for the new component, which is required by the repository's style guide (Rule #9) for all production code changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
afb33fe to
68cd35e
Compare
68cd35e to
b795a95
Compare
|
Thanks for the clean root-cause writeup and for shipping the regression test alongside the fix — verified locally: clean merge onto release/v3.8.49 tip (no base drift), |
2be8ebd
into
cheaper-inference:release/v3.8.49
|
Merged into |
…7500) * fix(dashboard): show Obsidian context source card * test(dashboard): guard Obsidian context source wiring --------- Co-authored-by: DKotsyuba <16292493+DKotsyuba@users.noreply.github.com>
…7500) * fix(dashboard): show Obsidian context source card * test(dashboard): guard Obsidian context source wiring --------- Co-authored-by: DKotsyuba <16292493+DKotsyuba@users.noreply.github.com>
Problem
Dashboard → Endpoints → Context Sources tab showed only the Notion context source card, while the Obsidian component, backend, MCP tools, REST settings routes, and DB config all already existed and were fully functional.
Root Cause
An omission in PR #3077 (commit
9db306e2f), which added the full Obsidian context source integration —ObsidianSourceCard.tsx(505 lines), REST settings route (src/app/api/settings/obsidian/route.ts), DB module (src/lib/db/obsidian.ts), Obsidian API client (src/lib/obsidian/api.ts), sync module (src/lib/obsidianSync.ts), 24 MCP tools (open-sse/mcp-server/tools/obsidianTools.ts), and 5 test files totaling ~1,500 lines — across 16 changed files, but did not modifysrc/app/(dashboard)/dashboard/endpoint/EndpointPageClient.tsx.The page imported and rendered only
NotionSourceCard; theObsidianSourceCardimport and JSX render call were never added, leaving the card inaccessible from the dashboard UI despite all supporting infrastructure being in place.Documentation Evidence
docs/frameworks/OBSIDIAN_CONTEXT.mdlines 39–40 instruct users:The documentation has claimed dashboard availability since the feature landed, but the dashboard page never rendered the card.
Changelog Evidence
The v3.8.9 changelog entry states:
The changelog explicitly promises the Context Sources tab integration.
History Evidence
A full
git loginspection ofEndpointPageClient.tsxfrom after PR #3077 through present (release/v3.8.49) was performed. No commit in that window references Obsidian removal, reversion, or a deliberate feature flag/disable. TheObsidianSourceCardcomponent had no import in the file at any point after the initial addition of the Notion card (PR #2959, commitb778ad261).Fix
Two additions to
src/app/(dashboard)/dashboard/endpoint/EndpointPageClient.tsx:ObsidianSourceCardcomponent (line 15)NotionSourceCardin the context-sources tab (line 1265)No backend, API, MCP, WebDAV, or other infrastructure changes — the component and all its dependencies were already shipped and tested.
Verification
git diff --check— passed, no whitespace issuestests/unit/obsidian-api.test.tstests/unit/obsidian-tools.test.tstests/unit/obsidian-config.test.tstests/unit/obsidian-plugin-sync.test.tstests/unit/obsidian-webdav-route.test.tstests/integration/obsidian-plugin-e2e.test.tsScope & Risk
EndpointPageClient.tsx)