Skip to content

Refresh NVIDIA free metadata and detect catalog drift - #7378

Merged
diegosouzapw merged 3 commits into
cheaper-inference:release/v3.8.49from
JxnLexn:dev/nvidia-free-metadata-drift
Jul 18, 2026
Merged

diegosouzapw merged 3 commits into
cheaper-inference:release/v3.8.49from
JxnLexn:dev/nvidia-free-metadata-drift

Conversation

@JxnLexn

@JxnLexn JxnLexn commented Jul 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Refresh NVIDIA’s reviewed free/trial metadata and detect changes between the live catalog and the reviewed snapshot.

Validation

  • npm run lint
  • npm run test:unit
  • npm run test:coverage
  • Coverage is still >= 60% for statements, lines, functions, and branches
  • SonarQube PR analysis is green or any remaining issues are explicitly documented below

Tests Added Or Updated

  • Updated the free-model catalog test to cover NVIDIA GLM 5.2.
  • Added automated tests for NVIDIA catalog drift detection.

Coverage Notes

  • Tests cover NVIDIA model inclusion and drift classification for new, removed, and undocumented models.
  • No coverage results were provided.

Reviewer Notes

  • The drift check requires NVIDIA_API_KEY and queries NVIDIA’s live catalog.
  • The check reports drift by default and supports --strict to fail on detected changes.
  • Catalog availability does not establish free access; verify NVIDIA metadata before updating the free-model catalog.

@JxnLexn
JxnLexn requested a review from diegosouzapw as a code owner July 16, 2026 08:58

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a drift detection mechanism for the NVIDIA model catalog by adding a script to compare live models against a local snapshot and documented free models, along with corresponding unit tests. It also registers the NVIDIA GLM 5.2 model in the free model catalog. Feedback is provided to wrap the API fetch and JSON parsing in a try-catch block to handle network errors and invalid payloads gracefully.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 282c73b602

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks for this — clean, well-scoped change. Verified: z-ai/glm-5.2 isn't already in the catalog on release/v3.8.49 (no duplicate), the new drift script fails gracefully without NVIDIA_API_KEY (exit 2, no crash), check:provider-consistency stays green, and both new/updated test files pass (19/19) in an isolated checkout. No overlap with #7296 — that PR only touches the reasoning-effort executor, this one only touches the free-model catalog/snapshot/drift script, so both merge cleanly together. One optional follow-up for later: since check:nvidia-catalog-drift needs a live API key, it isn't wired into any CI job right now (which matches your Reviewer Notes) — happy to help wire it into a nightly workflow with a secret if you want it running unattended. Merging as-is.

@diegosouzapw
diegosouzapw merged commit c6315f9 into cheaper-inference:release/v3.8.49 Jul 18, 2026
15 checks passed
@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks @JxnLexn! Merged into release/v3.8.49 after combined merge-train validation (static gates + tests + vitest green on the merged tree). Where quality gates flagged growth we decomposed/extracted inside your branch keeping you as author — including renumbering the reasoning-routing migration slot and the ProviderDetailPageClient rebaseline annotation.

@diegosouzapw diegosouzapw mentioned this pull request Jul 23, 2026
HouMinXi pushed a commit to HouMinXi/OmniRoute that referenced this pull request Aug 2, 2026
…nce#7378)

* fix(nvidia): refresh free metadata and detect drift

* fix(nvidia): handle catalog fetch and parse failures

* fix(nvidia): refresh hosted model metadata snapshot
muhamadgalihsaputra pushed a commit to niyatna/NiyatnaRoute that referenced this pull request Sep 27, 2026
…nce#7378)

* fix(nvidia): refresh free metadata and detect drift

* fix(nvidia): handle catalog fetch and parse failures

* fix(nvidia): refresh hosted model metadata snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants