Repository navigation
Refresh NVIDIA free metadata and detect catalog drift - #7378
diegosouzapw merged 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a drift detection mechanism for the NVIDIA model catalog by adding a script to compare live models against a local snapshot and documented free models, along with corresponding unit tests. It also registers the NVIDIA GLM 5.2 model in the free model catalog. Feedback is provided to wrap the API fetch and JSON parsing in a try-catch block to handle network errors and invalid payloads gracefully.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 282c73b602
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thanks for this — clean, well-scoped change. Verified: z-ai/glm-5.2 isn't already in the catalog on release/v3.8.49 (no duplicate), the new drift script fails gracefully without NVIDIA_API_KEY (exit 2, no crash), check:provider-consistency stays green, and both new/updated test files pass (19/19) in an isolated checkout. No overlap with #7296 — that PR only touches the reasoning-effort executor, this one only touches the free-model catalog/snapshot/drift script, so both merge cleanly together. One optional follow-up for later: since check:nvidia-catalog-drift needs a live API key, it isn't wired into any CI job right now (which matches your Reviewer Notes) — happy to help wire it into a nightly workflow with a secret if you want it running unattended. Merging as-is. |
c6315f9
into
cheaper-inference:release/v3.8.49
|
Thanks @JxnLexn! Merged into release/v3.8.49 after combined merge-train validation (static gates + tests + vitest green on the merged tree). Where quality gates flagged growth we decomposed/extracted inside your branch keeping you as author — including renumbering the reasoning-routing migration slot and the ProviderDetailPageClient rebaseline annotation. |
…nce#7378) * fix(nvidia): refresh free metadata and detect drift * fix(nvidia): handle catalog fetch and parse failures * fix(nvidia): refresh hosted model metadata snapshot
…nce#7378) * fix(nvidia): refresh free metadata and detect drift * fix(nvidia): handle catalog fetch and parse failures * fix(nvidia): refresh hosted model metadata snapshot
Summary
Validation
npm run lintnpm run test:unitnpm run test:coverage>= 60%for statements, lines, functions, and branchesTests Added Or Updated
Coverage Notes
Reviewer Notes
NVIDIA_API_KEYand queries NVIDIA’s live catalog.--strictto fail on detected changes.