Repository navigation
feat(ci): Windows leg for Electron prepare smoke (WS1.5) - #7113
Merged
Merged
Conversation
The Electron rebuild/spawn path executed for the FIRST time on the release tag: the v3.8.48 Windows failure (npx.cmd spawned without shell) could only surface at release. The Electron Package Smoke job becomes a 2-leg matrix: ubuntu keeps the full pack + headless smoke; windows-latest runs prepare:bundle — the exact ABI rebuild + spawn-plan path that broke — on every release PR instead of tag day. tar extraction of the build artifact works on windows-latest (bsdtar). Workflow-only change; YAML parse validated.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
…erence#7113) The Electron rebuild/spawn path executed for the FIRST time on the release tag: the v3.8.48 Windows failure (npx.cmd spawned without shell) could only surface at release. The Electron Package Smoke job becomes a 2-leg matrix: ubuntu keeps the full pack + headless smoke; windows-latest runs prepare:bundle — the exact ABI rebuild + spawn-plan path that broke — on every release PR instead of tag day. tar extraction of the build artifact works on windows-latest (bsdtar). Workflow-only change; YAML parse validated.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
…erence#7113) The Electron rebuild/spawn path executed for the FIRST time on the release tag: the v3.8.48 Windows failure (npx.cmd spawned without shell) could only surface at release. The Electron Package Smoke job becomes a 2-leg matrix: ubuntu keeps the full pack + headless smoke; windows-latest runs prepare:bundle — the exact ABI rebuild + spawn-plan path that broke — on every release PR instead of tag day. tar extraction of the build artifact works on windows-latest (bsdtar). Workflow-only change; YAML parse validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task WS1.5 (=T3) of the v3.8.49 quality/velocity master plan — closes G12: the Electron native-rebuild/spawn path only executed on
push: tags, so its first-ever real execution was release day (exactly how the v3.8.48 Windows bug —npx.cmdspawned withoutshell, Node's CVE-2024-27980 behavior — reached the tag).electron-package-smokebecomes a 2-leg matrix:npm run pack+ headless packaged-app smoke.npm run prepare:bundleonly — the ABI rebuild + spawn plan (prepare-electron-standalone.mjs+electronRebuildPlan.mjsfrom fix(build): v3.8.47 hotfix — npm tarball missing head-response-guard.cjs (#7065) + electron win spawn #7055), i.e. the exact code path that broke, now exercised per release PR (~5-8min, no electron-builder toolchain).fail-fast: falseso one leg's failure still reports the other.Workflow-only change; YAML parse validated. The Windows leg's first run happens on this PR's own CI? No — this repo's full gate runs on PR→main, so first execution is the next release PR (or a workflow_dispatch); noted for expectations.