Skip to content

test(ci): make masking self-reference check hermetic - #7085

Closed
KooshaPari wants to merge 1 commit into
cheaper-inference:release/v3.8.47from
KooshaPari:koosha/fix-test-masking-hermetic
Closed

KooshaPari wants to merge 1 commit into
cheaper-inference:release/v3.8.47from
KooshaPari:koosha/fix-test-masking-hermetic

Conversation

@KooshaPari

Copy link
Copy Markdown
Contributor

Remove the check-test-masking regression test's dependency on origin/main, which Actions does not fetch for release PRs. The test now models the relevant pre- and post-fixture source locally while preserving the file-scoped masking assertion.

@KooshaPari
KooshaPari requested a review from diegosouzapw as a code owner July 14, 2026 00:58
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Hey — you actually opened a newer, better-targeted version of this exact fix as #7135 (same content, correct base = release/v3.8.49, the branch that's currently taking merges). Since #7085 targets the older release/v3.8.47 line which is no longer active, I'm going to merge #7135 and close this one as superseded by your own PR — no credit lost, just consolidating to the one with the right base. Thanks for catching and fixing this twice over!

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Thanks @KooshaPari! Same story as #7135: the hermetic-selfref fix landed via #7327 (b83fe6f, merged 2026-07-15) using a disk-read of the real file. Closing as subsumed — appreciated the two independent takes on this, they raised confidence in the root cause.

@KooshaPari
KooshaPari deleted the koosha/fix-test-masking-hermetic branch August 13, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants