Repository navigation
Conversation
…njection - Fix truthy check for budget_tokens to allow 0 - Stop injecting default thinkingConfig when no knobs present - Add tests covering all scenarios Related: cheaper-inference#6813
…hutdown timeout - Move 3 flaky tests to tests/unit/serial/ with 30s timeout - Increase audit shutdown test timeout from 5s to 30s - Add SPEC.md and PLAN.md Related: cheaper-inference#6803
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Thanks for the PR — both problems you're targeting here are already fixed and merged into
Two issues to flag on the current diff:
Given both target issues are already closed out upstream with more complete fixes, I'd recommend closing this one. If defect 2 of #6813 (opt-out of default thinking injection) is still desired, it deserves its own focused PR with regression tests against #4170's scenario, separate from any #6803 test-infra changes. Thanks again for engaging with both issues — and please keep contributing! Your instinct on #6813 defect 2 (the forced default thinking injection) is pointing at a real, still-open gap; a focused PR against |
Summary
Moves 3 flaky timing-sensitive tests to serial execution and increases audit shutdown test timeout from 5s to 30s to prevent CI flakiness.
Changes
.planning/6803-migrate-timing-sensitive-tests-to-serial.md.planning/6803-migrate-timing-sensitive-tests-to-serial-PLAN.mdopen-sse/mcp-server/__tests__/audit.test.ts:64—it("checkpoints and closes...", ..., 30000)tests/unit/serial/(picked up by vitest include pattern):6803-quota-share-immediate.test.ts6803-resilience-flaky-moved.test.ts6813-openai-to-gemini-thinking-budget-zero.test.tsVerification
npm run lint— passesnpm run typecheck:core— passesRelated
Fixes #6803