[defer] fix embedded CLIProxyAPI config handling by professional-ALFIE · Pull Request #6877 · cheaper-inference/OmniRoute

professional-ALFIE · 2026-07-11T11:23:28Z

What changed

Use CLIProxyAPI's supported --config flag when starting the embedded service.
Create the embedded config.yaml only when it does not already exist.

Why

OmniRoute currently starts CLIProxyAPI with -c, but CLIProxyAPI does not define that shorthand. The process exits immediately with code 2 before binding its configured port.

OmniRoute also rewrites the complete embedded config on every start. That discards user-managed settings such as remote management, API keys, and TLS configuration. Existing config files should be preserved; the minimal default is only needed for first-time initialization.

Impact

The embedded CLIProxyAPI service starts normally and keeps existing configuration across Start and Restart operations.

Validation

Reproduced with CLIProxyAPI 7.2.66: -c exits with code 2 and flag provided but not defined: -c.
Verified the same binary and config start on 127.0.0.1:8317 with --config and GET /healthz returns HTTP 200.
Ran resolveSpawnArgs() against an existing config and verified its contents remain unchanged.
Ran resolveSpawnArgs() with no config and verified the minimal default is created.
Ran node --import tsx/esm --test tests/unit/services/installers/cliproxy.test.ts: 6 tests passed.

gemini-code-assist

Code Review

This pull request updates the CLI proxy installer service to use the --config flag instead of -c when spawning the process. The review feedback correctly points out that, according to the repository style guide, changing production code requires corresponding unit test updates to prevent regressions.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

gemini-code-assist · 2026-07-11T11:24:06Z

  return {
    command: symlinkPath,
-    args: ["-c", configPath],
+    args: ["--config", configPath],


According to the Repository Style Guide (Rule 9: 'Always include tests when changing production code'), any changes to production code under src/ must include corresponding test updates. Please update the unit tests in tests/unit/services/installers/cliproxy.test.ts to verify that the --config flag is correctly passed instead of -c to prevent future regressions.

References

Always include tests when changing production code (src/, open-sse/, electron/, bin/). ^(link)

diegosouzapw · 2026-07-12T11:56:10Z

Thanks for tracking this down — verified against the vendored CLIProxyAPI source (_references/_sistemas_proxys/CLIProxyAPI/cmd/server/main.go:101, flag.StringVar(&configPath, "config", ...)): there's no -c alias registered, so the root cause and the --config fix are correct. The config-preservation change also makes sense — clobbering config.yaml on every start would indeed wipe user-managed remote-management/API-key/TLS settings.

One gap before this is ready: tests/unit/services/installers/cliproxy.test.ts doesn't actually exercise resolveSpawnArgs() against the filesystem — it re-asserts hardcoded string literals (including the old ["-c", configPath] shape, just in a comment) rather than calling the real function, so it would pass identically with or without this fix. Could you add a test that imports resolveSpawnArgs with DATA_DIR pointed at a temp dir and asserts (a) the args are ["--config", configPath], (b) an existing config.yaml is left untouched, and (c) a missing one gets the default written? That gives this fix a real regression guard and should be enough to flip it out of Draft.

Separately (non-blocking): since CLIPROXYAPI_PORT can change between restarts but the config.yaml is now only written once, a port change after first install won't propagate into the persisted config — worth a one-line note or follow-up if that's a real operator flow.

…wnArgs (cheaper-inference#6877) The existing cliproxy.test.ts only re-asserted string literals and never called the real resolveSpawnArgs() against a filesystem, so it could not have caught the -c/--config flag mismatch or the config.yaml clobbering bug this PR fixes. Add a test that imports the real function against a temp DATA_DIR and asserts: the spawn args always use --config (never -c), a missing config.yaml gets the default template, and an existing operator-customized config.yaml is left byte-identical. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

gemini-code-assist · 2026-07-21T17:14:32Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

diegosouzapw · 2026-07-21T19:30:28Z

Validated in local merge-train on tomni-proxmox-113 @ db6718332763af295ec8374913f1f5eb7641734f (FAST gates green: static + changed tests + vitest)

bifrost.ts resolveSpawnArgs() set BIFROST_TRANSPORT_VERSION straight from getInstalledVersionSync(), which reads the raw "version" field out of node_modules/@maximhq/bifrost/package.json - always bare semver per npm convention (e.g. "1.6.3"). @maximhq/bifrost's own bin.js validates that env var against /^v\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?$/ or the literal "latest" and rejects anything else with "Invalid transport version format", exiting immediately. Every embedded Bifrost instance failed to start as a result. Adds formatTransportVersion() to normalize at the call site that owns the env var, so bifrost.ts and the upstream @maximhq/bifrost package both stay exactly as designed - no changes needed to bifrost itself. Strengthens the existing resolveSpawnArgs test to assert the actual v-prefix format (it previously only checked for a non-empty string, the same gap cheaper-inference#6877 called out for cliproxy's pre-existing test), and adds a dedicated regression test file covering the pure formatTransportVersion() helper plus a real-filesystem resolveSpawnArgs() integration check. Found and fixed while self-hosting OmniRoute and diagnosing why bifrost kept crash-looping on startup.

* fix(bifrost): send v-prefixed transport version, not bare semver bifrost.ts resolveSpawnArgs() set BIFROST_TRANSPORT_VERSION straight from getInstalledVersionSync(), which reads the raw "version" field out of node_modules/@maximhq/bifrost/package.json - always bare semver per npm convention (e.g. "1.6.3"). @maximhq/bifrost's own bin.js validates that env var against /^v\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?$/ or the literal "latest" and rejects anything else with "Invalid transport version format", exiting immediately. Every embedded Bifrost instance failed to start as a result. Adds formatTransportVersion() to normalize at the call site that owns the env var, so bifrost.ts and the upstream @maximhq/bifrost package both stay exactly as designed - no changes needed to bifrost itself. Strengthens the existing resolveSpawnArgs test to assert the actual v-prefix format (it previously only checked for a non-empty string, the same gap #6877 called out for cliproxy's pre-existing test), and adds a dedicated regression test file covering the pure formatTransportVersion() helper plus a real-filesystem resolveSpawnArgs() integration check. Found and fixed while self-hosting OmniRoute and diagnosing why bifrost kept crash-looping on startup. * fix(bifrost): resolve install dir lazily so version read honors runtime DATA_DIR Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> Co-authored-by: seanford <seanford@users.noreply.github.com>

) * fix embedded CLIProxyAPI config flag * preserve embedded CLIProxyAPI config * test(services): add fs-backed regression test for cliproxy resolveSpawnArgs (cheaper-inference#6877) The existing cliproxy.test.ts only re-asserted string literals and never called the real resolveSpawnArgs() against a filesystem, so it could not have caught the -c/--config flag mismatch or the config.yaml clobbering bug this PR fixes. Add a test that imports the real function against a temp DATA_DIR and asserts: the spawn args always use --config (never -c), a missing config.yaml gets the default template, and an existing operator-customized config.yaml is left byte-identical. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

…aper-inference#8194) * fix(bifrost): send v-prefixed transport version, not bare semver bifrost.ts resolveSpawnArgs() set BIFROST_TRANSPORT_VERSION straight from getInstalledVersionSync(), which reads the raw "version" field out of node_modules/@maximhq/bifrost/package.json - always bare semver per npm convention (e.g. "1.6.3"). @maximhq/bifrost's own bin.js validates that env var against /^v\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?$/ or the literal "latest" and rejects anything else with "Invalid transport version format", exiting immediately. Every embedded Bifrost instance failed to start as a result. Adds formatTransportVersion() to normalize at the call site that owns the env var, so bifrost.ts and the upstream @maximhq/bifrost package both stay exactly as designed - no changes needed to bifrost itself. Strengthens the existing resolveSpawnArgs test to assert the actual v-prefix format (it previously only checked for a non-empty string, the same gap cheaper-inference#6877 called out for cliproxy's pre-existing test), and adds a dedicated regression test file covering the pure formatTransportVersion() helper plus a real-filesystem resolveSpawnArgs() integration check. Found and fixed while self-hosting OmniRoute and diagnosing why bifrost kept crash-looping on startup. * fix(bifrost): resolve install dir lazily so version read honors runtime DATA_DIR Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> Co-authored-by: seanford <seanford@users.noreply.github.com>

) * fix embedded CLIProxyAPI config flag * preserve embedded CLIProxyAPI config * test(services): add fs-backed regression test for cliproxy resolveSpawnArgs (cheaper-inference#6877) The existing cliproxy.test.ts only re-asserted string literals and never called the real resolveSpawnArgs() against a filesystem, so it could not have caught the -c/--config flag mismatch or the config.yaml clobbering bug this PR fixes. Add a test that imports the real function against a temp DATA_DIR and asserts: the spawn args always use --config (never -c), a missing config.yaml gets the default template, and an existing operator-customized config.yaml is left byte-identical. Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>

…aper-inference#8194) * fix(bifrost): send v-prefixed transport version, not bare semver bifrost.ts resolveSpawnArgs() set BIFROST_TRANSPORT_VERSION straight from getInstalledVersionSync(), which reads the raw "version" field out of node_modules/@maximhq/bifrost/package.json - always bare semver per npm convention (e.g. "1.6.3"). @maximhq/bifrost's own bin.js validates that env var against /^v\d+\.\d+\.\d+(?:-[0-9A-Za-z.-]+)?$/ or the literal "latest" and rejects anything else with "Invalid transport version format", exiting immediately. Every embedded Bifrost instance failed to start as a result. Adds formatTransportVersion() to normalize at the call site that owns the env var, so bifrost.ts and the upstream @maximhq/bifrost package both stay exactly as designed - no changes needed to bifrost itself. Strengthens the existing resolveSpawnArgs test to assert the actual v-prefix format (it previously only checked for a non-empty string, the same gap cheaper-inference#6877 called out for cliproxy's pre-existing test), and adds a dedicated regression test file covering the pure formatTransportVersion() helper plus a real-filesystem resolveSpawnArgs() integration check. Found and fixed while self-hosting OmniRoute and diagnosing why bifrost kept crash-looping on startup. * fix(bifrost): resolve install dir lazily so version read honors runtime DATA_DIR Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> --------- Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com> Co-authored-by: seanford <seanford@users.noreply.github.com>

fix embedded CLIProxyAPI config flag

f82bab7

gemini-code-assist Bot reviewed Jul 11, 2026

View reviewed changes

preserve embedded CLIProxyAPI config

3aa9c3a

professional-ALFIE changed the title ~~fix embedded CLIProxyAPI config flag~~ fix embedded CLIProxyAPI config handling Jul 11, 2026

diegosouzapw changed the base branch from main to release/v3.8.47 July 12, 2026 11:56

diegosouzapw changed the title ~~fix embedded CLIProxyAPI config handling~~ [defer] fix embedded CLIProxyAPI config handling Jul 12, 2026

diegosouzapw changed the base branch from release/v3.8.47 to release/v3.8.48 July 13, 2026 05:05

diegosouzapw changed the base branch from release/v3.8.48 to release/v3.8.49 July 13, 2026 21:57

diegosouzapw marked this pull request as ready for review July 21, 2026 17:14

diegosouzapw self-requested a review as a code owner July 21, 2026 17:14

diegosouzapw merged commit 0844163 into cheaper-inference:release/v3.8.49 Jul 21, 2026
3 checks passed

seanford mentioned this pull request Jul 22, 2026

fix(bifrost): send v-prefixed transport version, not bare semver #8194

Merged

diegosouzapw mentioned this pull request Jul 23, 2026

Release v3.8.49 #7076

Merged

Navigation Menu

Repository navigation

[defer] fix embedded CLIProxyAPI config handling - #6877

[defer] fix embedded CLIProxyAPI config handling#6877
diegosouzapw merged 3 commits into
cheaper-inference:release/v3.8.49from
professional-ALFIE:agent/fix-cliproxy-config-flag

professional-ALFIE commented Jul 11, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jul 11, 2026

Uh oh!

diegosouzapw commented Jul 12, 2026

Uh oh!

gemini-code-assist Bot commented Jul 21, 2026

Uh oh!

diegosouzapw commented Jul 21, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

professional-ALFIE commented Jul 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Why

Impact

Validation

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jul 11, 2026

Choose a reason for hiding this comment

Uh oh!

diegosouzapw commented Jul 12, 2026

Uh oh!

gemini-code-assist Bot commented Jul 21, 2026

Uh oh!

diegosouzapw commented Jul 21, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

professional-ALFIE commented Jul 11, 2026 •

edited

Loading