Skip to content

fix(accountFallback): persist per-account 429 cascade + classify 'Monthly usage limit. Resets in N days.' - #6061

Merged
diegosouzapw merged 11 commits into
cheaper-inference:release/v3.8.44from
KooshaPari:fix/429-cascade-persist-and-monthly-quota
Jul 3, 2026
Merged

fix(accountFallback): persist per-account 429 cascade + classify 'Monthly usage limit. Resets in N days.'#6061
diegosouzapw merged 11 commits into
cheaper-inference:release/v3.8.44from
KooshaPari:fix/429-cascade-persist-and-monthly-quota

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Summary

@KooshaPari
KooshaPari requested a review from diegosouzapw as a code owner July 3, 2026 06:32
@gemini-code-assist

gemini-code-assist Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

KooshaPari and others added 7 commits July 3, 2026 03:46
@KooshaPari
fix(dashboard): mark cooling panel props readonly
979f82f
@KooshaPari
fix(dashboard): make cooling panel props readonly signature
9241a81
@KooshaPari
fix(dashboard): use readonly cooling panel props alias
60f95e5
@KooshaPari
fix(dashboard): satisfy sonar readonly props rule
2651eb6
@KooshaPari
fix(open-sse): drop dead system message helper
79cfe1f
@diegosouzapw
Merge remote-tracking branch 'origin/release/v3.8.44' into fix/429-ca…
255ce9b 
…scade-persist-and-monthly-quota

# Conflicts:
#	open-sse/handlers/chatCore.ts
#	open-sse/services/accountFallback.ts
#	src/app/(dashboard)/dashboard/providers/[id]/ProviderDetailPageClient.tsx
@KooshaPari @diegosouzapw
fix(accountFallback): declare configuredCooldownMs on checkFallbackEr…
7c69b43 
…ror return type

Merge/review follow-up: the field is written in two return branches and read
downstream via a type guard; add it to the return type so typecheck passes.
Also relocates the localDb 429 cooldown wrappers into db/providers/rateLimit.ts
(Hard Rule #2 — localDb is re-export only).

Co-authored-by: diegosouzapw <diegosouza.pw@gmail.com>
@diegosouzapw

diegosouzapw commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Merged — thank you, @KooshaPari! 🙏 This is the comprehensive fix for the monthly-limit 429 cascade: a parseResetCountdownMs that handles days/hours/minutes/seconds, the opencode-monthly-quota-resets-in error rule, per-account cascade persistence, and the CoolingConnectionsPanel UI. I chose it over the overlapping #6086 (which only parsed the N days variant).

Adjustments I made on your branch before merging:

  • Hard Rule build(deps): bump actions/github-script from 7 to 8 #2: the markConnectionRateLimitedUntil / clearConnectionRateLimit wrappers were added to localDb.ts, which must stay a re-export-only layer. Relocated the logic into src/lib/db/providers/rateLimit.ts (next to setConnectionRateLimitUntil); localDb now just re-exports them, so your test's import path is unchanged.
  • Conflict resolution on the current release tip: took the release-side ClaudeMessage extraction in chatCore ([refactor] Decompose providers/[id]/page.tsx god-component (12,882 LOC → ≤800, phased/strangler) #3501), kept both new imports in accountFallback, and wrapped ConnectionsListPanel in a fragment with your CoolingConnectionsPanel using the current release prop set.
  • Declared configuredCooldownMs on the checkFallbackError return type so typecheck passes.

8/8 tests green, lint + typecheck clean. Ships in the next release.

@diegosouzapw
diegosouzapw merged commit e9d83e7 into cheaper-inference:release/v3.8.44 Jul 3, 2026
1 of 3 checks passed
This was referenced Jul 3, 2026
Closed
Merged
diegosouzapw added a commit that referenced this pull request Jul 4, 2026
@diegosouzapw
fix(dashboard): stop client CoolingConnectionsPanel dragging server D…
33ca41b 
…B barrel into browser bundle

Second base-red from #6061, surfaced once the broken Card import was fixed:

  ./node_modules/ioredis/built/connectors/StandaloneConnector.js
  Module not found: Can't resolve 'net'
  Import trace: ioredis <- rateLimiter.ts <- apiKeys.ts <- @/lib/localDb
                <- CoolingConnectionsPanel.tsx (a "use client" component)

The client panel imported `formatResetCountdown` from `@/lib/localDb` — the
server-side DB re-export barrel — which transitively pulls better-sqlite3/ioredis
(node:net) into the browser bundle. That violates the CLAUDE.md rule 'never
barrel-import from localDb'.

`formatResetCountdown` is a pure date-formatting function, so move its
implementation to the client-safe `@/shared/utils/formatting` (alongside
formatTime/formatDuration) and re-export it from db/providers/rateLimit.ts for the
existing server callers + barrel. The panel now imports it directly from the
shared util — no server code in the client bundle.

Tests (Rule #18):
- tests/unit/format-reset-countdown.test.ts (node:test, blocking test:unit) —
  pure-function coverage: null/past/invalid, s, m+s, h+m, ISO string.
- tests/unit/ui/CoolingConnectionsPanel.test.tsx mock updated to the new module.
This was referenced Jul 4, 2026
Merged
Closed
diegosouzapw added a commit that referenced this pull request Jul 4, 2026
@diegosouzapw
fix(dashboard): resolve broken Card import breaking next build (base-…
5ca28f2 
…red from #6061) (#6155)

* fix(dashboard): resolve broken Card import breaking next build (base-red from #6061)

CoolingConnectionsPanel imported `Card` from `@/components/ui/card`, a path
that does not exist in this repo (there is no shadcn-style `src/components/ui/`).
The PR->release fast-gates do not run `next build`, so the broken import slipped
in and `next build` failed with:

  Module not found: Can't resolve '@/components/ui/card'

Fix: the <Card> here was only a styled container, so replace it with a <div>
carrying the equivalent Tailwind classes (border/bg/padding + rounded-card
shadow-sm). Also normalize the file from CRLF to LF (it shipped with CRLF).

Adds a vitest/jsdom regression test (tests/unit/ui/CoolingConnectionsPanel.test.tsx)
that fails-without-fix (Vite: 'Failed to resolve import @/components/ui/card')
and passes with it, plus renders/empty-state coverage. Rule #18.

* fix(dashboard): stop client CoolingConnectionsPanel dragging server DB barrel into browser bundle

Second base-red from #6061, surfaced once the broken Card import was fixed:

  ./node_modules/ioredis/built/connectors/StandaloneConnector.js
  Module not found: Can't resolve 'net'
  Import trace: ioredis <- rateLimiter.ts <- apiKeys.ts <- @/lib/localDb
                <- CoolingConnectionsPanel.tsx (a "use client" component)

The client panel imported `formatResetCountdown` from `@/lib/localDb` — the
server-side DB re-export barrel — which transitively pulls better-sqlite3/ioredis
(node:net) into the browser bundle. That violates the CLAUDE.md rule 'never
barrel-import from localDb'.

`formatResetCountdown` is a pure date-formatting function, so move its
implementation to the client-safe `@/shared/utils/formatting` (alongside
formatTime/formatDuration) and re-export it from db/providers/rateLimit.ts for the
existing server callers + barrel. The panel now imports it directly from the
shared util — no server code in the client bundle.

Tests (Rule #18):
- tests/unit/format-reset-countdown.test.ts (node:test, blocking test:unit) —
  pure-function coverage: null/past/invalid, s, m+s, h+m, ISO string.
- tests/unit/ui/CoolingConnectionsPanel.test.tsx mock updated to the new module.
diegosouzapw added a commit that referenced this pull request Jul 4, 2026
@diegosouzapw
fix(release): v3.8.44 Phase-0 pre-flight — base-red sweep + ratchet a…
979a7c6 
…bsorption

- fix(models): stop resolveProviderAlias at registered provider ids so oc/
  reaches the no-auth opencode provider again (#2901 contract, regressed by
  #5918's transitive chain; transitivity kept across alias-only hops)
- fix(auggie): handle async EPIPE 'error' events on child stdin so a
  fast-exiting CLI surfaces a sanitized error instead of crashing (both
  spawn sites); deflakes auggie-executor tests
- test: align provider family count 166->167 (Kenari #6104), regenerate
  translate-path golden on Linux (+kenari), opencode quota scope
  provider->connection (#6061)
- quality(test-masking): add _deletedWithReplacement allowlist support to
  check-test-masking.mjs (deletion exempt ONLY when the declared replacement
  test exists in HEAD; 5 new gate unit tests) + reduction allowlist entries
  for the verified #5958/#6088/#5816 migrations + targetExhaustion->
  combo-target-exhaustion replacement (#5976, 21 cases/52 asserts vs 13/37)
- quality(file-size): absorb v3.8.44 cycle drift (oauth route 960,
  providerLimits 998, chat 1662, auth 2426) with justification; #6158 will
  restore the oauth-route freeze
- changelog: bullets for the above + the #6155 cooling-panel build fix
@diegosouzapw diegosouzapw mentioned this pull request Jul 4, 2026
Merged
diegosouzapw added a commit that referenced this pull request Jul 4, 2026
@diegosouzapw
chore(release): v3.8.44 — 2026-07-04
babb759 
Release reconciliation + close (generate-release Phases 0a/1):
- CHANGELOG [3.8.44]: 21 PR refs added to existing bullets, 62 new bullets
  (incl. restoration of ~10 bullets erased by the stale-branch merge in
  1f6ec5b), 3 Maintenance rollups, #6061/#6130 credit fixes, 🙌 Contributors
  table (35 external contributors) — coverage 144/153 cycle commits by #ref
- 42 docs/i18n CHANGELOG mirrors synced (EN content; i18n workflow translates)
- README: What's New refreshed for v3.8.44 highlights
- build scope: exclude electron/node_modules + electron/dist-electron + .build
  from tsconfig (local build-output leak poisoned next build with 8GB OOM —
  same class as the 2026-06-25 incident; scope 14765→5207, gate green)
- quality: cyclomatic baseline 2026→2028 (+2 inherited end-of-cycle drift;
  verified the release-captain code fixes add 0 new violations)
@diegosouzapw diegosouzapw mentioned this pull request Jul 15, 2026
Closed
tkgo11 pushed a commit to tkgo11/OmniRoute that referenced this pull request Sep 23, 2026
@KooshaPari
fix(accountFallback): persist per-account 429 cascade + classify 'Mon…
b429923 
…thly usage limit. Resets in N days.' (cheaper-inference#6061)

Persist per-account 429 cascade + classify 'Monthly usage limit. Resets in N days'. Integrated into release/v3.8.44.
tkgo11 pushed a commit to tkgo11/OmniRoute that referenced this pull request Sep 23, 2026
@diegosouzapw
fix(dashboard): resolve broken Card import breaking next build (base-…
9ac1996 
…red from cheaper-inference#6061) (cheaper-inference#6155)

* fix(dashboard): resolve broken Card import breaking next build (base-red from cheaper-inference#6061)

CoolingConnectionsPanel imported `Card` from `@/components/ui/card`, a path
that does not exist in this repo (there is no shadcn-style `src/components/ui/`).
The PR->release fast-gates do not run `next build`, so the broken import slipped
in and `next build` failed with:

  Module not found: Can't resolve '@/components/ui/card'

Fix: the <Card> here was only a styled container, so replace it with a <div>
carrying the equivalent Tailwind classes (border/bg/padding + rounded-card
shadow-sm). Also normalize the file from CRLF to LF (it shipped with CRLF).

Adds a vitest/jsdom regression test (tests/unit/ui/CoolingConnectionsPanel.test.tsx)
that fails-without-fix (Vite: 'Failed to resolve import @/components/ui/card')
and passes with it, plus renders/empty-state coverage. Rule cheaper-inference#18.

* fix(dashboard): stop client CoolingConnectionsPanel dragging server DB barrel into browser bundle

Second base-red from cheaper-inference#6061, surfaced once the broken Card import was fixed:

  ./node_modules/ioredis/built/connectors/StandaloneConnector.js
  Module not found: Can't resolve 'net'
  Import trace: ioredis <- rateLimiter.ts <- apiKeys.ts <- @/lib/localDb
                <- CoolingConnectionsPanel.tsx (a "use client" component)

The client panel imported `formatResetCountdown` from `@/lib/localDb` — the
server-side DB re-export barrel — which transitively pulls better-sqlite3/ioredis
(node:net) into the browser bundle. That violates the CLAUDE.md rule 'never
barrel-import from localDb'.

`formatResetCountdown` is a pure date-formatting function, so move its
implementation to the client-safe `@/shared/utils/formatting` (alongside
formatTime/formatDuration) and re-export it from db/providers/rateLimit.ts for the
existing server callers + barrel. The panel now imports it directly from the
shared util — no server code in the client bundle.

Tests (Rule cheaper-inference#18):
- tests/unit/format-reset-countdown.test.ts (node:test, blocking test:unit) —
  pure-function coverage: null/past/invalid, s, m+s, h+m, ISO string.
- tests/unit/ui/CoolingConnectionsPanel.test.tsx mock updated to the new module.
tkgo11 pushed a commit to tkgo11/OmniRoute that referenced this pull request Sep 23, 2026
@diegosouzapw
fix(release): v3.8.44 Phase-0 pre-flight — base-red sweep + ratchet a…
87211ef 
…bsorption

- fix(models): stop resolveProviderAlias at registered provider ids so oc/
  reaches the no-auth opencode provider again (cheaper-inference#2901 contract, regressed by
  cheaper-inference#5918's transitive chain; transitivity kept across alias-only hops)
- fix(auggie): handle async EPIPE 'error' events on child stdin so a
  fast-exiting CLI surfaces a sanitized error instead of crashing (both
  spawn sites); deflakes auggie-executor tests
- test: align provider family count 166->167 (Kenari cheaper-inference#6104), regenerate
  translate-path golden on Linux (+kenari), opencode quota scope
  provider->connection (cheaper-inference#6061)
- quality(test-masking): add _deletedWithReplacement allowlist support to
  check-test-masking.mjs (deletion exempt ONLY when the declared replacement
  test exists in HEAD; 5 new gate unit tests) + reduction allowlist entries
  for the verified cheaper-inference#5958/cheaper-inference#6088/cheaper-inference#5816 migrations + targetExhaustion->
  combo-target-exhaustion replacement (cheaper-inference#5976, 21 cases/52 asserts vs 13/37)
- quality(file-size): absorb v3.8.44 cycle drift (oauth route 960,
  providerLimits 998, chat 1662, auth 2426) with justification; cheaper-inference#6158 will
  restore the oauth-route freeze
- changelog: bullets for the above + the cheaper-inference#6155 cooling-panel build fix
tkgo11 pushed a commit to tkgo11/OmniRoute that referenced this pull request Sep 23, 2026
@diegosouzapw
chore(release): v3.8.44 — 2026-07-04
b4d8b24 
Release reconciliation + close (generate-release Phases 0a/1):
- CHANGELOG [3.8.44]: 21 PR refs added to existing bullets, 62 new bullets
  (incl. restoration of ~10 bullets erased by the stale-branch merge in
  592c003), 3 Maintenance rollups, cheaper-inference#6061/cheaper-inference#6130 credit fixes, 🙌 Contributors
  table (35 external contributors) — coverage 144/153 cycle commits by #ref
- 42 docs/i18n CHANGELOG mirrors synced (EN content; i18n workflow translates)
- README: What's New refreshed for v3.8.44 highlights
- build scope: exclude electron/node_modules + electron/dist-electron + .build
  from tsconfig (local build-output leak poisoned next build with 8GB OOM —
  same class as the 2026-06-25 incident; scope 14765→5207, gate green)
- quality: cyclomatic baseline 2026→2028 (+2 inherited end-of-cycle drift;
  verified the release-captain code fixes add 0 new violations)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegosouzapw diegosouzapw Awaiting requested review from diegosouzapw diegosouzapw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KooshaPari @diegosouzapw