Repository navigation
fix(dashboard): /dashboard/context parent route + missing sidebar.gamificationGroup i18n (#5298) - #5306
Merged
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
….gamificationGroup i18n (#5298) Two of the console failures reported in #5298 (the service-log lazy-init, empty-install body and Tailscale CGNAT items are covered by #5299): - /dashboard/context had only sub-routes and no parent page, so RSC prefetches of the bare segment 404'd. Add a parent page that redirects to the canonical sub-route (/dashboard/context/settings), honoring a legacy ?tab= query. - The Gamification sidebar group referenced sidebar.gamificationGroup, a key present in no locale -> MISSING_MESSAGE warning at runtime (UI still rendered via titleFallback). Add the key across all 42 locales. Regression guard: tests/unit/dashboard/context-parent-redirect-5298.test.ts. Co-authored-by: KooshaPari <KooshaPari@users.noreply.github.com>
diegosouzapw
force-pushed
the
fix/5298-services-dashboard-fixes
branch
from
June 29, 2026 06:51
ebf6849 to
09b85a2
Compare
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
….gamificationGroup i18n (cheaper-inference#5298) (cheaper-inference#5306) Integrated into release/v3.8.40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #5298 — the two items not covered by @KooshaPari's #5299 (which handles service-log lazy-init, empty-install bodies and Tailscale CGNAT coverage).
1.
/dashboard/contextparent route 404The compression-context hub had only sub-routes (
settings,combos,caveman,rtk,headroom,session-dedup,ccr,llmlingua,lite,aggressive,ultra) and no parentpage.tsx, so Next.js RSC prefetches of the bare/dashboard/contextsegment returned 404 (/dashboard/context?_rsc=… → 404). Added a parent page thatredirect()s to the canonical sub-route (/dashboard/context/settings), honoring a legacy?tab=query for deep links — mirroring the existing/dashboard/settingsparent pattern.2. Missing
sidebar.gamificationGroupi18n messagesrc/shared/constants/sidebarVisibility.tsreferencestitleKey: "gamificationGroup"for the Gamification group, but that key existed in none of the 42 locales → runtimeMISSING_MESSAGE: sidebar.gamificationGroup (en)(the group still rendered via itstitleFallback: "Gamification", so it was a console warning, not a broken UI). Added the key to all 42 locales (English value, matching the fallback), so coverage is unchanged and the warning is gone.Not included (deliberate)
/api/v1/providers/cliproxyapi/modelsprovider-id mapping → needs a product decision on whatcliproxyapishould resolve to (left for follow-up).Validation
tests/unit/dashboard/context-parent-redirect-5298.test.ts— pureresolveContextRouteresolver (default + known-tab + unknown-tab fallback), 3/3 pass; every mapped target verified to exist as a real sub-route.typecheck:coreclean,eslint0 errors,prettier --checkclean.check-ui-keys-coverage --threshold=65(the CI threshold) passes at 77.5% (unchanged);check:test-discoveryOK (new test collected).