Repository navigation
test(combo): reconcile #4279 stop-guard test with #5249 advance policy - #5300
Merged
Merged
Conversation
#5249 deliberately changed a MODEL_CAPACITY 400 ('model X not supported with this account') from STOP to ADVANCE-to-next-combo-target, since a different model in the combo may be supported. It added a regression test in combo-strategies.test.ts but did not update the separate combo-body-specific-400-stop-4279.test.ts, which still asserted the old STOP behavior for that exact model-not-supported text — leaving the release branch red on the Unit 2/2 shard (every PR inherited the failure). Re-point the #4279 test at a genuinely body-specific malformed 400 ('invalid message format'), which still recurs identically on every target and must STOP. This preserves the #2101 anti-loop {ok,response} contract coverage while the advance-on-model-400 path stays covered by combo-strategies.test.ts. Test-only; no production behavior change.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
This was referenced Jul 23, 2026
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…eaper-inference#5249 advance policy (cheaper-inference#5300) cheaper-inference#5249 deliberately changed a MODEL_CAPACITY 400 ('model X not supported with this account') from STOP to ADVANCE-to-next-combo-target, since a different model in the combo may be supported. It added a regression test in combo-strategies.test.ts but did not update the separate combo-body-specific-400-stop-4279.test.ts, which still asserted the old STOP behavior for that exact model-not-supported text — leaving the release branch red on the Unit 2/2 shard (every PR inherited the failure). Re-point the cheaper-inference#4279 test at a genuinely body-specific malformed 400 ('invalid message format'), which still recurs identically on every target and must STOP. This preserves the cheaper-inference#2101 anti-loop {ok,response} contract coverage while the advance-on-model-400 path stays covered by combo-strategies.test.ts. Test-only; no production behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
origin/release/v3.8.40is currently red on the Unit 2/2 shard —tests/unit/combo-body-specific-400-stop-4279.test.tsfails. This blocks every open PR (the failure is inherited via the merge-with-base CI checkout), including #5294 and #5287.Root cause
#5249 (merged) deliberately reversed the policy for a
MODEL_CAPACITY400 ("model X is not supported with this account"): it now advances to the next combo target instead of stopping, because a different model in the combo may be supported. #5249 added a regression test incombo-strategies.test.ts(16/16 green) but did not reconcile the pre-existingcombo-body-specific-400-stop-4279.test.ts, which still asserted the old STOP behavior for that exact model-not-supported text. Two suite tests now asserted opposite behavior for the same 400 → release red. (#5249's note 'combo-strategies suite 16/16 green' only ran that one file, not the separate #4279 file.)Fix (test-only)
Re-point the #4279 test at a genuinely body-specific malformed 400 (
"invalid message format"→ matchesMALFORMED_REQUEST_PATTERNS), which still recurs identically on every target and must STOP. This preserves the #2101 anti-loop{ok,response}contract coverage, while the advance-on-model-400 path stays covered bycombo-strategies.test.ts.No production behavior change.
Validation
combo-body-specific-400-stop-4279.test.ts— ✓ 3× (stops at target 1, surfaces 400)combo-strategies.test.ts— ✓ 16/16 (advance-on-model-400 intact)