Skip to content

fix: recognize Claude API format in detectMalformedNonStream #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
herjarsa wants to merge 2 commits into from
Closed

fix: recognize Claude API format in detectMalformedNonStream #5096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f084fb0
fix: recognize Claude API format in detectMalformedNonStream
herjarsa Jun 26, 2026
33c964d
fix(diagnostics): add defensive null/type check for Claude content ar…
herjarsa Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions open-sse/utils/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,26 @@ export function detectMalformedNonStream(resp: unknown): MalformedReason | null
return null;
}

// ── Claude API shape (native passthrough: type:"message" + content:[]) ──
if (body.type === "message") {
const content = body.content;
if (!Array.isArray(content) || content.length === 0) return "empty_choices";

const hasOutput = content.some((block: Record<string, unknown>) => {
if (block === null || typeof block !== "object") return false;
if (block.type === "text" && typeof block.text === "string" && block.text.length > 0)
return true;
if (block.type === "tool_use") return true;
if (block.type === "tool_result") return true;
return false;
});
Comment on lines +208 to +215

@gemini-code-assist gemini-code-assist Bot Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current implementation does not defensively check if block is a non-null object before accessing its properties (e.g., block.type). If the upstream response is malformed and contains non-object elements in the content array, this will throw a runtime TypeError and crash the request.

Additionally:

  1. The type assertion (block.text as string) is redundant because the typeof block.text === "string" check already narrows the type of block.text to string.
  2. Typing the callback parameter directly as Record<string, unknown> can cause compilation errors under strictFunctionTypes when the array element type is unknown.
    const hasOutput = (content as unknown[]).some((block) => {
      if (!block || typeof block !== "object") return false;
      const b = block as Record<string, unknown>;
      if (b.type === "text" && typeof b.text === "string" && b.text.length > 0) {
        return true;
      }
      if (b.type === "tool_use" || b.type === "tool_result") return true;
      return false;
    });


if (!hasOutput) return "empty_choices";
const stopReason = body.stop_reason;
if (stopReason === null) return "no_terminal";
return null;
}

// ── Chat Completions shape ──
const choices = body.choices;
if (!Array.isArray(choices) || choices.length === 0) return "empty_choices";
Expand Down
Loading