Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the endpoint dashboard page by modularizing EndpointPageClient.tsx. It extracts the EndpointCard, EndpointSection, and ProviderModelsModal components, along with shared types and constants, into separate files (EndpointCard.tsx, EndpointSection.tsx, ProviderModelsModal.tsx, and helpers.ts). Additionally, it updates the unit tests in auto-combos-free-models-routes.test.ts to disable login requirements before each test. Feedback suggests cleaning up the process.env.INITIAL_PASSWORD environment variable in the test's beforeEach hook to prevent potential test pollution and ensure proper isolation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| test.beforeEach(async () => { | ||
| await settingsDb.updateSettings({ requireLogin: false }); | ||
| }); |
There was a problem hiding this comment.
To prevent test pollution and ensure proper test isolation, it is highly recommended to clean up any modified environment variables in the beforeEach hook. Currently, if a test that sets process.env.INITIAL_PASSWORD fails before deleting it, the environment variable remains set for subsequent tests, which can lead to flaky test runs.
Adding delete process.env.INITIAL_PASSWORD; to the beforeEach hook ensures a clean slate for every test.
test.beforeEach(async () => {
await settingsDb.updateSettings({ requireLogin: false });
delete process.env.INITIAL_PASSWORD;
});… test (pre-existing)
EndpointTab type and tab labels moved to helpers.ts during EndpointPageClient.tsx modularization. Updated test assertions to check both EndpointPageClient.tsx and helpers.ts.
|
Pushed fixes for test failures caused by the modularization. All CI gates pass locally (typecheck, known-symbols, file-size, provider-consistency, 14/14 quality gates). CI docs-symbols failure is a pre-existing environment issue (passes locally). |
|
Thanks @oyi77 🙏 — this is solid work in exactly the right direction (it maps to Tier 5 of our
Your decomposition ( |
Rebased onto v3.8.35. Extracts 4 components from 2563-line EndpointPageClient.tsx. All CI gates pass. Supersedes #4700. Part of #3594.