Repository navigation
refactor(chatCore): recupera os 4 leaves perdidos no churn de merge (key-health, request-format, claude-effort, target-format) (#3501) - #4538
Merged
Conversation
…3501) Move o closure `recordKeyHealthStatus` (~56 ln) do topo de handleChatCore para o novo leaf open-sse/handlers/chatCore/keyHealth.ts, byte-idêntico: 401 → recordKeyFailure + persist sempre; 2xx → recordKeySuccess + persist só na recuperação de warning/invalid; demais status apenas atualizam o set de extra-keys. O handler mantém um closure fino de binding que repassa `log`, então os 2 call sites ficam inalterados. Imports que ficaram órfãos (recordKeyFailure / recordKeySuccess / trackConnectionExtraKeys / KeyHealth) migram para o leaf; connectionHasExtraKeys permanece (ainda usado no site de rotação) e updateProviderConnection é importado em ambos (usado em vários pontos do handler). chatCore.ts 5110->5055 (shrink -55); baseline file-size ratchetado. complexity 1905=1905 (neutro). Coberto por tests/unit/chatcore-key-health.test.ts (6 casos — transições in-memory do apiKeyRotator: warning/invalid no threshold, recuperação 2xx, escopo por selectedKeyId, no-op sem connectionId e em status fora de 401/2xx).
…ro (#3501) Move o bloco de resolução de formato do topo de handleChatCore (endpointPath / sourceFormat / isResponsesEndpoint / nativeCodexPassthrough / isDroidCLI / copilotCompatibleReasoning / clientResponseFormat) para o novo leaf puro open-sse/handlers/chatCore/requestFormat.ts (resolveChatCoreRequestFormat), ao lado de resolveChatCoreRequestSetup (fase de request-setup). O handler agora desestrutura o resultado, então todo uso downstream fica byte-idêntico. A função local isCopilotClient (usada só por esse bloco) vira helper privado do leaf; o import órfão detectFormatFromEndpoint migra junto (getTargetFormat permanece no import de provider). shouldUseNativeCodexPassthrough e FORMATS seguem importados no handler (re-exportado / usado em vários pontos). chatCore.ts 5019->4993 (shrink -26, cruza abaixo de 5000); baseline file-size ratchetado. complexity 1905=1905 (neutro). Coberto por tests/unit/chatcore-request-format.test.ts (7 casos, incluindo o downgrade OpenAI-Responses->OpenAI e sua supressão pelo Droid CLI).
…3501) Move o bloco de effort-variant do Claude/Claude-Code do topo de handleChatCore (strip de claude-...-{low,medium,high,xhigh,max} de volta ao id base + expõe o nível como reasoning_effort; effort explícito do cliente vence; passthrough nativo com sourceFormat==='claude' fica intocado) para o novo leaf open-sse/handlers/chatCore/claudeEffortVariant.ts (applyClaudeEffortVariant). A função muta o body in-place e retorna { effectiveModel, log }, que o handler aplica (reatribuição de effectiveModel + log?.info), byte-idêntico. Import órfão splitClaudeEffortSuffix migra para o leaf (getModelTargetFormat / PROVIDER_ID_TO_ALIAS permanecem no import de providerModels); isClaudeCodeCompatibleProvider e FORMATS seguem no handler (usados em outros pontos). A detecção de effort explícito foi isolada no helper privado hasExplicitClaudeEffort para manter applyClaudeEffortVariant abaixo do teto de complexidade (16->≤15; mesmo padrão de resolveContextCachePin/ markConnectionLevelExhaustion). chatCore.ts 4993->4978 (shrink -15); baseline file-size ratchetado. complexity 1905=1905 (neutro). Coberto por tests/unit/chatcore-claude-effort-variant.test.ts (7 casos).
…3501) Move a resolução de wire target-format do topo de handleChatCore para o novo leaf puro open-sse/handlers/chatCore/targetFormat.ts (resolveChatCoreTargetFormat), ao lado de resolveChatCoreRequestSetup/resolveChatCoreRequestFormat. Retorna { alias, targetFormat }: apiFormat==='responses' força OpenAI Responses; senão o target-format do modelo no registry, depois o override custom (#2905), depois o default do provider. O handler desestrutura — `alias` segue reusado downstream ao remover o prefixo alias/ do model id upstream. Imports órfãos (getModelTargetFormat / PROVIDER_ID_TO_ALIAS / getTargetFormat) migram para o leaf; FORMATS permanece no handler (usado em vários pontos). Tamanho de chatCore.ts neutro (call+comentário compensa os 2 imports removidos), mas a lógica agora é unit-testada e co-localizada. complexity 1905=1905; typecheck 0. Coberto por tests/unit/chatcore-target-format.test.ts (5 casos, asseridos contra a composição inline).
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Jun 21, 2026
# Conflicts: # open-sse/handlers/chatCore.ts
This was referenced Jun 21, 2026
Merged
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…key-health, request-format, claude-effort, target-format) (cheaper-inference#3501) (cheaper-inference#4538) Integrated into release/v3.8.33 (resolved overlap with cheaper-inference#4547: requestFormat/claudeEffort leaves already restored, this adds keyHealth/targetFormat + wires all 4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto — recuperação
Durante a virada de release v3.8.32 → v3.8.33 + o re-home automático + merges concorrentes, a cadeia stacked de 7 leaves do chatCore (#3501) embaralhou:
service-tier/codex-quota/background-redirectlandaram emrelease/v3.8.33, mas 4 leaves se perderam — seus PRs aparecem "MERGED"/"CLOSED" porém o conteúdo não está em v3.8.33 (as merges desyncaram com force-pushes de rebase concorrentes).Este PR recupera os 4 leaves faltantes num único branch limpo, cherry-picado sobre o tip atual de
release/v3.8.33(948213899), preservando 1 commit por leaf:recordKeyHealthStatus→chatCore/keyHealth.tschatcore-key-health.test.tsresolveChatCoreRequestFormat→chatCore/requestFormat.tschatcore-request-format.test.tsapplyClaudeEffortVariant→chatCore/claudeEffortVariant.tschatcore-claude-effort-variant.test.tsresolveChatCoreTargetFormat→chatCore/targetFormat.tschatcore-target-format.test.tsTodos são extrações byte-idênticas (já descritas nos PRs originais).
codex-quotaebackground-redirectnão estão aqui (já em v3.8.33).Gates
translation-pathsflaky pré-existente).chatcore-imports-cleanly✓.1908 > 1906.release/v3.8.33sem os leaves: ela sozinha já reporta 1908 (meus 4 leaves são complexity-neutros:recordKeyHealthStatusé um closure que apenas muda de inline→named, e os demais ficam <15). O owner reconciliou file-size no chore(quality): reconcile file-size baseline (owner final #4495/#4504/#4505/#4508) #4535; o complexity baseline precisa do mesmo bump (1906→1908) — fora do escopo deste refactor.Extração de god-file sem mudança de comportamento em runtime. Encerra o gap de recuperação dos 4 leaves.