Repository navigation
feat(dashboard): inline show/hide toggle for API keys on API Manager page #4505
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import { describe, it } from "node:test"; | ||
| import assert from "node:assert/strict"; | ||
| import { | ||
| maskKey, | ||
| toggleKeyVisibility, | ||
| } from "../../src/app/(dashboard)/dashboard/api-manager/apiManagerPageUtils.js"; | ||
|
|
||
| describe("maskKey", () => { | ||
| it("returns empty string when key is missing or empty", () => { | ||
| assert.equal(maskKey(""), ""); | ||
| assert.equal(maskKey(null), ""); | ||
| assert.equal(maskKey(undefined), ""); | ||
| }); | ||
|
|
||
| it("returns the key untouched when it fits the visible budget (<=8 chars)", () => { | ||
| assert.equal(maskKey("sk"), "sk"); | ||
| assert.equal(maskKey("sk-12345"), "sk-12345"); | ||
| }); | ||
|
|
||
| it("keeps the first 8 chars and appends an ellipsis when the key is longer", () => { | ||
| const full = "sk-or-1234567890abcdef"; | ||
| const masked = maskKey(full); | ||
| assert.equal(masked.startsWith("sk-or-12"), true); | ||
| assert.equal(masked.endsWith("..."), true); | ||
| // Must not leak the tail | ||
| assert.equal(masked.includes("90abcdef"), false); | ||
| }); | ||
| }); | ||
|
|
||
| describe("toggleKeyVisibility", () => { | ||
| it("adds an id when it is not present", () => { | ||
| const next = toggleKeyVisibility(new Set<string>(), "k1"); | ||
| assert.equal(next.has("k1"), true); | ||
| assert.equal(next.size, 1); | ||
| }); | ||
|
|
||
| it("removes an id when it is already present", () => { | ||
| const next = toggleKeyVisibility(new Set<string>(["k1", "k2"]), "k1"); | ||
| assert.equal(next.has("k1"), false); | ||
| assert.equal(next.has("k2"), true); | ||
| assert.equal(next.size, 1); | ||
| }); | ||
|
|
||
| it("returns a NEW Set (does not mutate the input — React state safety)", () => { | ||
| const input = new Set<string>(["k1"]); | ||
| const output = toggleKeyVisibility(input, "k2"); | ||
| assert.notEqual(output, input); | ||
| assert.equal(input.has("k2"), false); | ||
| assert.equal(output.has("k2"), true); | ||
| }); | ||
| }); | ||
|
Comment on lines
+1
to
+51
Contributor
There was a problem hiding this comment. Since the project uses Vitest (as indicated by Here is how the test file can be refactored to use Vitest: import { describe, it, expect } from "vitest";
import {
maskKey,
toggleKeyVisibility,
} from "../../src/app/(dashboard)/dashboard/api-manager/apiManagerPageUtils.js";
describe("maskKey", () => {
it("returns empty string when key is missing or empty", () => {
expect(maskKey("")).toBe("");
expect(maskKey(null)).toBe("");
expect(maskKey(undefined)).toBe("");
});
it("returns the key untouched when it fits the visible budget (<=8 chars)", () => {
expect(maskKey("sk")).toBe("sk");
expect(maskKey("sk-12345")).toBe("sk-12345");
});
it("keeps the first 8 chars and appends an ellipsis when the key is longer", () => {
const full = "sk-or-1234567890abcdef";
const masked = maskKey(full);
expect(masked.startsWith("sk-or-12")).toBe(true);
expect(masked.endsWith("...")).toBe(true);
expect(masked.includes("90abcdef")).toBe(false);
});
});
describe("toggleKeyVisibility", () => {
it("adds an id when it is not present", () => {
const next = toggleKeyVisibility(new Set<string>(), "k1");
expect(next.has("k1")).toBe(true);
expect(next.size).toBe(1);
});
it("removes an id when it is already present", () => {
const next = toggleKeyVisibility(new Set<string>(["k1", "k2"]), "k1");
expect(next.has("k1")).toBe(false);
expect(next.has("k2")).toBe(true);
expect(next.size).toBe(1);
});
it("returns a NEW Set (does not mutate the input — React state safety)", () => {
const input = new Set<string>(["k1"]);
const output = toggleKeyVisibility(input, "k2");
expect(output).not.toBe(input);
expect(input.has("k2")).toBe(false);
expect(output.has("k2")).toBe(true);
});
}); |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the API key is already revealed and cached in
revealedKeys, we can copy it directly from the client-side cache instead of making an unnecessary network request to/api/keys/{id}/reveal.