Repository navigation
fix(providers): prefer dedicated validators over the generic web-cookie probe (restore-green #4023) - #4463
Closed
diegosouzapw wants to merge 2 commits into
Closed
fix(providers): prefer dedicated validators over the generic web-cookie probe (restore-green #4023)#4463diegosouzapw wants to merge 2 commits into
diegosouzapw wants to merge 2 commits into
Conversation
…ie probe #4023 added ~22 providers to WEB_COOKIE_PROVIDERS and routed them all through the generic validateWebCookieProvider at the TOP of validateProviderApiKey, silently bypassing their dedicated, stricter validators (qwen-web #3958 user-object check, grok-web #3474 IP-reputation/Cloudflare guidance, chatgpt-web accessToken, ...) and downgrading them to a 200->valid session probe. That broke 41 specialty tests + qwen-web-cookie-validation-3958 and turned every TIA full-suite CI run red. Move the generic web-cookie fallback BELOW the SPECIALTY_VALIDATORS dispatch so a provider with a dedicated validator keeps its specific checks; the generic probe is the fallback only for web-cookie providers without one. This restores the pre-#4023 flow (web-cookie providers already reached SPECIALTY without openai/anthropic interception before #4023, so the reorder is provably safe). No test rewrites — all 41 specialty + qwen-web-3958 tests pass unchanged. Also reconciles two pre-existing release/v3.8.32 file-size baselines whose frozen bumps did not ride along with their squash merges (pricing.ts OpenAI rows; base.ts).
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Collaborator
Author
|
Closing as a duplicate of #4460, which lands the same fix (move the generic web-cookie validation below the SPECIALTY_VALIDATORS dispatch so providers with a dedicated validator keep their specific checks) and is already green (Fast-QG pass, MERGEABLE/CLEAN). #4460 also reconciles the #4440/#4443 baselines. Deferring to it to avoid a conflicting parallel fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore-green for a #4023 regression that turned the whole release CI red on every TIA full-suite run (it blocked every PR whose impact analysis touched provider validation — including the in-flight port PRs).
Root cause
#4023 (
web-cookie + no-auth provider validation with AUTH_007) added ~22 providers toWEB_COOKIE_PROVIDERSand placed the genericvalidateWebCookieProviderrouting at the top ofvalidateProviderApiKey. That intercepted providers that already have dedicated, stricter validators and downgraded them to a generic200 → validsession probe:qwen-web— the fix(qwen-web): cookie validation false-positive - check response body for user object #3958 user-object check (Qwen returns HTTP 200 even for invalid tokens)grok-web— the [BUG] Grok Web (Subscription) validation still fails on v3.8.16 (fill sso/sso-rw) #3474 IP-reputation / Cloudflare / anti-bot guidancechatgpt-web—accessToken/cf-mitigateddetection*-webfamily41 tests in
provider-validation-specialty.test.ts+qwen-web-cookie-validation-3958.test.tsfailed as a result.Fix
Move the generic web-cookie fallback below the
SPECIALTY_VALIDATORSdispatch. A provider with a dedicated validator keeps its specific checks; the generic probe is the fallback only for web-cookie providers without one. This restores the pre-#4023 flow — and is provably safe because web-cookie providers already reachedSPECIALTY_VALIDATORS(withoutopenai/anthropicinterception) before #4023 inserted the top-level generic block.No test rewrites — all 41 specialty + 4 qwen-web-3958 tests pass unchanged. A focused guard (
validation-web-cookie-prefer-specific-4023.test.ts) documents the dispatch preference.Test plan
provider-validation-specialty(112),qwen-web-cookie-validation-3958(4),provider-validation-web-cookie-auth007(generic), and the new guard — 122 pass / 0 fail (41 were failing before)npx eslint0 errors ·typecheck:coreclean ·check:any-budget:t11PASS ·check:route-validation:t06PASS ·check:file-sizeOKNote
Also reconciles two pre-existing release/v3.8.32 file-size baselines whose frozen bumps did not ride along with their squash merges (
pricing.tsOpenAI rows;executors/base.ts) — base drift, not changed by this PR, bumped so the merge clearscheck:file-size.