Skip to content

test: align two tests left red by merged PRs (#4335 db-rules count + #4271 arena metadata) #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 2 commits into from
Jun 20, 2026
Merged

test: align two tests left red by merged PRs (#4335 db-rules count + #4271 arena metadata) #4346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7df29f4
test(db-rules): align audited-module count to 28 (apiKey db helpers)
diegosouzapw Jun 20, 2026
ef807c5
test(web-session): align lmarena metadata to the split-cookie source …
diegosouzapw Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/unit/check-db-rules-classification.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,12 @@ test("INTENTIONALLY_INTERNAL is exported from check-db-rules.mjs", () => {
assert.ok(INTENTIONALLY_INTERNAL.size > 0, "INTENTIONALLY_INTERNAL must not be empty");
});

test("INTENTIONALLY_INTERNAL contains the expected 26 audited modules", () => {
test("INTENTIONALLY_INTERNAL contains the expected 28 audited modules", () => {
const expected = [
"_rowTypes",
"accessTokens",
"apiKeyColumnFallbacks",
"apiKeyUsageLimitFields",
"cleanup",
"cliToolState",
"comboForecast",
Expand Down
8 changes: 5 additions & 3 deletions tests/unit/web-session-credentials.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,15 @@ test("web session credential metadata identifies cookie, token, and no-auth prov
acceptsFullCookieHeader: false,
storageKeys: ["token", "userToken"],
});
// lmarena.ai's real auth cookie is `arena-auth-prod-v1`, not `session` (#3810)
// lmarena.ai's real auth cookie is `arena-auth-prod-v1`, not `session` (#3810).
// The session is now split across `arena-auth-prod-v1.0`, `.1`, … (#4271).
assert.deepEqual(webSessionCredentials.getWebSessionCredentialRequirement("lmarena"), {
kind: "cookie",
credentialName: "arena-auth-prod-v1",
placeholder: "arena-auth-prod-v1=... or full Cookie header from lmarena.ai",
placeholder:
"Paste the full Cookie header from lmarena.ai (the session is now split across arena-auth-prod-v1.0, .1, …)",
acceptsFullCookieHeader: true,
storageKeys: ["cookie", "arena-auth-prod-v1", "session"],
storageKeys: ["cookie", "arena-auth-prod-v1", "arena-auth-prod-v1.0", "arena-auth-prod-v1.1", "session"],
});
// veoaifree-web is now a NOAUTH provider — not in WEB_SESSION_CREDENTIAL_REQUIREMENTS
assert.equal(webSessionCredentials.getWebSessionCredentialRequirement("veoaifree-web"), null);
Expand Down
Loading