Skip to content

fix(quality): complexity gate cobre bin/+electron + tracked-artifacts no pre-commit (6A.11/6A.12) - #4318

Merged
diegosouzapw merged 2 commits into
release/v3.8.30from
qg-quickwins
Jun 20, 2026
Merged

diegosouzapw merged 2 commits into
release/v3.8.30from
qg-quickwins

Conversation

@diegosouzapw

Copy link
Copy Markdown
Collaborator

Contexto

Fecha dois gaps residuais da Fase 6A do programa Quality Gate, descobertos na auditoria de conclusão dos planos _tasks/quality/.

6A.11 — complexity gate cobre bin/ + electron/ (corrige fake-green)

O eslint.complexity.config.mjs (files) e o complexity-baseline.json já documentavam o escopo src+open-sse+electron+bin, mas o ESLINT_ARGS de check-complexity.mjs passava apenas src open-sse — a edição do scan nunca tinha sido aplicada (ou foi revertida num merge). Resultado: gate fantasma — o gate alegava cobrir bin//electron/ e nunca os varria. Uma god-function nova em bin/ passaria verde.

  • export const ESLINT_ARGS + adiciona electron e bin (casa o config).
  • Novo teste de build (tests/unit/build/check-complexity.test.ts) trava o escopo do scan.
  • Baseline 1887 → 1888:
    • electron+bin medem 0 violações (electron só tem types.d.ts, ignorado; os 4 .ts de bin/ estão sob os thresholds) → o widening é 0-custo.
    • O +1 é drift pré-existente em src/open-sse trazido pela base release/v3.8.30 (a23d0d678, merges do ciclo incl. fix(api): semantic-cache HIT bills incremental cost 0 + X-OmniRoute-Cost-Saved (PRD-2026-06-19) #4308) — não vem do widening. O fast-path do release não roda check:complexity, então o drift só aparece aqui. Mesma família dos rebaselines anteriores; crescimento de feature, não regressão.

6A.12 — check:tracked-artifacts no pre-commit

O gate estava no CI + pre-push, mas faltava no .husky/pre-commit — e o incidente do symlink (artefato de build trackeado) acontece no git add. Adiciona a chamada ao hook, fechando o buraco no ponto mais cedo.

Validação

  • npm run lint → 0 errors.
  • npm run check:complexity → OK (1888/1888).
  • npm run check:tracked-artifacts → OK.
  • .husky/pre-commit roda ponta-a-ponta, exit 0, com [tracked-artifacts] OK.
  • tests/unit/build/*.test.ts → 294/294 pass.

🤖 Generated with Claude Code

…n fix)

ESLINT_ARGS passava só 'src open-sse', mas o config eslint.complexity.config.mjs
e o complexity-baseline.json já documentavam o escopo src+open-sse+electron+bin.
A edição do scan nunca tinha sido aplicada: o gate alegava cobrir bin/electron e
nunca os varria (fake-green — uma god-function nova em bin/ passava verde).

- exporta ESLINT_ARGS + adiciona 'electron' e 'bin' (casa o config)
- teste de build trava o escopo do scan
- baseline 1887->1888: electron+bin medem 0 (widening 0-custo); o +1 é drift
  pré-existente de src/open-sse da base a23d0d6 (#4308 et al.), não do widening
O gate estava no CI + pre-push, mas faltava no pre-commit — e o incidente do
symlink (artefato de build trackeado) acontece no 'git add'. Fecha o buraco no
ponto mais cedo.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@diegosouzapw
diegosouzapw merged commit ad43384 into release/v3.8.30 Jun 20, 2026
4 checks passed
diegosouzapw added a commit that referenced this pull request Jun 20, 2026
… drift) (#4330)

#4313 (harvested features) and #4323 (compression e2e audit) added new conditional
branches that landed after #4318 measured 1888; the release fast-path doesn't run
check:complexity, so reconcile on the merged release tip (Rule #9, release-volatile).
@diegosouzapw diegosouzapw mentioned this pull request Jun 20, 2026
@diegosouzapw
diegosouzapw deleted the qg-quickwins branch June 21, 2026 12:33
tkgo11 pushed a commit to tkgo11/OmniRoute that referenced this pull request Sep 23, 2026
…s in pre-commit (cheaper-inference#4318)

* fix(quality): complexity gate varre bin/ + electron (6A.11, fake-green fix)

ESLINT_ARGS passava só 'src open-sse', mas o config eslint.complexity.config.mjs
e o complexity-baseline.json já documentavam o escopo src+open-sse+electron+bin.
A edição do scan nunca tinha sido aplicada: o gate alegava cobrir bin/electron e
nunca os varria (fake-green — uma god-function nova em bin/ passava verde).

- exporta ESLINT_ARGS + adiciona 'electron' e 'bin' (casa o config)
- teste de build trava o escopo do scan
- baseline 1887->1888: electron+bin medem 0 (widening 0-custo); o +1 é drift
  pré-existente de src/open-sse da base ecbbff1 (cheaper-inference#4308 et al.), não do widening

* fix(quality): check:tracked-artifacts no pre-commit (6A.12)

O gate estava no CI + pre-push, mas faltava no pre-commit — e o incidente do
symlink (artefato de build trackeado) acontece no 'git add'. Fecha o buraco no
ponto mais cedo.
tkgo11 pushed a commit to tkgo11/OmniRoute that referenced this pull request Sep 23, 2026
… drift) (cheaper-inference#4330)

cheaper-inference#4313 (harvested features) and cheaper-inference#4323 (compression e2e audit) added new conditional
branches that landed after cheaper-inference#4318 measured 1888; the release fast-path doesn't run
check:complexity, so reconcile on the merged release tip (Rule cheaper-inference#9, release-volatile).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant