Repository navigation
feat(compression): expose the WaterfallInspector via a Canvas/Waterfall toggle - #4238
Merged
Merged
Conversation
…ll toggle WaterfallInspector (A1) — the plain-div, Langfuse-style per-engine savings list view of a CompressionRunModel — was fully built and unit-tested but had zero importers, so it never rendered. The Compression Studio cockpit only showed the ReactFlow canvas (A2). Add a Canvas/Waterfall segmented toggle to the cockpit header. The waterfall view renders the same run prop (no extra data wiring); replay controls show only in canvas mode since the waterfall is static. Default stays canvas, so existing behavior is unchanged. Test: cockpit toggle shows both buttons, switches to the waterfall inspector (and hides the canvas) and back. Full UI suite for the studio green (18/18); typecheck:core + lint clean.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Merged
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…ll toggle (cheaper-inference#4238) Integrated into release/v3.8.29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cauda longa do programa "compressão 100% funcional" — item 3/6
Problema
WaterfallInspector(A1) — a view em divs (estilo Langfuse) que lista a economia por engine de umCompressionRunModel— estava totalmente construída e testada (waterfallInspector.test.tsx, 8 testes) mas tinha zero importadores: nunca renderizava. O cockpit do Compression Studio só exibia o canvas ReactFlow (A2).Fix
Toggle segmentado Canvas / Waterfall no header do
CompressionCockpit:run(sem fiação de dados extra — ambas consomemCompressionRunModel).Componente órfão agora alcançável pelo usuário. Zero mudança no
WaterfallInspector.tsx(já estava pronto).Teste (TDD — RED→GREEN)
compressionCockpit.test.tsx(+2 testes): o toggle expõe os dois botões; clicar em Waterfall monta owaterfall-inspector(e esconde o.react-flow), mostra a economia total (−51.2%), e clicar em Canvas restaura o canvas.Validação: suíte UI do studio 18/18 (cockpit 10 + waterfall 8) ✓ ·
typecheck:core✓ ·lint✓