Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions open-sse/config/providers/registry/theoldllm/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@ export const theoldllmProvider: RegistryEntry = {
baseUrls: ["https://theoldllm.vercel.app/api/chatgpt"],
authType: "none",
authHeader: "none",
defaultContextLength: 200000,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Setting defaultContextLength to 200000 as a provider-wide fallback is unsafe. Standard models like GPT_4o (which has a maximum context window of 128k/131,072 tokens) will inherit this 200k limit, leading to potential context overflow errors when downstream clients attempt to send payloads up to 200k.\n\nAdditionally, because passthroughModels is enabled, any unknown models requested through this provider will also default to 200k, which exceeds the limits of many common models.\n\nIt is highly recommended to set defaultContextLength to 128000 (128k) as a safe fallback, and explicitly define the larger context windows on the specific models that support them.

Suggested change
defaultContextLength: 200000,
defaultContextLength: 128000,

models: [
{ id: "GPT_5_4", name: "GPT-5.4 (The Old LLM 🆓)" },
{ id: "GPT_5_4", name: "GPT-5.4 (The Old LLM 🆓)", contextLength: 400000 },

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the Repository Style Guide (Rule 9), changing production code under open-sse/ requires including tests. Please ensure that appropriate unit or integration tests are added or updated in the tests/ directory to cover these new context length configurations.

References
  1. Always include tests when changing production code (src/, open-sse/, electron/, bin/).

{ id: "GPT_4o", name: "GPT-4o (The Old LLM 🆓)" },
{ id: "claude_opus_4", name: "Claude Opus 4 (The Old LLM 🆓)" },
{ id: "claude_sonnet_4", name: "Claude Sonnet 4 (The Old LLM 🆓)" },
{ id: "claude_haiku_3_5", name: "Claude Haiku 3.5 (The Old LLM 🆓)" },
{ id: "deepseek_v4", name: "DeepSeek V4 (The Old LLM 🆓)" },
{ id: "gemini_3_flash", name: "Gemini 3 Flash (The Old LLM 🆓)" },
{ id: "gemini_3_pro", name: "Gemini 3 Pro (The Old LLM 🆓)" },
{ id: "claude_opus_4", name: "Claude Opus 4 (The Old LLM 🆓)", contextLength: 200000 },
{ id: "claude_sonnet_4", name: "Claude Sonnet 4 (The Old LLM 🆓)", contextLength: 200000 },
{ id: "claude_haiku_3_5", name: "Claude Haiku 3.5 (The Old LLM 🆓)", contextLength: 200000 },
{ id: "deepseek_v4", name: "DeepSeek V4 (The Old LLM 🆓)", contextLength: 200000 },
{ id: "gemini_3_flash", name: "Gemini 3 Flash (The Old LLM 🆓)", contextLength: 1000000 },
{ id: "gemini_3_pro", name: "Gemini 3 Pro (The Old LLM 🆓)", contextLength: 1000000 },
],
passthroughModels: true,
};
Loading