Skip to content

fix(mcp): resolve server entry from dist/ instead of app/ #3765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 3 commits into from
Jun 13, 2026
Merged

fix(mcp): resolve server entry from dist/ instead of app/ #3765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec78fe3
fix(publish): clean opencode-plugin node_modules after tsup build to …
diegosouzapw Jun 13, 2026
420d62b
deps: bump esbuild from 0.28.0 to 0.28.1 (#3746)
dependabot[bot] Jun 13, 2026
4e0b060
fix(mcp): resolve server entry from dist/ instead of app/
Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions bin/mcp-server.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,22 @@ const __filename = fileURLToPath(import.meta.url);
const __dirname = dirname(__filename);
const ROOT = join(__dirname, "..");

function resolveMcpEntry(rootDir = ROOT) {
/**
* @param {string} [rootDir] - project root directory (defaults to package root)
* @param {(path: string) => boolean} [existsSyncFn] - injectable fs.existsSync
* for testing; defaults to the real existsSync
* @returns {string|null} resolved absolute path to the MCP server entry, or null
*/
export function resolveMcpEntry(rootDir = ROOT, existsSyncFn = existsSync) {
const candidates = [
// Preferred distributable JS entry (npm publish artifact)
join(rootDir, "app", "open-sse", "mcp-server", "server.js"),
// Preferred distributable JS entry (npm publish artifact, built by prepublish.ts)
join(rootDir, "dist", "open-sse", "mcp-server", "server.js"),
Comment on lines +20 to +21

@gemini-code-assist gemini-code-assist Bot Jun 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to the Repository Style Guide (Rule 9), changing production code in bin/ requires including or updating tests. Please add or update tests (e.g., under tests/unit/) to verify that resolveMcpEntry correctly resolves the dist/ path.

References
  1. Always include tests when changing production code (src/, open-sse/, electron/, bin/). (link)

// Local workspace TypeScript source fallback
join(rootDir, "open-sse", "mcp-server", "server.ts"),
];

for (const entry of candidates) {
if (existsSync(entry)) return entry;
if (existsSyncFn(entry)) return entry;
}
return null;
}
Expand All @@ -32,7 +38,7 @@ export async function startMcpCli(rootDir = ROOT) {
const mcpEntry = resolveMcpEntry(rootDir);
if (!mcpEntry) {
throw new Error(
"MCP server entrypoint not found. Expected app/open-sse/mcp-server/server.js or open-sse/mcp-server/server.ts."
"MCP server entrypoint not found. Expected dist/open-sse/mcp-server/server.js or open-sse/mcp-server/server.ts."
);
}

Expand Down
Loading