Repository navigation
fix(i18n): replace missing provider delete tooltip lookup - #371
diegosouzapw merged 1 commit into
Conversation
Replace a missing deleteConnection message lookup with the existing delete label to avoid the provider-page runtime i18n overlay.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical internationalization issue on the provider detail page. It resolves a runtime error caused by an incorrect translation key lookup for the delete button's tooltip. By simply reusing an already defined and appropriate translation key, the change ensures the UI renders correctly and consistently, improving the overall user experience and system stability without introducing new, redundant translation strings. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where a missing translation key for a delete button's tooltip was causing a runtime error. The fix correctly replaces the reference to the non-existent providers.deleteConnection key with the existing providers.delete key. This change is a direct and effective solution to the problem described.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Review NotesThe PR correctly fixes a missing translation key issue:
|
bug fixes (PRs #373, #371, #372, #369 by @kfiramar): - fix(db): provider_connections.group column migration for existing DBs - fix(i18n): replace missing deleteConnection key with delete in tooltip - fix(auth): clear stale error metadata on genuine provider recovery - fix(startup): unify env loading across npm/electron startup paths code quality improvements (per kilo-code-bot review): - docs: document result.success vs response.ok patterns in auth.ts - refactor: normalize overridePath?.trim() in electron/main.js - docs: explain preferredEnv merge order intent
…elete-tooltip-i18n Thanks @kfiramar! Perfect minimal fix — `t("deleteConnection")` was requesting a non-existent key across all 30 locales, causing `MISSING_MESSAGE: providers.deleteConnection` runtime errors on every provider detail page load. Reusing the existing `providers.delete` key is the correct fix. Merged!
bug fixes (PRs cheaper-inference#373, cheaper-inference#371, cheaper-inference#372, cheaper-inference#369 by @kfiramar): - fix(db): provider_connections.group column migration for existing DBs - fix(i18n): replace missing deleteConnection key with delete in tooltip - fix(auth): clear stale error metadata on genuine provider recovery - fix(startup): unify env loading across npm/electron startup paths code quality improvements (per kilo-code-bot review): - docs: document result.success vs response.ok patterns in auth.ts - refactor: normalize overridePath?.trim() in electron/main.js - docs: explain preferredEnv merge order intent
…elete-tooltip-i18n Thanks @kfiramar! Perfect minimal fix — `t("deleteConnection")` was requesting a non-existent key across all 30 locales, causing `MISSING_MESSAGE: providers.deleteConnection` runtime errors on every provider detail page load. Reusing the existing `providers.delete` key is the correct fix. Merged!
bug fixes (PRs cheaper-inference#373, cheaper-inference#371, cheaper-inference#372, cheaper-inference#369 by @kfiramar): - fix(db): provider_connections.group column migration for existing DBs - fix(i18n): replace missing deleteConnection key with delete in tooltip - fix(auth): clear stale error metadata on genuine provider recovery - fix(startup): unify env loading across npm/electron startup paths code quality improvements (per kilo-code-bot review): - docs: document result.success vs response.ok patterns in auth.ts - refactor: normalize overridePath?.trim() in electron/main.js - docs: explain preferredEnv merge order intent
…elete-tooltip-i18n Thanks @kfiramar! Perfect minimal fix — `t("deleteConnection")` was requesting a non-existent key across all 30 locales, causing `MISSING_MESSAGE: providers.deleteConnection` runtime errors on every provider detail page load. Reusing the existing `providers.delete` key is the correct fix. Merged!
bug fixes (PRs cheaper-inference#373, cheaper-inference#371, cheaper-inference#372, cheaper-inference#369 by @kfiramar): - fix(db): provider_connections.group column migration for existing DBs - fix(i18n): replace missing deleteConnection key with delete in tooltip - fix(auth): clear stale error metadata on genuine provider recovery - fix(startup): unify env loading across npm/electron startup paths code quality improvements (per kilo-code-bot review): - docs: document result.success vs response.ok patterns in auth.ts - refactor: normalize overridePath?.trim() in electron/main.js - docs: explain preferredEnv merge order intent
Summary
providers.deleteConnectionlookup with the existingproviders.deletelabelProblem
The provider detail page was requesting
t("deleteConnection")from theprovidersnamespace.That key does not exist in the locale files. The namespace already defines:
deletedeleteConnectionConfirmbut not
deleteConnection.As a result, opening the provider detail page emitted a runtime i18n error instead of rendering a valid tooltip label for the delete button.
Root Cause
This was a bad message-key lookup in the UI, not missing locale content.
The page needed the short button label for the delete icon tooltip, but it was asking for a non-existent key instead of reusing the existing
providers.deletestring that already matches the intended UI text.Why This Fix
Adding a new
deleteConnectionkey to every locale would only duplicate an existing concept.The tooltip is just the delete action label, so the smallest correct fix is to reuse
providers.deleteat the call site.Proof
I verified the bug directly on unpatched
origin/main:src/app/(dashboard)/dashboard/providers/[id]/page.tsxrequestst("deleteConnection")src/i18n/messages/en.jsoncontainsproviders.deleteandproviders.deleteConnectionConfirm, but notproviders.deleteConnection/dashboard/providers/codexon unpatchedorigin/mainreproduced the exact runtime error:MISSING_MESSAGE: providers.deleteConnectionI also verified the patched branch:
title="Delete"MISSING_MESSAGE: providers.deleteConnectionerror no longer appears in a fresh browser sessionVerification
PORT=20131 npm run buildproviders.deletemessageMISSING_MESSAGE: providers.deleteConnectionerror reproduces on unpatchedorigin/mainand disappears with this patch