[oyi77]

Description

This PR extracts several large logical phases out of open-sse/handlers/chatCore.ts and places them into smaller, self-contained modules under open-sse/handlers/chatCore/.

Extracted phases:

• Phase 9.1: Semantic cache check
• Phase 9.2: Idempotency check
• Phase: Memory & Skills injection
• Phase: Sanitization logic

This reduces the length of handleChatCore and helps prepare the codebase for the upcoming WordPress-style Plugin System by enforcing modularity.

Ref: #3594

[gemini-code-assist]

Code Review

This pull request refactors handleChatCore in open-sse/handlers/chatCore.ts by modularizing its logic into separate files under open-sse/handlers/chatCore/ (covering idempotency, semantic caching, request sanitization, and memory/skills injection). Feedback on these changes highlights the need to add unit tests for the newly created modular functions to comply with the repository's style guide (Rule 9), and to replace the use of any types with proper type definitions in the new modules to ensure type safety.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

The Repository Style Guide (Rule 9) requires that tests be included when changing production code. Please add unit tests for the new modular functions in open-sse/handlers/chatCore/.

References

1. Rule 9: Always include tests when changing production code (src/, open-sse/, electron/, bin/).

[gemini-code-assist]

Avoid using any for type definitions. Please define proper interfaces or types for clientRawRequest, effectiveServiceTier, and log to improve type safety and maintainability.

[diegosouzapw]

Merged into release/v3.8.21 — thanks, @oyi77! 🎉

The focused chatCore modularization is a clean win — extracting the idempotency check, semantic cache check, request sanitization, and memory/skills injection into open-sse/handlers/chatCore/ makes that monster handler much more navigable.

One fix was applied on top (co-authored): the idempotency check (and its local idempotencyKey declaration) moved into checkIdempotencyCache(), but the Phase 9.2 save call still referenced idempotencyKey, which threw ReferenceError at runtime on every successful non-cached response (caught by chatcore-translation-paths — note that typecheck:core doesn't cover this file, so the suite was the safety net). Re-derived the key at the save site via the pure getIdempotencyKey(headers). Verified the chatCore idempotency/sanitization/cache tests pass. Thanks for pushing the modularization forward!