Skip to content

fix(misc): DeepSeek regex, ProviderProfile export, binary guard #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Jun 4, 2026
Merged

fix(misc): DeepSeek regex, ProviderProfile export, binary guard #3177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion open-sse/services/accountFallback.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import {
import { classify429FromError, type FailureKind } from "../../src/shared/utils/classify429";
import { resolveUseUpstream429BreakerHints } from "../../src/shared/utils/providerHints";

type ProviderProfile = {
export type ProviderProfile = {
baseCooldownMs: number;
useUpstreamRetryHints: boolean;
/** Issue #2100 follow-up. Stored override; undefined → per-provider default. */
Expand Down
3 changes: 2 additions & 1 deletion open-sse/services/reasoningCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ const REASONING_REPLAY_MODEL_PATTERNS = [
/deepseek-r1/i,
/deepseek-reasoner/i,
/deepseek-chat/i,
/deepseek[-/]v4[-.](flash|pro)/i,
/deepseek[-/]v4[-.](flash|pro)(-free)?/i,
/zen\/deepseek-v4/i,
Comment on lines +48 to +49

@gemini-code-assist gemini-code-assist Bot Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The regex DEEPSEEK_V4_MODEL_PATTERN on line 59 also needs to be updated to match these new -free and zen/ variants. Currently, it is defined as /deepseek[-/]v4[-.](flash|pro)/i, which means isDeepSeekReasoningModel will return false for these new variants.

/kimi-k2/i,
/qwq/i,
/qwen.*think/i,
Expand Down
1 change: 1 addition & 0 deletions src/lib/versionManager/binaryManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ export async function getInstalledVersions(dataDir?: string): Promise<string[]>
return entries
.filter(
(e) =>
typeof e === "string" &&
e.startsWith("cliproxyapi-") &&
fsSync.statSync(path.join(/* turbopackIgnore: true */ binDir, e)).isDirectory()
)
Comment on lines 163 to 168

@gemini-code-assist gemini-code-assist Bot Jun 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If fsSync.statSync throws an error (for example, due to a broken symlink, permission issue, or if a file is deleted during execution), the entire getInstalledVersions function will fail and return []. Wrapping the statSync call in a try-catch block makes the filter robust against individual file errors.

      .filter((e) => {
        if (typeof e !== "string" || !e.startsWith("cliproxyapi-")) {
          return false;
        }
        try {
          return fsSync.statSync(path.join(/* turbopackIgnore: true */ binDir, e)).isDirectory();
        } catch {
          return false;
        }
      })

Expand Down