[JxnLexn]

Summary

• Adds a new Settings → AI control for OpenAI Responses previous_response_id handling.
• Supports Auto, Strip, and Preserve.
• Defaults to Auto, which strips previous_response_id for stateless Responses upstreams unless the connection explicitly enables OpenAI Responses storage via openaiStoreEnabled.
• Prevents VS Code Custom Endpoint / Codex second-turn failures caused by upstream Unsupported parameter: previous_response_id.
• Adds only a small UI hint for the behavior; no recurring runtime strip warnings.
• Hardens the upstream-start-timeout test so it waits for the fully prepared pending provider payload before asserting request details.

Related Issues

• Related to VS Code Custom Endpoint compatibility with Responses API state handling

Validation

• npm run lint
• npm run test:unit
• npm run test:coverage
• Coverage is still >= 60% for statements, lines, functions, and branches
• SonarQube PR analysis is green or any remaining issues are explicitly documented below

Additional validation performed:

• node --import tsx/esm --test tests/unit/responses-state-policy.test.ts
• node --import tsx/esm --test tests/unit/responses-handler.test.ts
• node --import tsx/esm --test tests/unit/settings-api.test.ts
• node --import tsx/esm --test tests/integration/chat-pipeline.test.ts
• node --import tsx/esm --test --test-name-pattern "chatCore times out upstream execution before provider response headers" tests/unit/chatcore-translation-paths.test.ts
• node --import tsx/esm --test tests/unit/chatcore-translation-paths.test.ts
• Targeted npx eslint on changed source/test files
• npx eslint tests/unit/chatcore-translation-paths.test.ts

Note: npm run typecheck:core was attempted but currently fails on an existing unrelated missing optional dependency: @huggingface/transformers in src/lib/memory/embedding/transformersLocal.ts.

Tests Added Or Updated

• Added tests/unit/responses-state-policy.test.ts
• Updated tests/integration/chat-pipeline.test.ts
• Updated tests/unit/responses-handler.test.ts
• Updated tests/unit/settings-api.test.ts
• Updated tests/unit/chatcore-translation-paths.test.ts

Coverage Notes

• The new policy helper is covered directly by tests/unit/responses-state-policy.test.ts.
• The Responses handler default-strip behavior is covered by tests/unit/responses-handler.test.ts.
• The persisted setting and PATCH flow are covered by tests/unit/settings-api.test.ts.
• The end-to-end Codex Responses pipeline behavior is covered by tests/integration/chat-pipeline.test.ts, including default stateless strip and explicit preserve mode.
• The pending provider payload / upstream-start-timeout behavior is covered by tests/unit/chatcore-translation-paths.test.ts.

Reviewer Notes

• The default Auto mode is intentionally conservative: it avoids sending previous_response_id unless the upstream connection explicitly opts into Responses storage.
• Preserve remains available for stateful upstreams or operators who knowingly want provider-side response state.
• Strip is safest for stateless clients such as VS Code Custom Endpoint when the client sends full conversation history.
• No DB migration is required; the setting is stored in the existing settings key-value store with a default.

[gemini-code-assist]

Code Review

This pull request introduces a policy for handling previous_response_id in chat responses, allowing users to configure whether to automatically strip, preserve, or let OmniRoute decide based on connection settings. It adds the backend logic, database settings, a new settings tab in the dashboard UI, and corresponding integration and unit tests. The review feedback suggests using useRef in the ResponsesStatePolicyTab component to manage the status timeout, which prevents potential race conditions and memory leaks when the component unmounts or settings are changed rapidly.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

Manage the status timeout using a useRef to prevent race conditions (e.g., if the user changes the setting multiple times in quick succession) and to clean up the timeout when the component unmounts.

export default function ResponsesStatePolicyTab() {
  const [mode, setMode] = useState<ResponsesPreviousResponseIdMode>(
    DEFAULT_RESPONSES_PREVIOUS_RESPONSE_ID_MODE
  );
  const [loading, setLoading] = useState(true);
  const [saving, setSaving] = useState(false);
  const [status, setStatus] = useState<"" | "saved" | "error">("");
  const t = useTranslations("settings");
  const timeoutRef = useRef<NodeJS.Timeout | null>(null);

  useEffect(() => {
    let cancelled = false;
    fetch("/api/settings")
      .then((res) => res.json())
      .then((data) => {
        if (cancelled) return;
        setMode(normalizeMode(data?.responsesPreviousResponseIdMode));
        setLoading(false);
      })
      .catch(() => {
        if (!cancelled) setLoading(false);
      });
    return () => {
      cancelled = true;
      if (timeoutRef.current) {
        clearTimeout(timeoutRef.current);
      }
    };
  }, []);

  const save = async (nextMode: ResponsesPreviousResponseIdMode) => {
    if (saving || loading || nextMode === mode) return;
    const previousMode = mode;
    setMode(nextMode);
    setSaving(true);
    setStatus("");
    if (timeoutRef.current) {
      clearTimeout(timeoutRef.current);
    }

    try {
      const res = await fetch("/api/settings", {
        method: "PATCH",
        headers: { "Content-Type": "application/json" },
        body: JSON.stringify({ responsesPreviousResponseIdMode: nextMode }),
      });
      if (!res.ok) {
        setMode(previousMode);
        setStatus("error");
        return;
      }
      setStatus("saved");
      timeoutRef.current = setTimeout(() => setStatus(""), 2000);
    } catch {
      setMode(previousMode);
      setStatus("error");
    } finally {
      setSaving(false);
    }
  };

[kilo-code-bot]

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
src/app/(dashboard)/dashboard/settings/components/ResponsesStatePolicyTab.tsx	4	Unused import useRef - imported but never referenced in component

Explanation: The useRef import from React is included but never used in the ResponsesStatePolicyTab component. This appears to be leftover code or unnecessary import that adds to bundle size and could confuse developers. Should be removed.

Other Observations (not in diff)

No issues found in unchanged code.

Files Reviewed (10 files)

• open-sse/handlers/chatCore.ts - 0 issues
• open-sse/utils/responsesStatePolicy.ts - 0 issues
• src/shared/constants/responsesPreviousResponseId.ts - 0 issues
• src/app/(dashboard)/dashboard/settings/ai/page.tsx - 0 issues
• src/app/(dashboard)/dashboard/settings/components/ResponsesStatePolicyTab.tsx - 1 issue
• src/i18n/messages/de.json - 0 issues
• src/i18n/messages/en.json - 0 issues
• src/lib/db/settings.ts - 0 issues
• src/shared/validation/settingsSchemas.ts - 0 issues
• tests/*.test.ts - 0 issues

---

_{Reviewed by laguna-m.1-20260312:free · 988,005 tokens}

[kilo-code-bot]

WARNING: Unused import useRef - imported from React but never referenced in this component. Unused imports increase bundle size and can confuse developers. Should remove.

[diegosouzapw]

Thanks @JxnLexn! This is a clean, well-tested fix — stripping previous_response_id for stateless Responses upstreams (with the auto/strip/preserve setting + UI + i18n) resolves the broken-context problem on stateless clients like the VS Code Custom Endpoint. Excellent test coverage (unit + integration). Merging into release/v3.8.10. 🙏

[ivan-mezentsev]

@JxnLexn This is garbage. You must revert this immediately, because in VSCode previous_response_id is disabled by the "zeroDataRetentionEnabled": true setting in models - this is in the wizard /dashboard/cli-tools and in the Copilot documentation