Repository navigation
feat(kiro): add Claude Opus 4.8 to the Kiro model catalog - #3131
Conversation
Kiro (AWS CodeWhisperer) tops out at Claude Opus 4.7 in the registry, but the latest Opus 4.8 is already served by the Claude Code provider and Kiro's executor passes the model id through to CodeWhisperer verbatim. Expose claude-opus-4.8 on the kiro provider so clients can select it via kiro/claude-opus-4.8. - providerRegistry: add claude-opus-4.8 (1M context, 128k output) above 4.7 - pricing: add claude-opus-4.8 (and the previously-missing 4.7) to the kiro pricing block at Kiro's standard Opus rate so usage cost is non-zero - tests: assert kiro exposes claude-opus-4.8 with matching context/output + pricing
There was a problem hiding this comment.
Code Review
This pull request adds the claude-opus-4.8 model to the Kiro provider registry, configures pricing for both claude-opus-4.8 and claude-opus-4.7, and adds a unit test to verify their presence and pricing. The review feedback suggests adding an alias mapping for claude-opus-4-8 to ensure backward compatibility and proper resolution, and expanding the unit test to assert the pricing configuration for claude-opus-4.7 to prevent future regressions.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| id: "claude-opus-4.8", | ||
| name: "Claude Opus 4.8", | ||
| contextLength: 1000000, | ||
| maxOutputTokens: 128000, | ||
| }, |
There was a problem hiding this comment.
While adding claude-opus-4.8 to the Kiro model list is correct, please note that clients requesting the hyphenated version kiro/claude-opus-4-8 (consistent with the claude provider's claude-opus-4-8 ID) will fail to resolve to the dotted claude-opus-4.8 ID.\n\nTo ensure proper resolution and backward compatibility, you must also add the alias mapping to PROVIDER_MODEL_ALIASES.kiro in open-sse/services/model.ts:\n\ntypescript\n"claude-opus-4-8": "claude-opus-4.8",\n\n\nThis matches how claude-opus-4-7 and claude-opus-4-6 are currently mapped.
| // Pricing for the Kiro channel must cover the new model so usage cost is non-zero. | ||
| const kiroPricing = (DEFAULT_PRICING as Record<string, Record<string, unknown>>).kiro; | ||
| assert.ok(kiroPricing["claude-opus-4.8"], "kiro pricing must include claude-opus-4.8"); |
There was a problem hiding this comment.
Since this PR also adds the previously-missing claude-opus-4.7 pricing entry to prevent $0 usage costs, it would be highly beneficial to assert its presence in the test suite as well to prevent future regressions.
| // Pricing for the Kiro channel must cover the new model so usage cost is non-zero. | |
| const kiroPricing = (DEFAULT_PRICING as Record<string, Record<string, unknown>>).kiro; | |
| assert.ok(kiroPricing["claude-opus-4.8"], "kiro pricing must include claude-opus-4.8"); | |
| // Pricing for the Kiro channel must cover the new models so usage cost is non-zero.\n const kiroPricing = (DEFAULT_PRICING as Record<string, Record<string, unknown>>).kiro;\n assert.ok(kiroPricing["claude-opus-4.8"], "kiro pricing must include claude-opus-4.8");\n assert.ok(kiroPricing["claude-opus-4.7"], "kiro pricing must include claude-opus-4.7"); |
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (3 files)
Note: A previous review by gemini-code-assist already identified the missing Fix these issues in Kilo Cloud Reviewed by laguna-m.1-20260312:free · 2,878,921 tokens |
…ic-asset build fix - #3131 Kiro Opus 4.8 catalog (thanks @artickc) - #3132 Kimi thinking-mode reasoning_content fix (thanks @bypanghu) - #3130 connectionId fallback + kilo call logging (thanks @androw) - build: standalone static-asset path fix (white login screen after build-output reorg) - contributors hall: +@artickc +@bypanghu +@androw (15 total)
…ference#3131) Kiro (AWS CodeWhisperer) tops out at Claude Opus 4.7 in the registry, but the latest Opus 4.8 is already served by the Claude Code provider and Kiro's executor passes the model id through to CodeWhisperer verbatim. Expose claude-opus-4.8 on the kiro provider so clients can select it via kiro/claude-opus-4.8. - providerRegistry: add claude-opus-4.8 (1M context, 128k output) above 4.7 - pricing: add claude-opus-4.8 (and the previously-missing 4.7) to the kiro pricing block at Kiro's standard Opus rate so usage cost is non-zero - tests: assert kiro exposes claude-opus-4.8 with matching context/output + pricing
…eaper-inference#3131/cheaper-inference#3132) + static-asset build fix - cheaper-inference#3131 Kiro Opus 4.8 catalog (thanks @artickc) - cheaper-inference#3132 Kimi thinking-mode reasoning_content fix (thanks @bypanghu) - cheaper-inference#3130 connectionId fallback + kilo call logging (thanks @androw) - build: standalone static-asset path fix (white login screen after build-output reorg) - contributors hall: +@artickc +@bypanghu +@androw (15 total)
…ference#3131) Kiro (AWS CodeWhisperer) tops out at Claude Opus 4.7 in the registry, but the latest Opus 4.8 is already served by the Claude Code provider and Kiro's executor passes the model id through to CodeWhisperer verbatim. Expose claude-opus-4.8 on the kiro provider so clients can select it via kiro/claude-opus-4.8. - providerRegistry: add claude-opus-4.8 (1M context, 128k output) above 4.7 - pricing: add claude-opus-4.8 (and the previously-missing 4.7) to the kiro pricing block at Kiro's standard Opus rate so usage cost is non-zero - tests: assert kiro exposes claude-opus-4.8 with matching context/output + pricing
…eaper-inference#3131/cheaper-inference#3132) + static-asset build fix - cheaper-inference#3131 Kiro Opus 4.8 catalog (thanks @artickc) - cheaper-inference#3132 Kimi thinking-mode reasoning_content fix (thanks @bypanghu) - cheaper-inference#3130 connectionId fallback + kilo call logging (thanks @androw) - build: standalone static-asset path fix (white login screen after build-output reorg) - contributors hall: +@artickc +@bypanghu +@androw (15 total)
…ference#3131) Kiro (AWS CodeWhisperer) tops out at Claude Opus 4.7 in the registry, but the latest Opus 4.8 is already served by the Claude Code provider and Kiro's executor passes the model id through to CodeWhisperer verbatim. Expose claude-opus-4.8 on the kiro provider so clients can select it via kiro/claude-opus-4.8. - providerRegistry: add claude-opus-4.8 (1M context, 128k output) above 4.7 - pricing: add claude-opus-4.8 (and the previously-missing 4.7) to the kiro pricing block at Kiro's standard Opus rate so usage cost is non-zero - tests: assert kiro exposes claude-opus-4.8 with matching context/output + pricing
…eaper-inference#3131/cheaper-inference#3132) + static-asset build fix - cheaper-inference#3131 Kiro Opus 4.8 catalog (thanks @artickc) - cheaper-inference#3132 Kimi thinking-mode reasoning_content fix (thanks @bypanghu) - cheaper-inference#3130 connectionId fallback + kilo call logging (thanks @androw) - build: standalone static-asset path fix (white login screen after build-output reorg) - contributors hall: +@artickc +@bypanghu +@androw (15 total)
Summary
Kiro (AWS CodeWhisperer) currently tops out at Claude Opus 4.7 in the provider registry, even though:
claude(Claude Code) provider, andopenai-to-kirotranslator passes the requested model id straight through to CodeWhisperer (userInputMessage.modelId), so no special model mapping is required for a new Claude model.This PR exposes
claude-opus-4.8on thekiroprovider so clients can select it viakiro/claude-opus-4.8(andkr/claude-opus-4.8), consistent with howclaude-opus-4.7is already wired.Changes
open-sse/config/providerRegistry.ts— addclaude-opus-4.8to thekiromodels list (1M context, 128k max output), placed aboveclaude-opus-4.7.src/shared/constants/pricing.ts— addclaude-opus-4.8to thekiropricing block at Kiro's standard Opus rate ($15 / $75per 1M, matching the existingclaude-opus-4.6Kiro entry). Also adds the previously-missingclaude-opus-4.7entry to the same block so its usage cost is no longer$0.tests/unit/catalog-updates-v3x.test.ts— new assertion that the Kiro catalog exposesclaude-opus-4.8(with the expected context/output) and that the Kiro pricing block covers it.Why the pricing rate
The new Kiro entries follow the rate already used by the existing
kiro→claude-opus-4.6entry ($15/$75), keeping the Kiro channel internally consistent. Adjust if Kiro should mirror the Claude Code (cc) Opus rate instead.Testing
All tests pass, including the new
Kiro catalog exposes Claude Opus 4.8 alongside 4.7 with matching pricingcase.