[diegosouzapw]

Problem (release-blocker)

handleChatCore (open-sse/handlers/chatCore.ts) declared const settings = cachedSettings ?? (await getCachedSettings()) twice in the same function scope — the consolidated "fetch once, reuse" const (~line 1921) plus a duplicate (~line 2154) added alongside the per-key stream-default-mode feature (commit 99d673fe5).

esbuild/tsx rejects the same-scope redeclaration:

chatCore.ts:2154:8: ERROR: The symbol "settings" has already been declared

This turned every unit test that imports chatCore red (e.g. system-role-extraction, claude-passthrough-thinking-2454) and breaks the production build (a duplicate block-scoped const is a hard JS error).

Same commit (99d673fe5) that introduced the migration-077 collision fixed in #2966.

Fix

Remove the duplicate declaration; reuse the earlier consolidated settings.

Verification

• chatcore-imports-cleanly (new import guard): 1/1
• system-role-extraction: 10/10 (was red — TransformError)
• claude-passthrough-thinking-2454: 4/4 (was red)
• typecheck:core: no settings redeclare error; lint clean.

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request resolves a duplicate const settings declaration in open-sse/handlers/chatCore.ts that was causing build and test failures, and adds a regression test to prevent future occurrences. Feedback on these changes suggests removing the verbose comment documenting the bug in the source code, and refactoring the new test file to use vitest instead of Node's native test runner to align with the repository's testing framework.

[gemini-code-assist]

The project uses Vitest as its primary test runner (as indicated by the presence of vitest.config.ts in the repository configuration). For consistency across the test suite and proper integration with Vitest's test runner, reporters, and coverage tools, please use vitest instead of the Node.js native node:test and node:assert modules.

import { test, expect } from "vitest";

test("chatCore.ts imports without a duplicate-declaration transform error", async () => {
  const mod = await import("../../open-sse/handlers/chatCore.ts");
  expect(typeof mod.handleChatCore).toBe("function");
});

References

1. Rule 1 of the Repository Style Guide mentions vitest.config.ts as a standard configuration file and refers to test files as 'Vitest files', indicating Vitest is the standard testing framework for the repository. ^(link)

[gemini-code-assist]

Avoid committing verbose comments that document past bugs, git history, or PR context directly in the source code. This information is already captured in the git history and PR description, and keeping it in the code adds unnecessary noise and can quickly become outdated. The code is self-explanatory without this comment.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge (already merged)

Files Reviewed (3 files)

• CHANGELOG.md - Change logged
• open-sse/handlers/chatCore.ts - Duplicate const settings removed
• tests/unit/chatcore-imports-cleanly.test.ts - Regression guard added

---

_{Reviewed by step-3.7-flash-20260528 · 363,616 tokens}