[diegosouzapw]

Summary

Implementa o plano 14 (_tasks/features-v3.8.6/refactorpages/14-cli-pages-redesign.plan.md):

• 3 páginas redesenhadas com smart status cards (Conceito B) substituindo /dashboard/cli-tools:
  • /dashboard/cli-code (19 CLIs de coding apontando para o Omni)
  • /dashboard/cli-agents (6 agentes autônomos CLI apontando para o Omni)
  • /dashboard/acp-agents (CLIs spawnadas pelo Omni via stdio — renomeada de /dashboard/agents)
• Catálogo unificado em src/shared/constants/cliTools.ts (29 entries) com campos category/vendor/acpSpawnable/baseUrlSupport validados via Zod (src/shared/schemas/cliCatalog.ts); 9 entries novas (roo, jcode, deepseek-tui, smelt, pi, agent-deck, goose, interpreter, warp, etc.); 4 backlog MITM (windsurf, amp, amazon-q, cowork) registradas em _orchestration/_plan11-mitm-backlog.md.
• Concept + Comparison cards (src/shared/components/cli/CliConceptCard.tsx, CliComparisonCard.tsx) replicados nas 3 páginas — eliminando confusão consumo vs execução reversa.
• Detecção batch via /api/cli-tools/all-statuses (cache mtime + timeout 5s/tool); endpoint DRY com /status/route.ts via src/lib/cliTools/checkToolConfigStatus.ts.
• Detail pages /[id] reusando cards especializados existentes (*ToolCard.tsx movidos com git mv para src/app/(dashboard)/dashboard/cli-code/components/); orquestrador ToolDetailClient.tsx despacha por toolId.
• 308 redirects em next.config.mjs: cli-tools → cli-code, agents → acp-agents (+ :path* para deep links).
• Sidebar (sidebarVisibility.ts) reordenada: cli-code → cli-agents → acp-agents → cloud-agents; presets atualizados.
• i18n PT-BR + EN completos (4 novos namespaces: cliCommon, cliCode, cliAgents, acpAgents — ~140 chaves cada locale); 39 outros locales caem em fallback EN via novo namespace-level merge em src/i18n/request.ts.
• Settings handlers para 5 CLIs novas com configType: "custom" (forge, jcode, deepseek-tui, smelt, pi).

Frentes (10 onda-paralelas + 1 chore + 1 audit)

Onda	Frente	Commit	Resumo
1	F1	193bf1a76	Catalog + Zod schema + 9 entries novas + 2 removidas
2	F2	c1952db4c	/api/cli-tools/all-statuses + cache mtime + DRY refactor
2	F3	3a711d1c0	5 settings handlers (forge/jcode/deepseek-tui/smelt/pi)
2	F4	1ca703657	7 shared UI components + useToolBatchStatuses hook
3	F5	4cf36ccdc	/dashboard/cli-code page (19 cards)
3	F6	371a7d8db	/dashboard/cli-agents page (6 cards)
3	F7	79797cd45	git mv agents → acp-agents + concept/comparison cards
3	F8	2d58519ca	Detail pages /[id] + move 15 *ToolCard.tsx
4	F9	649a2219f	i18n PT-BR+EN + sidebar + 4 redirects 308 + i18n fallback
—	chore	f41845afb	Coverage gate 75/75/75/70 → 40/40/40/40 (instrução do usuário)
5	F10	bb90dda1c	Audit GREEN (0 violations) + docs + 3 micro-fixes

Test plan

• npm run lint — 0 errors
• npm run typecheck:core — clean
• npm run typecheck:noimplicit:core — clean
• npm run check:cycles — 0 ciclos novos (215 files)
• npm run test:unit (subset CLI plan 14) — 217 tests, 0 fail
• npm run test:vitest — 98 UI tests, 0 fail
• npm run test:coverage — 56.7/66.2/50.6/56.7 — passa gate 40/40/40/40
• npm run build — Next.js 16.2.6 OK
• Catalog cardinality: 19 code visível + 6 agent (D15 do master plan)
• Hard Rules 1–17 — 0 violations (audit F10)
• Smoke browser manual: visitar /dashboard/cli-code, /cli-agents, /acp-agents, /cli-code/claude (detail), 308 redirects de URLs antigas, sidebar nova
• Restaurar coverage gate para 75/75/75/70 em issue separada pós-merge

Docs

• docs/reference/CLI-TOOLS.md atualizado.
• _tasks/features-v3.8.6/refactorpages/_orchestration/master-plan-14.md — plano de execução (orquestração).
• _tasks/features-v3.8.6/refactorpages/_orchestration/audit-report-14.md — auditoria F10 (GREEN).
• _tasks/features-v3.8.6/refactorpages/_orchestration/_plan11-mitm-backlog.md — cross-ref para plano 11.

Closes plan: _tasks/features-v3.8.6/refactorpages/14-cli-pages-redesign.plan.md

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[kilo-code-bot]

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

[gemini-code-assist]

Code Review

This pull request implements a major redesign of the CLI pages (Plan 14), restructuring the tools into distinct categories: CLI Code's, CLI Agents, and ACP Agents. It updates the unified catalog, introduces a batch status detection API, and adds several new tool integrations alongside extensive unit and integration tests. The code review feedback is highly accurate and identifies critical issues: a logic bug in CliAgentsPageClient that incorrectly checks tool installation instead of active provider status, a JSON parsing crash on Hermes' TOML-like configuration in extractEndpointFromConfig, a potential timer resource leak in Promise.race inside the status API, and a shallow merge issue in request.ts that would drop translated sidebar keys for non-English locales. All provided comments are highly actionable and should be kept.

[gemini-code-assist]

Import useEffect to fetch active providers from the API.

Suggested change

	import { useMemo, useState } from "react";
	import { useEffect, useMemo, useState } from "react";

[gemini-code-assist]

There is a logic bug here: hasActiveProviders is checking if any of the CLI tools are installed (s.detection.installed), rather than checking if there are active providers configured in the system. This causes the UI to incorrectly warn the user to connect a provider even if they have active providers but no CLI tools installed yet. Fetching the actual provider connections from /api/providers (matching the correct implementation in CliCodePageClient.tsx) resolves this.

  const [hasActiveProviders, setHasActiveProviders] = useState<boolean>(true);

  useEffect(() => {
    let cancelled = false;
    fetch("/api/providers")
      .then((res) => (res.ok ? res.json() : Promise.resolve({ connections: [] })))
      .then((data) => {
        if (cancelled) return;
        const active = (data.connections ?? []).filter((c: any) => c.isActive !== false);
        setHasActiveProviders(active.length > 0);
      })
      .catch(() => {
        if (!cancelled) setHasActiveProviders(false);
      });
    return () => {
      cancelled = true;
    };
  }, []);

[gemini-code-assist]

Hermes uses a TOML-like configuration format rather than JSON. Because JSON.parse(content) is executed on line 38 before the switch statement, any attempt to parse a Hermes configuration file will throw an error, causing extractEndpointFromConfig to always return null for Hermes. Moving the Hermes check up alongside Codex prevents this parsing error.

Suggested change

	// TOML-based tools (codex) — do a best-effort text search
	if (toolId === "codex") {
	const match = content.match(/base_url\s*=\s*["']([^"'\n]+)["']/i);
	return match ? match[1] : null;
	}
	const config = JSON.parse(content) as Record<string, unknown>;
	// TOML-based or text-based tools (codex, hermes) — do a best-effort text search
	if (toolId === "codex" || toolId === "hermes") {
	const match = content.match(/base_url\\s*=\\s*["']([^"'\\n]+)["']/i);
	return match ? match[1] : null;
	}
	const config = JSON.parse(content) as Record<string, unknown>;

[gemini-code-assist]

Since Hermes is now handled above before JSON parsing, this case block is redundant and can be safely removed.

[gemini-code-assist]

The setTimeout timer created inside Promise.race is never cleared if getCliRuntimeStatus resolves before the 5-second timeout. This leads to a timer resource leak on every status check request. Clearing the timeout in a finally block ensures resources are cleaned up immediately.

Suggested change

	const runtimePromise = Promise.race<Awaited<ReturnType<typeof getCliRuntimeStatus>>>([
	getCliRuntimeStatus(toolId),
	new Promise<never>((_, reject) =>
	setTimeout(() => reject(new Error("Timeout")), TOOL_CHECK_TIMEOUT_MS)
	),
	]);
	let timeoutId: NodeJS.Timeout | undefined;
	const runtimePromise = Promise.race<Awaited<ReturnType<typeof getCliRuntimeStatus>>>([
	getCliRuntimeStatus(toolId),
	new Promise<never>((_, reject) => {
	timeoutId = setTimeout(() => reject(new Error("Timeout")), TOOL_CHECK_TIMEOUT_MS);
	}),
	]).finally(() => {
	if (timeoutId) clearTimeout(timeoutId);
	});

[gemini-code-assist]

The shallow merge { ...enMessages, ...mergedMessages } works well for entirely new namespaces, but for existing namespaces that received new keys (such as sidebar), the target locale's sidebar object will completely overwrite the English sidebar object. This causes the newly added sidebar keys (cliCode, cliAgents, acpAgents, etc.) to be completely missing in the other 39 locales. Deep merging the sidebar object specifically ensures these fallback keys are preserved.

  let mergedMessages: Record<string, unknown> = messages as Record<string, unknown>;
  if (locale !== DEFAULT_LOCALE) {
    const enMessages = (
      await import(`./messages/${DEFAULT_LOCALE}.json`)
    ).default as Record<string, unknown>;
    mergedMessages = {
      ...enMessages,
      ...mergedMessages,
      sidebar: {
        ...(enMessages.sidebar as Record<string, unknown>),
        ...(mergedMessages.sidebar as Record<string, unknown> || {}),
      },
    };
  }

[diegosouzapw]

🛠️ Code review v2 fixes aplicados (commit 77b055aba)

Segundo pass de revisão identificou gaps mínimos que o F10 audit não capturou (rodou apenas subset curado de testes do plan 14):

Críticos (HIGH)

• tests/unit/custom-cli-config.test.ts quebrado — ERR_MODULE_NOT_FOUND no path cli-tools/components/customCliConfig.ts (F8 fez git mv para cli-code/components/ mas não atualizou esse import). Fix: import path corrigido. Validado: 3/3 PASS (era 0/1 FAIL).

Cosméticos (LOW)

• tests/unit/ui/CliAgentsPage.test.tsx — vi.mock path stale → atualizado para cli-code/components/CliStatusBadge.
• tests/unit/ui/CliToolCard.test.tsx — 3 URL strings /dashboard/cli-tools/claude → /dashboard/cli-code/claude.
• ToolDetailClient.tsx — removido case "cliproxyapi" + import (dead code, sem entry no catálogo).
• CliAgentsPageClient.tsx — substituído skeleton inline <div animate-pulse> por <CardSkeleton /> compartilhado (consistência com CliCodePageClient).
• 5 settings handlers — 8 instâncias de catch (err: any) → catch (err) + (err as NodeJS.ErrnoException).code narrowing (reduz de 11 para 3 : any no plan 14, sendo os 3 restantes documentados pelo F8 como intencionais por cards legacy sem tipos formais).

Gaps remanescentes (não fixados — exigiriam refactor maior ou são decisões documentadas)

#	Status	Razão
1	OPEN	F4 selects (BaseUrlSelect/ApiKeySelect/ManualConfigModal) criados mas não integrados — exigiria refatorar 12 *ToolCard.tsx
2	OPEN	Schema detection field não implementado — master plan D3 explícito ("backward compat")
3	OPEN	hermes vs hermes-agent — F1 decisão documentada (renomear quebraria i18n)
5	DOCUMENTED	Coverage gate 75→40 — instrução explícita do usuário
6	OPEN	_tasks/ docs untracked — design intent (orquestração interna)
7	OPEN	i18n keys leaner — YAGNI
8	OPEN	E2E redirects spec deferida — smoke manual recomendado

Validação

• node --import tsx/esm --test tests/unit/custom-cli-config.test.ts → 3/3 PASS
• F1/F3 catalog + handlers: 147/147 PASS
• UI tests (CliToolCard, CliAgentsPage, ToolDetailClient): 25/25 PASS
• typecheck:core + typecheck:noimplicit:core: clean
• Focused ESLint nos arquivos editados: 0 errors

[kilo-code-bot]

Test comment on existing file