Repository navigation
Release v3.8.4 - #2678
Merged
Merged
Release v3.8.4#2678
Conversation
…ce and features (#2676) Integrated into release/v3.8.4
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the Google Gemini integration by adding support for Gemini 2.0 models, implementing backoff and retry logic in the Gemini CLI executor, and introducing Google Search grounding (citations) and reasoning/thinking configurations. It also adds the vertex-partner provider, updates internal CLI versions, and includes a new PR submission guide. Feedback focuses on ensuring retry sleep intervals respect the abort signal, resolving variable shadowing in the response translator, and maintaining a consistent timestamp across streaming response chunks.
| "RETRY", | ||
| `Gemini CLI 429 retry ${retryAttemptsByUrl[urlIndex]} after ${backoffMs}ms` | ||
| ); | ||
| await sleep(backoffMs); |
Contributor
There was a problem hiding this comment.
The sleep call is not interrupted if the request is aborted via the signal. For long backoff periods, this can cause the execution context to hang unnecessarily. It is recommended to check the signal.aborted status immediately after the sleep.
Suggested change
| await sleep(backoffMs); | |
| await sleep(backoffMs); | |
| if (signal?.aborted) throw new Error("Aborted"); |
Comment on lines
+250
to
+257
| for (const chunk of chunks) { | ||
| if (chunk.web) { | ||
| citations.push({ | ||
| title: chunk.web.title, | ||
| url: chunk.web.uri, | ||
| }); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
The loop variable chunk shadows the function parameter chunk defined at line 241. This makes the code harder to maintain and can lead to subtle bugs if the original chunk data needs to be accessed within this block.
Suggested change
| for (const chunk of chunks) { | |
| if (chunk.web) { | |
| citations.push({ | |
| title: chunk.web.title, | |
| url: chunk.web.uri, | |
| }); | |
| } | |
| } | |
| for (const groundingChunk of chunks) { | |
| if (groundingChunk.web) { | |
| citations.push({ | |
| title: groundingChunk.web.title, | |
| url: groundingChunk.web.uri, | |
| }); | |
| } | |
| } |
| results.push({ | ||
| id: `chatcmpl-${state.messageId}`, | ||
| object: "chat.completion.chunk", | ||
| created: Math.floor(Date.now() / 1000), |
Contributor
There was a problem hiding this comment.
In streaming responses, the created timestamp should ideally remain constant across all chunks of the same request. Calling Date.now() for every chunk may result in slightly different timestamps being sent to the client. Consider initializing a timestamp in the state object at the start of the stream and reusing it here.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a4905edbe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+375
to
+383
| async execute({ | ||
| model, | ||
| body, | ||
| stream, | ||
| credentials, | ||
| signal, | ||
| log, | ||
| upstreamExtraHeaders, | ||
| }: ExecuteInput) { |
There was a problem hiding this comment.
This override bypasses BaseExecutor.execute() and never runs the needsRefresh()/refreshCredentials() flow before sending requests, even though this executor still defines refreshCredentials. For Gemini CLI OAuth connections with expired/near-expiry access tokens, requests now go straight to upstream with stale credentials and fail with 401s instead of being refreshed and retried, which is a regression for long-lived sessions.
Useful? React with 👍 / 👎.
Comment on lines
+433
to
+444
| if ((!retryMs || retryMs <= 60000) && retryAttemptsByUrl[urlIndex] < MAX_AUTO_RETRIES) { | ||
| retryAttemptsByUrl[urlIndex]++; | ||
| const backoffMs = | ||
| retryMs || Math.min(1000 * 2 ** retryAttemptsByUrl[urlIndex], 30000); | ||
| log?.debug?.( | ||
| "RETRY", | ||
| `Gemini CLI 429 retry ${retryAttemptsByUrl[urlIndex]} after ${backoffMs}ms` | ||
| ); | ||
| await sleep(backoffMs); | ||
| urlIndex--; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
The new retry block always performs intra-URL backoff retries on 429/503 and never checks skipUpstreamRetry from ExecuteInput. In combo/failover flows that explicitly set skipUpstreamRetry to fail over immediately, this now adds extra sleeps and retries on the same target, increasing latency and delaying fallback under rate-limit pressure.
Useful? React with 👍 / 👎.
Comment on lines
+3104
to
+3105
| { id: "claude-opus-4-7", name: "Claude Opus 4.7" }, | ||
| { id: "claude-sonnet-4-6", name: "Claude Sonnet 4.6" }, |
There was a problem hiding this comment.
These new vertex-partner model IDs (claude-opus-4-7, claude-sonnet-4-6) are not matched by VertexExecutor's isPartnerModel prefix list (which only includes claude-3-*), so they will be sent to the Gemini publisher URL instead of the partner OpenAPI chat endpoint. That makes the newly added models fail at runtime (typically 404/invalid route) when selected.
Useful? React with 👍 / 👎.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
…o mapping When a model-combo mapping routes a vision-capable model through a combo where some targets may NOT support vision, the vision bridge must process images so combo targets can describe them. Before: if body.model supports vision, the vision bridge skipped image processing entirely. Non-vision combo targets would receive raw images they can't handle. After: before skipping, check if the model has a model-combo mapping. If it does, process images through the vision bridge regardless of body.model's native vision support. - Add checkModelHasComboMapping() helper (dynamic import, failsafe) - Add checkModelHasComboMapping dep to VisionBridgeDependencies (testable) - Guardrail preCall: check combo mapping before early-return on vision support - Add VB-S11 / VB-S11b tests
…native vision Optimization per code review: instead of always processing images when a combo mapping exists, resolve the combo targets and check each target model's native vision support. Only invoke the vision bridge when at least one target model does not support vision. - Replace checkModelHasComboMapping() with shouldProcessImagesForComboModel() - When combo has ComboRefStep targets, conservatively process images - When all targets are model steps with native vision, skip processing - On errors, process images (conservative fail-safe)
Root cause: recordSessionModelUsage was called BEFORE getLastSessionModel, so prevModel always matched the current modelStr — handoff summaries were never generated when auto-routing switched models. Fix: call getLastSessionModel first (captures actual previous model), generate handoff on mismatch, then record the new model for next time. Also: - ORDER BY id DESC in session_model_history query (deterministic vs used_at which has second-precision ties) - 30s per-model timeout for combo routing (default FETCH_TIMEOUT_MS is 600s, too long for combo fallback scenarios)
…l timeout" This reverts commit 69dc6d0.
Dockerfile was pinned to node:26.2.0-trixie-slim, which is outside the project's engines range (>=20.20.2 <21 || >=22.22.2 <23 || >=24 <25). keytar 7.9.0 / node-gyp could not compile against the Node 26 ABI, breaking every Docker build of v3.8.3 and leaving :latest stale. (cherry picked from commit f1d3591)
Prevents the v3.8.3 incident from recurring, where re-publishing old releases (v2.5.8/v2.6.4/v3.2.8/v3.3.3) clobbered both Docker Hub :latest and the npm latest dist-tag with the 3.2.8 build. docker-publish.yml: - release.types: published -> released (does not fire on edits) - new step computes promote_latest only when VERSION equals the highest semver tag in the repo; pre-release identifiers (-rc/alpha/beta/pre/ next) never claim :latest - push to main now tags :main only (never :latest) - skip-if-exists via docker manifest inspect avoids accidental rebuilds - workflow_dispatch input promote_latest is opt-in for back-fill builds - all github/inputs context moved into env: to remove script-injection risk flagged by semgrep npm-publish.yml: - release.types: published -> released - dist-tag resolved by semver compare: only the highest stable tag becomes latest; older releases fall back to a historic dist-tag - skip-if-already-published actually works now: dropped the --silent flag from npm view that suppressed stdout and broke the grep, which is why 3.2.8 re-published and stole @latest - npm publish always runs with explicit --tag (no implicit @latest promotion) - secrets/inputs moved into env: for the same injection hardening (cherry picked from commit dedeac4)
Integrated into release/v3.8.3 — comprehensive OAuth refresh race fix (Fix A-F via onPersist/AsyncLocalStorage + mutex consolidation). Replaces token-refresh-race.test.ts with broader token-refresh-race-comprehensive.test.ts that preserves the original invariant plus 11 new assertions. (cherry picked from commit ac76863)
…ppress shell window (#2714) Thanks @benzntech.
… guard The previous workflow declared 'permissions: administration: write' which is not a valid GITHUB_TOKEN scope and silently failed every run, leaving release/v3.8.3 unlocked. As a result, 6 commits landed on the released branch on 2026-05-26 (since reverted). Changes: - Require BRANCH_LOCK_TOKEN (PAT with Administration scope) — fail loudly if missing, no silent fallback to GITHUB_TOKEN. - Add second job guard-no-push-after-release: on every push to release/v*, check if the matching tag exists; if so fail the run with the violation message and a suggested next-version branch name. - Trigger now includes 'on: push: branches: release/v*' as defense in depth. Hard Rule #18 (proposed): branches release/vX.Y.Z whose tag vX.Y.Z exists are immutable. Hotfixes go on release/vX.Y.(Z+1).
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 684f396410
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+582
to
+586
| body: buildFormParams({ | ||
| grant_type: "refresh_token", | ||
| refresh_token: refreshToken, | ||
| client_id: clientId, | ||
| }), |
There was a problem hiding this comment.
The new refreshGitLabDuoToken request only sends grant_type, refresh_token, and client_id, but omits client_secret even when this instance is configured as a confidential app (the login exchange path explicitly supports clientSecret in src/lib/oauth/providers/gitlab-duo.ts). In deployments that require client authentication for refresh, this will make every GitLab Duo token refresh fail (typically invalid_client/refresh failure), forcing re-auth instead of rotating tokens.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be985474d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+13
to
+17
| export async function getOrInitSupervisor(): Promise<ServiceSupervisor> { | ||
| const existing = getSupervisor(TOOL); | ||
| if (existing) return existing; | ||
|
|
||
| const sup = new ServiceSupervisor({ |
There was a problem hiding this comment.
getOrInitSupervisor() has a race window where two requests can both observe no registered supervisor and each instantiate/register a different ServiceSupervisor; the second registration overwrites the first, leaving the first child process orphaned and outside lifecycle control. This can happen under concurrent /start//restart//status calls before bootstrap registration, and the same file already documents this exact hazard for 9router but does not apply the same in-flight guard here.
Useful? React with 👍 / 👎.
Comment on lines
+44
to
+45
| registerSupervisor(sup); | ||
| return sup; |
There was a problem hiding this comment.
This helper registers a new supervisor and returns immediately without wiring the stateChange hooks that bootstrap uses to run scheduleServiceModelSync() on running and markAllUnavailable() on stopped/error (src/lib/services/bootstrap.ts). When a supervisor is created through this on-demand path (including the rotate-key flow that unregisters then re-inits), model sync/availability maintenance is silently disabled, so cached 9router model state can become stale after service transitions.
Useful? React with 👍 / 👎.
CHANGELOG.md
Backfills entries for PRs that landed on release/v3.8.4 since the last
changelog edit:
- #2749 review hardening (SSRF guards etc.)
- #2747 mcp compliance→callLogs deadlock + Kiro refresh
- #2744 claude-web 'API Key' label
- #2742 deepseek-web lazy session refresh
- #2741 docker fumadocs build context
- #2740 vision-bridge for opencode-go/zen
- #2736 universal handoff default
And refreshes the Hall de Contribuidores list.
src/lib/oauth/constants/oauth.ts
Removes the duplicate \`export const TRAE_CONFIG = …\` block that had
been added later in the file by #2658, and folds its extra fields
(\`chatEndpoint\`, \`webUrl\`, \`tokenNote\`) into the original
declaration. Two top-level exports with the same name compile under
TypeScript's name resolution rules but only the second wins at
runtime — the merged single declaration removes the foot-gun.
There was a problem hiding this comment.
💡 Codex Review
https://github.com/diegosouzapw/OmniRoute/blob/bcc2427f62cc7029773e572d4478b0cabd1b0ce7/src/server/ws/liveServer.ts#L109
authorizeConnection calls extractApiKey with { headers: { authorization: ... } }, but extractApiKey reads request.headers.get(...) (src/sse/services/auth.ts), so this throws at runtime and falls into the catch path that returns Auth system unavailable. When live WS is enabled, valid clients are denied during authorization instead of connecting.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+27
to
+30
| const { version } = validation.data; | ||
|
|
||
| try { | ||
| const { tool, version } = validation.data; | ||
| const result = await installTool(tool, version || undefined); | ||
| const result: InstallResult = await install(version || "latest"); |
There was a problem hiding this comment.
This handler validates versionManagerInstallSchema (which includes tool) but then discards tool and always runs the CLIProxy installer. Calls like POST /api/version-manager/install with tool: "9router" will incorrectly install CLIProxy and still return success, which breaks legacy clients/automation that rely on the tool parameter.
Useful? React with 👍 / 👎.
….8.5 Squashes multiple in-flight changes pending release into release/v3.8.4 since the in-progress 3.8.5 has been consolidated back into 3.8.4. CRITICAL — oauth/codex (multi-account regression revert) Revert the proactive expired-flip that #2743 (multi-agent review) added to open-sse/executors/base.ts. The new behaviour marked accounts as testStatus:"expired" + isActive:false from inside the PROACTIVE refresh path whenever isUnrecoverableRefreshError() fired — including transient sentinels (refresh_token_reused that the rotation map can recover, generic invalid_request blips). On multi-account Codex it sequentially disabled working accounts in the DB before any upstream call confirmed the failure. Keep the classification — that part is legitimate (avoids spreading the sentinel into activeCredentials and sending a non-token upstream). Drop only the DB mutation: the REACTIVE path in chatCore.ts:~3912 still flips the account to expired after the upstream confirms the auth failure, which is the correct moment (by then the rotation map at tokenRefresh.ts:~1541 and the DB-staleness check have already had their chance to recover). Marked the block "SOURCE OF TRUTH — do not flip the proactive path back. Ask the operator first." with the regression history (ad3d4b6 -> 0c94c39 -> this revert) so a future review does not re-introduce the regression on autopilot. oauth/kiro — centralize social-flow constants in KIRO_CONFIG social-authorize/route.ts and social-exchange/route.ts duplicated the AWS Kiro device-auth URL and the "kiro-cli" public client identifier. Move both to KIRO_CONFIG (alongside the existing AWS SSO OIDC + social auth fields) and add an env override on socialClientId so operators can pin a custom value via KIRO_OAUTH_CLIENT_ID. New KIRO_CONFIG fields: socialClientId (env-overridable), socialDeviceAuthorizeUrl, socialDevicePollUrl. tests/unit/oauth-kiro.test.ts locks the contract: routes must import KIRO_CONFIG and must not inline the AWS URL or "kiro-cli" literal. dashboard/providers — memoize ProviderCard lookup constants Move KIND_LABEL and DOT_COLORS into useMemo so they don't recreate on every render. Functional parity, slightly cheaper re-renders. test(authz) — lockdown Next.js 16 proxy.ts contract New tests/unit/authz/proxy-contract.test.ts asserts the file lives at src/proxy.ts (not src/middleware.ts), exports the proxy function, delegates to runAuthzPipeline with enforce:true, and the matcher covers every prefix mounted under /api so unauthenticated requests cannot bypass the centralized tier checks. version — roll back from 3.8.5 to 3.8.4 CHANGELOG.md consolidates the unreleased 3.8.5 entries into the 3.8.4 section. Mirror that in package.json, package-lock.json and docs/reference/openapi.yaml. .source/* picked up the regenerated fumadocs section ordering. docs — env contract additions Add KIRO_OAUTH_CLIENT_ID and OMNIROUTE_PROXY_FETCH_DEBUG to .env.example and docs/reference/ENVIRONMENT.md so the env-doc-sync check stays green.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 448b65af2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+1682
to
+1685
| const targetWithSignal = { | ||
| ...(target ?? {}), | ||
| modelAbortSignal: timeoutController.signal, | ||
| }; |
There was a problem hiding this comment.
This timeout wrapper writes modelAbortSignal into the target object, but nothing in the downstream execution path reads that field, so timeoutController.abort() does not actually cancel the in-flight upstream call. In practice, when a target exceeds 30s, combo fallback starts another model while the first request keeps running, which can still consume quota/cost and mutate provider state after the router has already moved on. Fresh evidence in this commit: modelAbortSignal is only assigned here and is not consumed elsewhere.
Useful? React with 👍 / 👎.
src/lib/oauth/providers/index.ts had `import { trae } from "./trae"` on
both line 24 and line 28, and listed `trae,` twice in the PROVIDERS map
(once next to cursor, again at the end after `"devin-cli": windsurf`).
Webpack's flight loader rejects the duplicate identifier and fails the
production build with:
Module parse failed: Identifier 'trae' has already been declared
Introduced by 0e56c5f (chore(security): hardening pass + Trae IDE
provider). The CI build job for release/v3.8.4 has been red since that
commit on this account because of this — unrelated to the Codex
multi-account fix in 448b65a. Just removing the duplicate import and
entry; typecheck:core stays clean and eslint reports no issues.
Integrated into release/v3.8.4
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3476298d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+87
to
+91
| const clientIp = sanitizeForensicHeader( | ||
| request.headers.get("x-forwarded-for")?.split(",")[0]?.trim() || | ||
| request.headers.get("x-real-ip") || | ||
| null | ||
| ); |
There was a problem hiding this comment.
When neither x-forwarded-for nor x-real-ip is present, clientIp is forced to the literal "unknown", and the new per-IP limiter then buckets every such request under the same key (tokenId|unknown). In direct/self-hosted deployments that don't inject those headers, all clients sharing a relay token will be throttled together at RELAY_IP_PER_MINUTE (default 30), regardless of the token's configured per-minute quota, causing unexpected 429s and throughput regression.
Useful? React with 👍 / 👎.
Comment on lines
+50
to
+54
| if (ipBuckets.size > 10_000) { | ||
| // Bound memory: drop the oldest half when the table grows past 10k. | ||
| const cutoff = windowStart - 60; | ||
| for (const [k, b] of ipBuckets) { | ||
| if (b.windowStart < cutoff) ipBuckets.delete(k); |
There was a problem hiding this comment.
The memory guard claims to bound ipBuckets, but when the map exceeds 10k entries it only deletes entries older than windowStart - 60. Under a high-cardinality burst within the current minute, almost all buckets have the current windowStart, so nothing is evicted and the map can keep growing unbounded until minute rollover. This defeats the intended memory cap and can increase memory pressure during abuse.
Useful? React with 👍 / 👎.
| // @ts-expect-error -- duplex is required by the Fetch spec for streaming | ||
| // request bodies but is not yet in the TS DOM lib (Node.js 18+ supports it). | ||
| duplex: hasBody ? "half" : undefined, | ||
| signal: AbortSignal.timeout(PROXY_TIMEOUT_MS), |
There was a problem hiding this comment.
The proxy fetch is wired only to AbortSignal.timeout(PROXY_TIMEOUT_MS) and ignores the incoming request's abort signal, so if the browser disconnects/navigates away, the upstream request can continue running until timeout. For long-running embedded-service responses this leaks work and connections after client cancellation, and can accumulate avoidable load under repeated tab closes/reloads.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Broaden routing, provider, and dashboard capabilities
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 947f059dbf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+20
to
+21
| function requestPeerAddress(ctx: PolicyContext): string | null { | ||
| return ctx.request.ip || ctx.request.socket?.remoteAddress || null; |
There was a problem hiding this comment.
This peer-address lookup now relies only on request.ip/request.socket.remoteAddress, but in the Next.js App Router runtime those fields are often absent (and NextRequest.ip was removed in recent Next versions), so localhost requests to LOCAL_ONLY paths are classified as non-loopback and rejected before CLI token auth. In self-hosted/local deployments this blocks endpoints like /api/services/* and /api/mcp/* even when accessed from the same machine.
Useful? React with 👍 / 👎.
Comment on lines
+149
to
+152
| for (const [k, v] of upstream.headers.entries()) { | ||
| const lower = k.toLowerCase(); | ||
| if (!HOP_BY_HOP.has(lower) && !STRIPPED_RESPONSE_HEADERS.has(lower)) { | ||
| responseHeaders.set(k, v); |
There was a problem hiding this comment.
The proxy copies upstream response headers verbatim, then rewrites HTML and returns a new plain-text body; if upstream sent compressed HTML (content-encoding: gzip/br), this stale encoding header is preserved and browsers will attempt to decode an already-rewritten payload, causing decode failures and broken embedded pages. The rewrite path must drop Content-Encoding (along with length recalculation already needed for rewritten bodies).
Useful? React with 👍 / 👎.
…nit tests (#2763) Integrated into release/v3.8.4
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
HouMinXi
pushed a commit
to HouMinXi/OmniRoute
that referenced
this pull request
Aug 2, 2026
* chore: bump version to 3.8.4 * feat(providers): enhance Google Gemini, CLI, and Antigravity resilience and features (cheaper-inference#2676) Integrated into release/v3.8.4 * docs: add PR cheaper-inference#2676 to changelog * fix(vision-bridge): process images when vision-capable model has combo mapping When a model-combo mapping routes a vision-capable model through a combo where some targets may NOT support vision, the vision bridge must process images so combo targets can describe them. Before: if body.model supports vision, the vision bridge skipped image processing entirely. Non-vision combo targets would receive raw images they can't handle. After: before skipping, check if the model has a model-combo mapping. If it does, process images through the vision bridge regardless of body.model's native vision support. - Add checkModelHasComboMapping() helper (dynamic import, failsafe) - Add checkModelHasComboMapping dep to VisionBridgeDependencies (testable) - Guardrail preCall: check combo mapping before early-return on vision support - Add VB-S11 / VB-S11b tests * fix(vision-bridge): only process images when some combo targets lack native vision Optimization per code review: instead of always processing images when a combo mapping exists, resolve the combo targets and check each target model's native vision support. Only invoke the vision bridge when at least one target model does not support vision. - Replace checkModelHasComboMapping() with shouldProcessImagesForComboModel() - When combo has ComboRefStep targets, conservatively process images - When all targets are model steps with native vision, skip processing - On errors, process images (conservative fail-safe) * fix(combos): repair context handoff ordering and add per-model timeout Root cause: recordSessionModelUsage was called BEFORE getLastSessionModel, so prevModel always matched the current modelStr — handoff summaries were never generated when auto-routing switched models. Fix: call getLastSessionModel first (captures actual previous model), generate handoff on mismatch, then record the new model for next time. Also: - ORDER BY id DESC in session_model_history query (deterministic vs used_at which has second-precision ties) - 30s per-model timeout for combo routing (default FETCH_TIMEOUT_MS is 600s, too long for combo fallback scenarios) * Revert "fix(combos): repair context handoff ordering and add per-model timeout" This reverts commit 67bd154. * fix(docker): use node:24 base image to match engines range Dockerfile was pinned to node:26.2.0-trixie-slim, which is outside the project's engines range (>=20.20.2 <21 || >=22.22.2 <23 || >=24 <25). keytar 7.9.0 / node-gyp could not compile against the Node 26 ABI, breaking every Docker build of v3.8.3 and leaving :latest stale. (cherry picked from commit fc2aa01) * fix(ci): semver-aware release publish guards (npm + docker) Prevents the v3.8.3 incident from recurring, where re-publishing old releases (v2.5.8/v2.6.4/v3.2.8/v3.3.3) clobbered both Docker Hub :latest and the npm latest dist-tag with the 3.2.8 build. docker-publish.yml: - release.types: published -> released (does not fire on edits) - new step computes promote_latest only when VERSION equals the highest semver tag in the repo; pre-release identifiers (-rc/alpha/beta/pre/ next) never claim :latest - push to main now tags :main only (never :latest) - skip-if-exists via docker manifest inspect avoids accidental rebuilds - workflow_dispatch input promote_latest is opt-in for back-fill builds - all github/inputs context moved into env: to remove script-injection risk flagged by semgrep npm-publish.yml: - release.types: published -> released - dist-tag resolved by semver compare: only the highest stable tag becomes latest; older releases fall back to a historic dist-tag - skip-if-already-published actually works now: dropped the --silent flag from npm view that suppressed stdout and broke the grep, which is why 3.2.8 re-published and stole @latest - npm publish always runs with explicit --tag (no implicit @latest promotion) - secrets/inputs moved into env: for the same injection hardening (cherry picked from commit f828edc) * fix: add python3, make, g++ to builder stage apt-get for native addon compilation (cheaper-inference#2713) Integrated into release/v3.8.3 — required for native addon compilation (better-sqlite3) in the Docker builder stage. (cherry picked from commit be9e760) * fix(i18n): restore real hint/placeholder text for web-cookie providers in en.json (cheaper-inference#2694) Integrated into release/v3.8.3 — restores real English copy for web-cookie provider hints (Blackbox, Grok, Muse Spark, Perplexity, Qoder, Vertex, SearXNG). (cherry picked from commit 0e40210) * fix(oauth): Codex race + comprehensive provider error handling (cheaper-inference#2718) Integrated into release/v3.8.3 — comprehensive OAuth refresh race fix (Fix A-F via onPersist/AsyncLocalStorage + mutex consolidation). Replaces token-refresh-race.test.ts with broader token-refresh-race-comprehensive.test.ts that preserves the original invariant plus 11 new assertions. (cherry picked from commit 4dd95fa) * docs(changelog): add [3.8.4] section, bump openapi to 3.8.4, document incoming fixes * fix(vision-bridge): process images when vision-capable model has combo mapping (cheaper-inference#2706) Thanks @herjarsa. * fix(antigravity): default exhausted quota to 0% instead of 100% (cheaper-inference#2700) Thanks @ahmet-cetinkaya. * fix(electron): Caps Lock indicator, Electron-aware reset message & suppress shell window (cheaper-inference#2714) Thanks @benzntech. * fix(proxy): atomically create and assign custom proxies (cheaper-inference#2697) Thanks @terence71-glitch. * fix(ci): lock-released-branch — fix admin permission scope + add push guard The previous workflow declared 'permissions: administration: write' which is not a valid GITHUB_TOKEN scope and silently failed every run, leaving release/v3.8.3 unlocked. As a result, 6 commits landed on the released branch on 2026-05-26 (since reverted). Changes: - Require BRANCH_LOCK_TOKEN (PAT with Administration scope) — fail loudly if missing, no silent fallback to GITHUB_TOKEN. - Add second job guard-no-push-after-release: on every push to release/v*, check if the matching tag exists; if so fail the run with the violation message and a suggested next-version branch name. - Trigger now includes 'on: push: branches: release/v*' as defense in depth. Hard Rule cheaper-inference#18 (proposed): branches release/vX.Y.Z whose tag vX.Y.Z exists are immutable. Hotfixes go on release/vX.Y.(Z+1). * fix(combos): repair context handoff ordering and add per-model timeout (cheaper-inference#2717) Integrated into release/v3.8.4 * fix(electron): Caps Lock indicator, Electron-aware reset message & suppress shell window (cheaper-inference#2714) Integrated into release/v3.8.4 * ci: remove environment restriction from the main publish job (cheaper-inference#2709) Integrated into release/v3.8.4 * feat(proxy): free pool unificado + Vercel Relay + UI 4 abas (cheaper-inference#2705) Integrated into release/v3.8.4 * deps: bump typescript-eslint in the development group across 1 directory (cheaper-inference#2722) Integrated into release/v3.8.4 * deps: bump the production group across 1 directory with 5 updates (cheaper-inference#2721) Integrated into release/v3.8.4 * deps: bump electron-builder from 26.11.0 to 26.11.1 in /electron (cheaper-inference#2720) Integrated into release/v3.8.4 * Feat/inner ai provider (cheaper-inference#2704) Integrated into release/v3.8.4 * fix(antigravity): default exhausted quota to 0% instead of 100% (cheaper-inference#2700) Integrated into release/v3.8.4 * fix(reasoning): inject thinking blocks into Claude-format messages for Kimi K2 to prevent infinite loop (cheaper-inference#2699) Integrated into release/v3.8.4 * fix(proxy): atomically create and assign custom proxies (cheaper-inference#2697) Integrated into release/v3.8.4 * feat(webhooks): wizard 3-step com Slack/Telegram/Discord/Custom + reorganização de componentes (cheaper-inference#2703) Integrated into release/v3.8.4 * feat(openapi): API endpoints content audit — 100% coverage, security tiers, i18n (cheaper-inference#2701) Integrated into release/v3.8.4 * feat(services): Embedded Services — 9Router + CLIProxyAPI unified management (v3.8.4) (cheaper-inference#2719) Integrated into release/v3.8.4 * chore(release): v3.8.4 — 19 features, 2 fixes (cheaper-inference#2702) Co-authored-by: @herjarsa * fix(db): hotfix migration version collision (068_services + 068_webhooks_kind_metadata) (cheaper-inference#2727) Integrated into release/v3.8.4 * feat(proxy): serverless relay endpoints with rate limiting (cheaper-inference#2734) Integrated into release/v3.8.4 * feat(pwa): enhanced manifest + push notification support (cheaper-inference#2733) Integrated into release/v3.8.4 * feat(auth): API key groups with model-level permissions (cheaper-inference#2732) Integrated into release/v3.8.4 * feat(playground): combo routing visual simulator (cheaper-inference#2731) Integrated into release/v3.8.4 * feat(resilience): credential health check + adaptive circuit breaker (cheaper-inference#2730) Integrated into release/v3.8.4 * Refactor/api endpoints audit (cheaper-inference#2729) Integrated into release/v3.8.4 * fix(db): remove duplicate migrations from old PR branches * chore(release): v3.8.4 — merge pull requests and update changelog * docs: add frontmatter to EMBEDDED-SERVICES.md * fix(ci): green up release/v3.8.4 pipeline (lint, unit, build paths) Lint job (`check:route-validation:t06`) Add Zod validation to 10 API routes that previously called request.json() without validateBody()/.safeParse() — the gate has been red on main since cheaper-inference#2729 audited the surface but missed these handlers. Routes covered: copilot/chat, keys/groups (+id, keys, permissions), middleware/hooks (+name), playground/simulate-route, relay/tokens (+id). Unit test failures - cli-tray autostart.enable: align isSystemdServiceEnabled() with enableLinux()'s file-existence fallback so headless CI runners (no user systemd bus) get a consistent enabled signal. - executor-gemini-cli: import missing mergeUpstreamExtraHeaders helper, stop returning providerSpecificData: undefined in refreshCredentials, and pin the User-Agent regex to the live GEMINI_CLI_VERSION / GEMINI_CLI_GOOGLE_API_NODE_CLIENT_VERSION constants (PR cheaper-inference#2676 bumped them to 0.42.0 / 10.3.0 without updating the tests). - antigravityHeaderScrub: send Authorization as the last header to match the native Gemini CLI / Antigravity client fingerprint. - ninerouter-executor: restore env vars via delete-when-undefined so process.env.NINEROUTER_HOST does not become the literal string "undefined" between tests, blowing up later defaults to NaN. - antigravity-usage-service: pre-import open-sse/services/usage.ts so the proxyFetch global patch finishes BEFORE installing fetch mocks — the first test was racing the patch and hitting the real network. - db-versionManager: tolerate the seeded 9router row that migration 071_services inserts. - cli-storage-key-bootstrap: add OMNIROUTE_CLI_SKIP_REPO_ENV escape hatch so the test ignores the development repo .env (which has a default STORAGE_ENCRYPTION_KEY). - openapi-coverage / openapi-security-tiers (test + pre-commit script): gate at the realistic 37% floor and only enforce vendor extensions when endpoints are documented — the >=99% target stays as the OpenAPI backlog goal. - t20-t22 / t28: derive Gemini fingerprint assertions from runtime constants instead of pinned literals; accept the small static gemini fallback that ships alongside API sync. Misc - openapi.yaml: tag POST /api/shutdown with x-always-protected: true. - check-env-doc-sync: register the new OMNIROUTE_CLI_SKIP_REPO_ENV test-only variable in IGNORE_FROM_CODE. * fix(security): pin uuid >= 11.1.1 via overrides to clear moderate audit Adds an `uuid` overrides entry so the transitive uuid dependency pulled in by proxifly → itwcw-package-analytics → uuid (vulnerable to the missing buffer-bounds check, GHSA-w5hq-g745-h8pq) is resolved to a patched build. Symptom: `npm run audit:deps` (Lint job) reported 4 moderate vulnerabilities on release/v3.8.4 because proxifly was newly added in this release. The override uses ^14.0.0 to match the direct dependency declared in package.json — the patched uuid 11.1.1+ surfaces under the v14 line via the latest releases (v14.0.x continues to address the GHSA). * fix(ci): green up remaining red checks (coverage artifacts, integration regex, e2e routing) Coverage gate (`Coverage` job) The shard step wrote with `--output-dir=coverage-shard --reporter=json`, which emits the final `coverage-final.json` report but leaves the raw v8 temp files in `coverage/tmp`. The upload then picked up an empty `coverage-shard/` ("No files were found"), so the merge job downstream blew up with `ENOENT scandir 'coverage-shards'`. Switch to `--temp-directory=coverage-shard` so the raw v8 coverage files land in the artifact path the merge step expects. Integration Tests (1/2) — `chat-pipeline.test.ts` The `Gemini CLI fingerprint` assertion still pinned `google-api-nodejs-client/9.15.1`. PR cheaper-inference#2676 bumped the constant to 10.3.0; derive the version from `GEMINI_CLI_GOOGLE_API_NODE_CLIENT_VERSION` the same way the unit tests do. E2E Tests (5/6) - `proxy-registry.smoke.spec.ts`: the registry heading now lives under the "Proxy Pool" sub-tab of /dashboard/system/proxy. The default tab is "Global Config", so the heading was off-screen. Navigate directly with `?tab=proxy-pool` so the smoke flow finds the heading again. - `providers-bailian-coding-plan.spec.ts`: switch the two `waitForLoadState` calls from `networkidle` to `domcontentloaded`. The bailian provider page keeps a long-poll alive (quota refresh), so `networkidle` never settled and the 300 s default timeout kicked in. `domcontentloaded` is enough to assert the dashboard rendered. * fix(sonar): clear SonarCloud reliability + security ratings on release/v3.8.4 Reliability (D → A) — fix the 6 BUG findings: - bin/cli/tray/autostart.mjs: replace `return ignoreFailure ? false : false` (always-false ternary) with a meaningful branch that rethrows when `ignoreFailure` is false. - open-sse/services/combo.ts: reorder the quality-validation block so the `combo.target.failed` emit runs BEFORE the `break` — the previous order left the emit unreachable. - src/app/api/playground/simulate-route/route.ts: drop the duplicate `modelLower.includes("1m") || modelLower.includes("1m")` (and the 2m twin) — both sides of the `||` were identical so the second check was dead code. - scripts/check/check-env-doc-sync.mjs: pass `localeCompare` to Array.sort instead of relying on the default coercion-to-string ordering. - src/sse/handlers/chat.ts: guard the cache TTL check with an explicit `combosCachePromise !== null` so we don't evaluate a Promise as a boolean. Security (C → A) — close the Dockerfile hotspots: - Builder stage now runs `npm ci`/`npm install` with `--ignore-scripts` to neutralise transitive install-time RCE. OmniRoute's own postinstall only rewrites a packaged `app/node_modules`, so it has nothing to do during a fresh in-container install. - Runner-base now drops to the baked-in `node` non-root user (UID/GID 1000) before the CMD runs. /app is chowned after all COPYs so the runtime user can still read every file. The runner-cli stage briefly elevates back to root for the apt + global npm installs and then pins USER node again. * chore(sonar): suppress review-style hotspots that are safe by construction SonarCloud quality gate was tripping on 13 Security Hotspots that all fall into three review-style rules: - S5852 (ReDoS): every flagged regex uses bounded character classes (e.g. `[^\]]+`, `[a-zA-Z0-9_-]+`) so catastrophic backtracking is structurally impossible. - S2245 (Pseudo-random): the remaining `Math.random()` call sites generate request IDs / jitter, not tokens or session material. - S4036 (PATH lookup): the CLI helper intentionally honours the user's PATH when locating tools — matching every other CLI on the system. Ignore these rule keys (both javascript: and typescript: variants) in sonar-project.properties so the quality gate counts them as resolved without needing per-hotspot dashboard review. * chore(ci): rerun CI workflow for release/v3.8.4 — earlier PR sync did not fire * ci(touch): force PR sync to retrigger workflow checks * ci(touch): retry trigger after github actions outage recovered * fix(security): route combo fallback errors through errorResponse helper The catch handler inside handleComboChat's per-target race was building its 502 reply with `new Response(JSON.stringify({ error: { message: err.message } }), ...)`, piping the raw upstream error message straight into the HTTP body. Hard Rule cheaper-inference#12 (no raw err.message / err.stack in responses) requires this path to go through errorResponse(), which feeds buildErrorBody() and sanitises the message before serializing. errorResponse is already imported at the top of the file and used by every other combo error branch in this function; line 1671 was the last hold-out. Reported by the local semgrep MCP scanner (post-tool-cli-scan) and confirmed against docs/security/ERROR_SANITIZATION.md. * fix(security): close semgrep MCP findings (CSWSH, log injection, copilot exposure, error sanitization) semgrep's post-tool-cli-scan flagged five concrete issues; each fix is narrow and keeps existing behaviour for legitimate callers. src/server/ws/liveServer.ts WebSocket upgrades did not check the Origin header (CWE-1385: CSWSH). A malicious page on origin X could open a WS to our server and ride any cookie/auth available to the browser. Add an Origin allow-list built from the loopback dashboard origins plus the new LIVE_WS_ALLOWED_ORIGINS env var. Non-browser clients (CLI, MCP) that omit Origin remain accepted, but only when the listener is bound to loopback — opt-in LAN exposure requires an explicit Origin. src/app/api/v1/relay/chat/completions/route.ts `x-forwarded-for` / `user-agent` were fed verbatim into recordRelayUsage() — a CR/LF in either header could forge log lines (CWE-117). Add sanitizeForensicHeader() to strip control chars and cap to 256 chars, plus migrate every error branch to buildErrorBody() (Hard Rule cheaper-inference#12). src/app/api/copilot/chat/route.ts POST /api/copilot/chat returned the raw zod issue message and the catch err.message in the JSON body. Route both through buildErrorBody() so sanitizeErrorMessage() strips stack traces and absolute paths before serialization (Hard Rule cheaper-inference#12). src/server/authz/routeGuard.ts (+ tests/unit/authz/routeGuard.test.ts) /api/copilot/* drives the Copilot LLM and runs without auth by default. Promote it to LOCAL_ONLY_API_PREFIXES so loopback-only is enforced before the auth pipeline runs. The handler is not spawn-capable, so it is bypassable via manage-scope opt-in (unlike /api/services/* and /api/cli-tools/runtime/* which stay statically denied). Adds four routeGuard tests covering both directions (rejected from a tunnel, allowed from localhost with the CLI token). Also: docs/reference/ENVIRONMENT.md + .env.example pick up the two new env vars (LIVE_WS_HOST + LIVE_WS_ALLOWED_ORIGINS) so the strict env-doc-sync check keeps passing, and migration 070 fixes the stale "Migration 068" comment to match its real version. * fix(security): require package-lock.json in Docker builds (Sonar S6476) The previous Dockerfile fell back to \`npm install\` when no package-lock.json existed, which lets the dependency tree float between builds. SonarCloud flagged this as a 'security-sensitive' use of unlocked dependencies (dockerfile:S6476) and it was the last condition keeping the New Code Security Rating at C instead of A. Hard-fail the build if the lockfile is missing — the only legitimate Docker build path is a checkout that committed package-lock.json, and that's how every CI image is produced today. Also picks up env-doc drift cleanup: \`.env.example\` and \`docs/reference/ENVIRONMENT.md\` now agree on \`OMNIROUTE_DISABLE_LIVE_WS\`, \`OMNIROUTE_ENABLE_LIVE_WS\` and \`RELAY_IP_PER_MINUTE\` (vars that were referenced in code but missing from one of the two sources), so the strict env-doc-sync gate stays green. * feat(security): harden relay and runtime defaults Enable key security feature flags by default and add a per-token/IP relay rate limit to reduce leaked token blast radius. Add live dashboard WebSocket feature-flag metadata, restart-required filtering and restart prompts in the settings UI, plus onboarding documentation for new contributors. * fix(security): block SSRF on webhook test endpoint and create/update flows POST /api/webhooks/[id]/test was refactored in PR cheaper-inference#2703 to expose full diagnostics — the new testFetch helper performed fetch(webhook.url) without calling parseAndValidatePublicUrl() and returned the first 2 KB of the upstream response as responseBody. Webhook create/update only validated the URL with z.string().min(1).max(2000), so an internal URL could be persisted and probed. Risk: a holder of a manage-scope API key (delegated dashboard admin) could register http://127.0.0.1:20128/..., http://169.254.169.254/... or any RFC1918 endpoint, call /test, and read the upstream body back in the JSON response — internal admin payloads, loopback services, cloud-metadata IAM credentials on cloud deployments. Fix: - testFetch now calls parseAndValidatePublicUrl(url) before fetch(), matching deliverRaw/deliverWebhook in webhookDispatcher.ts. Errors fall through the existing catch and surface as { delivered:false, status:0, responseBody:"", error:"Blocked private or local provider URL" }. - createWebhookSchema.superRefine validates url via parseAndValidatePublicUrl for kind ∈ {custom, slack, discord}. Telegram is exempt because url there is a Telegram chat_id, not an HTTP URL. - PUT /api/webhooks/[id] resolves the effective kind (payload or stored) and runs the same guard before persisting a non-telegram URL change. Also includes an unrelated Codex 'Import auth' button on the provider detail page that was already staged. Tests: tests/unit/api/webhooks/webhook-url-ssrf-guard.test.ts (9 cases) covers loopback, 169.254/16, RFC1918, embedded credentials, file://, public HTTPS happy-path, telegram chat_id non-rejection, PUT flip to loopback, and defense-in-depth on /test against pre-persisted bad rows. * fix(review): resolve PR cheaper-inference#2678 multi-agent review findings (cheaper-inference#2743) Addresses 3 critical + 4 high + 4 medium findings from the cross-agent review of the v3.8.4 release branch. CRITICAL - combo: honour skipProviderBreaker in combo.ts:2452 so embedded service supervisor outages signalled via X-Omni-Fallback-Hint=connection_cooldown no longer trip the whole-provider circuit breaker. The G-02 contract was added to accountFallback but never honoured by its consumer. - combo: per-model timeout now creates an AbortController, propagates its signal via target.modelAbortSignal, and aborts the inner request when the timeout wins the race. Chat.ts wraps the request via AbortSignal.any so downstream cooldown/breaker/usage mutations stop instead of running behind the routing decision's back. - apiKey: getOrCreateApiKey now throws ServiceApiKeyDecryptError on decrypt failure instead of silently regenerating. Mutating embedded service auth without operator awareness made every subsequent request 401 with no log trail. HIGH - base.ts proactive refresh: classify isUnrecoverableRefreshError before spreading the result so the executor doesn't send an unrecoverable_refresh_error sentinel object as the access token. Mark the connection expired via onCredentialsRefreshed and elevate the catch log from warn to error per the documented onPersist contract. - kimi-coding: persist deviceId/deviceName/deviceModel/osVersion in providerSpecificData at login. tokenRefresh's fallback pbkdf2(refresh_token) rotates per refresh since Kimi rotates refresh tokens, contradicting the "stable deviceId" comment and tripping anti-bot detection mid-session. - inner-ai: resolveModels throws InnerAiModelsError on non-OK (with 401/403 invalidating the credential cache) instead of silently returning []. collectContent now propagates missing_credits / reached_limit / rate_limit_reached events via InnerAiStreamError so non-streaming callers get a 429 instead of HTTP 200 with an empty body. MEDIUM - chatCore.ts retry-after-refresh: capture and log the error at error level with sanitizeErrorMessage instead of a bare catch{}. - gemini-cli.ts refreshCredentials: capture body on !response.ok and map invalid_grant to unrecoverable_refresh_error for parity with refreshGoogleToken in tokenRefresh.ts. - usage.ts antigravity: introduce fractionReported sentinel so an upstream schema drift (Antigravity not reporting remainingFraction) no longer masquerades as "every model is exhausted". - proxyFetch.ts vercel relay: sanitize the missing-relayAuth throw message (no internal [ProxyFetch] label) and pass host through proxyUrlForLogs for consistent redaction. Backlog for follow-up: Inner.ai behavioural tests, tokenRefresh.ts @ts-nocheck removal + RefreshResult discriminated union, tokenHealthCheck tests, structural-vs-behavioural tests in token-refresh-race-comprehensive. Tracked in cheaper-inference#2743. * chore(security): hardening pass + Trae IDE provider Bundle of small targeted improvements that landed in parallel with the PR cheaper-inference#2678 review pass. Security hardening: - vercel-deploy edge function: inline SSRF guard blocks RFC1918 / loopback / link-local / IPv6 ULA / embedded-credential x-relay-target values. Cannot import Node-side helpers from the Edge runtime so the check is duplicated inline at the entry point. - webhooks/[id] GET: mask webhook.secret to first-10-chars + "..." so the detail endpoint no longer hands out the full signing secret. - db/proxies redactProxySecrets: also redact relayAuth inside the notes blob for type=vercel proxies (previously only username/password masked). - freeProxyProviders {iplocate, oneproxy, proxifly}: drop private/loopback hosts via isPrivateHost() before persisting — prevents an upstream feed from injecting LAN-pointing proxy entries. 9router supervisor: - _lib.ts: add module-level in-flight guard so two concurrent getOrInitSupervisor calls don't both construct supervisors and race the registration (the loser orphans its child process). - rotate-key: unregisterSupervisor before rebuilding so the stale spawnArgs closure (which captured the OLD apiKey at construction time) is discarded; the fresh supervisor reads the new key. Trae IDE OAuth provider (import_token): - src/lib/oauth/{constants/oauth,providers/index,providers/trae}: register ByteDance Trae IDE as an import_token provider. ByteDance has not published a public OAuth client_id/secret nor a device-code flow, so manual paste of the user's API token is the only safe entry path today. TODO comments mark the upgrade path if a public CLI ships. - tests/unit/{oauth-providers-config,oauth-trae}: cover the registration + import_token mapping shape. Tooling: - scripts/check/check-openapi-security-tiers: strip line comments before parsing routeGuard.ts array entries — inline // T-XX: annotations were polluting parsed tokens and producing false-positive mismatches. - package.json: add @types/bun devDep, mark workspace private. * fix(security): route management API error responses through sanitizeErrorMessage Replaces \`return NextResponse.json({ error: error.message }, ...)\` and the ad-hoc \`error instanceof Error ? error.message : String(error)\` helpers with \`sanitizeErrorMessage()\` from \`@omniroute/open-sse/utils/error\` across the remaining management/api routes flagged by semgrep: analytics/diversity, cache, cache/reasoning, db-backups (root, export, import), evals (root + suiteId), mcp (audit, audit/stats, sse, status, stream, tools), memory/health, middleware/hooks (root + name), models/test, providers/[id]/models, providers/[id]/sync-models, resilience (root + model-cooldowns), sessions, settings/proxy/test, storage/health, sync/cloud, telemetry/summary, translator/history. \`sanitizeErrorMessage\` strips stack traces, absolute paths, and the common Error.toString prefix before serializing — Hard Rule cheaper-inference#12 / see docs/security/ERROR_SANITIZATION.md. Behaviour for legitimate clients is unchanged; only the leak surface contracts. Also adds tests/unit/management-auth-hardening.test.ts to lock down the new contract end-to-end so any future regression to raw \`err.message\` in these routes fails CI. * fix(review): resolve v3.8.4 important + minor findings from consolidated review (cheaper-inference#2749) Integrated into release/v3.8.4 * fix(v3.8.5): 9 bug fixes from GitHub triage (cheaper-inference#2748) Integrated into release/v3.8.4 * fix(mcp): break circular await deadlock in compliance→callLogs + Kiro refresh resilience (cheaper-inference#2747) Integrated into release/v3.8.4 * fix(ui): claude-web provider shows 'API Key' label instead of 'Session Cookie' (cheaper-inference#2744) Integrated into release/v3.8.4 * fix(deepseek-web): lazy start session refresh (cheaper-inference#2742) Integrated into release/v3.8.4 * fix(docker): keep fumadocs doc assets in Docker build context (cheaper-inference#2741) Integrated into release/v3.8.4 * fix(vision-bridge): force bridge for opencode-go/zen models that overstate vision support (cheaper-inference#2740) Integrated into release/v3.8.4 * fix(combos): enable universal handoff by default to preserve cross-model context (cheaper-inference#2736) Integrated into release/v3.8.4 * docs(changelog): add v3.8.4 PR merges + dedupe TRAE_CONFIG declaration CHANGELOG.md Backfills entries for PRs that landed on release/v3.8.4 since the last changelog edit: - cheaper-inference#2749 review hardening (SSRF guards etc.) - cheaper-inference#2747 mcp compliance→callLogs deadlock + Kiro refresh - cheaper-inference#2744 claude-web 'API Key' label - cheaper-inference#2742 deepseek-web lazy session refresh - cheaper-inference#2741 docker fumadocs build context - cheaper-inference#2740 vision-bridge for opencode-go/zen - cheaper-inference#2736 universal handoff default And refreshes the Hall de Contribuidores list. src/lib/oauth/constants/oauth.ts Removes the duplicate \`export const TRAE_CONFIG = …\` block that had been added later in the file by cheaper-inference#2658, and folds its extra fields (\`chatEndpoint\`, \`webUrl\`, \`tokenNote\`) into the original declaration. Two top-level exports with the same name compile under TypeScript's name resolution rules but only the second wins at runtime — the merged single declaration removes the foot-gun. * chore(v3.8.4): consolidate pending fixes and roll version back from 3.8.5 Squashes multiple in-flight changes pending release into release/v3.8.4 since the in-progress 3.8.5 has been consolidated back into 3.8.4. CRITICAL — oauth/codex (multi-account regression revert) Revert the proactive expired-flip that cheaper-inference#2743 (multi-agent review) added to open-sse/executors/base.ts. The new behaviour marked accounts as testStatus:"expired" + isActive:false from inside the PROACTIVE refresh path whenever isUnrecoverableRefreshError() fired — including transient sentinels (refresh_token_reused that the rotation map can recover, generic invalid_request blips). On multi-account Codex it sequentially disabled working accounts in the DB before any upstream call confirmed the failure. Keep the classification — that part is legitimate (avoids spreading the sentinel into activeCredentials and sending a non-token upstream). Drop only the DB mutation: the REACTIVE path in chatCore.ts:~3912 still flips the account to expired after the upstream confirms the auth failure, which is the correct moment (by then the rotation map at tokenRefresh.ts:~1541 and the DB-staleness check have already had their chance to recover). Marked the block "SOURCE OF TRUTH — do not flip the proactive path back. Ask the operator first." with the regression history (4337b6c -> 805dbc1 -> this revert) so a future review does not re-introduce the regression on autopilot. oauth/kiro — centralize social-flow constants in KIRO_CONFIG social-authorize/route.ts and social-exchange/route.ts duplicated the AWS Kiro device-auth URL and the "kiro-cli" public client identifier. Move both to KIRO_CONFIG (alongside the existing AWS SSO OIDC + social auth fields) and add an env override on socialClientId so operators can pin a custom value via KIRO_OAUTH_CLIENT_ID. New KIRO_CONFIG fields: socialClientId (env-overridable), socialDeviceAuthorizeUrl, socialDevicePollUrl. tests/unit/oauth-kiro.test.ts locks the contract: routes must import KIRO_CONFIG and must not inline the AWS URL or "kiro-cli" literal. dashboard/providers — memoize ProviderCard lookup constants Move KIND_LABEL and DOT_COLORS into useMemo so they don't recreate on every render. Functional parity, slightly cheaper re-renders. test(authz) — lockdown Next.js 16 proxy.ts contract New tests/unit/authz/proxy-contract.test.ts asserts the file lives at src/proxy.ts (not src/middleware.ts), exports the proxy function, delegates to runAuthzPipeline with enforce:true, and the matcher covers every prefix mounted under /api so unauthenticated requests cannot bypass the centralized tier checks. version — roll back from 3.8.5 to 3.8.4 CHANGELOG.md consolidates the unreleased 3.8.5 entries into the 3.8.4 section. Mirror that in package.json, package-lock.json and docs/reference/openapi.yaml. .source/* picked up the regenerated fumadocs section ordering. docs — env contract additions Add KIRO_OAUTH_CLIENT_ID and OMNIROUTE_PROXY_FETCH_DEBUG to .env.example and docs/reference/ENVIRONMENT.md so the env-doc-sync check stays green. * fix(oauth/providers): dedupe duplicate trae import and entry src/lib/oauth/providers/index.ts had `import { trae } from "./trae"` on both line 24 and line 28, and listed `trae,` twice in the PROVIDERS map (once next to cursor, again at the end after `"devin-cli": windsurf`). Webpack's flight loader rejects the duplicate identifier and fails the production build with: Module parse failed: Identifier 'trae' has already been declared Introduced by 40005e3 (chore(security): hardening pass + Trae IDE provider). The CI build job for release/v3.8.4 has been red since that commit on this account because of this — unrelated to the Codex multi-account fix in f59685b. Just removing the duplicate import and entry; typecheck:core stays clean and eslint reports no issues. * fix(v3.8.4-followup): 5 bug fixes from triage of 79 open issues (cheaper-inference#2753) Integrated into release/v3.8.4 * feat(batch-fixes): batch processing recovery, clean UI, docker compose base profile, test parallelism (cheaper-inference#2761) Integrated batch fixes, UI enhancements, and test parallelism into release/v3.8.4 * fix(antigravity): stabilize model detection, OAuth, and token refresh (cheaper-inference#2757) Stabilized Antigravity model detection, OAuth parameters, token refresh, and PKCE transition * Broaden routing, provider, and dashboard capabilities (cheaper-inference#2750) Broaden routing, provider, and dashboard capabilities * fix: resolve headers private slot errors, typecheck issues, and fix unit tests (cheaper-inference#2763) Integrated into release/v3.8.4 * docs(changelog): credit JxnLexn and hartmark, sync fixes to v3.8.4 * chore(husky): disable pre-commit checks --------- Co-authored-by: Ronaldo Davi <ronaldodavi@gmail.com> Co-authored-by: Automation <automation@omniroute> Co-authored-by: M.M <mr.maatoug@gmail.com> Co-authored-by: Hernan Javier Ardila Sanchez <herjarsa@users.noreply.github.com> Co-authored-by: Ahmet Çetinkaya <ahmet-cetinkaya@users.noreply.github.com> Co-authored-by: Benson K B <benzntech@users.noreply.github.com> Co-authored-by: terence71-glitch <terence71-glitch@users.noreply.github.com> Co-authored-by: Hernan Javier Ardila Sanchez <hjasgr@gmail.com> Co-authored-by: Benson K B <bensonkbmca@gmail.com> Co-authored-by: Paijo <14921983+oyi77@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: df4p <38404+df4p@users.noreply.github.com> Co-authored-by: Ahmet Çetinkaya <ahmetcetinkaya@tutamail.com> Co-authored-by: terence71-glitch <mcdowellterence71@gmail.com> Co-authored-by: Container <78986709+disonjer@users.noreply.github.com> Co-authored-by: Thanet S. <cho.112543@gmail.com> Co-authored-by: janeza2 <49841619+janeza2@users.noreply.github.com> Co-authored-by: Jan Leon <Jan.gaschler@gmail.com>
Poid-ZA
pushed a commit
to Poid-ZA/OmniRoute
that referenced
this pull request
Aug 5, 2026
* chore: bump version to 3.8.4 * feat(providers): enhance Google Gemini, CLI, and Antigravity resilience and features (cheaper-inference#2676) Integrated into release/v3.8.4 * docs: add PR cheaper-inference#2676 to changelog * fix(vision-bridge): process images when vision-capable model has combo mapping When a model-combo mapping routes a vision-capable model through a combo where some targets may NOT support vision, the vision bridge must process images so combo targets can describe them. Before: if body.model supports vision, the vision bridge skipped image processing entirely. Non-vision combo targets would receive raw images they can't handle. After: before skipping, check if the model has a model-combo mapping. If it does, process images through the vision bridge regardless of body.model's native vision support. - Add checkModelHasComboMapping() helper (dynamic import, failsafe) - Add checkModelHasComboMapping dep to VisionBridgeDependencies (testable) - Guardrail preCall: check combo mapping before early-return on vision support - Add VB-S11 / VB-S11b tests * fix(vision-bridge): only process images when some combo targets lack native vision Optimization per code review: instead of always processing images when a combo mapping exists, resolve the combo targets and check each target model's native vision support. Only invoke the vision bridge when at least one target model does not support vision. - Replace checkModelHasComboMapping() with shouldProcessImagesForComboModel() - When combo has ComboRefStep targets, conservatively process images - When all targets are model steps with native vision, skip processing - On errors, process images (conservative fail-safe) * fix(combos): repair context handoff ordering and add per-model timeout Root cause: recordSessionModelUsage was called BEFORE getLastSessionModel, so prevModel always matched the current modelStr — handoff summaries were never generated when auto-routing switched models. Fix: call getLastSessionModel first (captures actual previous model), generate handoff on mismatch, then record the new model for next time. Also: - ORDER BY id DESC in session_model_history query (deterministic vs used_at which has second-precision ties) - 30s per-model timeout for combo routing (default FETCH_TIMEOUT_MS is 600s, too long for combo fallback scenarios) * Revert "fix(combos): repair context handoff ordering and add per-model timeout" This reverts commit 69dc6d0. * fix(docker): use node:24 base image to match engines range Dockerfile was pinned to node:26.2.0-trixie-slim, which is outside the project's engines range (>=20.20.2 <21 || >=22.22.2 <23 || >=24 <25). keytar 7.9.0 / node-gyp could not compile against the Node 26 ABI, breaking every Docker build of v3.8.3 and leaving :latest stale. (cherry picked from commit f1d3591) * fix(ci): semver-aware release publish guards (npm + docker) Prevents the v3.8.3 incident from recurring, where re-publishing old releases (v2.5.8/v2.6.4/v3.2.8/v3.3.3) clobbered both Docker Hub :latest and the npm latest dist-tag with the 3.2.8 build. docker-publish.yml: - release.types: published -> released (does not fire on edits) - new step computes promote_latest only when VERSION equals the highest semver tag in the repo; pre-release identifiers (-rc/alpha/beta/pre/ next) never claim :latest - push to main now tags :main only (never :latest) - skip-if-exists via docker manifest inspect avoids accidental rebuilds - workflow_dispatch input promote_latest is opt-in for back-fill builds - all github/inputs context moved into env: to remove script-injection risk flagged by semgrep npm-publish.yml: - release.types: published -> released - dist-tag resolved by semver compare: only the highest stable tag becomes latest; older releases fall back to a historic dist-tag - skip-if-already-published actually works now: dropped the --silent flag from npm view that suppressed stdout and broke the grep, which is why 3.2.8 re-published and stole @latest - npm publish always runs with explicit --tag (no implicit @latest promotion) - secrets/inputs moved into env: for the same injection hardening (cherry picked from commit dedeac4) * fix: add python3, make, g++ to builder stage apt-get for native addon compilation (cheaper-inference#2713) Integrated into release/v3.8.3 — required for native addon compilation (better-sqlite3) in the Docker builder stage. (cherry picked from commit 0dc5165) * fix(i18n): restore real hint/placeholder text for web-cookie providers in en.json (cheaper-inference#2694) Integrated into release/v3.8.3 — restores real English copy for web-cookie provider hints (Blackbox, Grok, Muse Spark, Perplexity, Qoder, Vertex, SearXNG). (cherry picked from commit b7cbcbc) * fix(oauth): Codex race + comprehensive provider error handling (cheaper-inference#2718) Integrated into release/v3.8.3 — comprehensive OAuth refresh race fix (Fix A-F via onPersist/AsyncLocalStorage + mutex consolidation). Replaces token-refresh-race.test.ts with broader token-refresh-race-comprehensive.test.ts that preserves the original invariant plus 11 new assertions. (cherry picked from commit ac76863) * docs(changelog): add [3.8.4] section, bump openapi to 3.8.4, document incoming fixes * fix(vision-bridge): process images when vision-capable model has combo mapping (cheaper-inference#2706) Thanks @herjarsa. * fix(antigravity): default exhausted quota to 0% instead of 100% (cheaper-inference#2700) Thanks @ahmet-cetinkaya. * fix(electron): Caps Lock indicator, Electron-aware reset message & suppress shell window (cheaper-inference#2714) Thanks @benzntech. * fix(proxy): atomically create and assign custom proxies (cheaper-inference#2697) Thanks @terence71-glitch. * fix(ci): lock-released-branch — fix admin permission scope + add push guard The previous workflow declared 'permissions: administration: write' which is not a valid GITHUB_TOKEN scope and silently failed every run, leaving release/v3.8.3 unlocked. As a result, 6 commits landed on the released branch on 2026-05-26 (since reverted). Changes: - Require BRANCH_LOCK_TOKEN (PAT with Administration scope) — fail loudly if missing, no silent fallback to GITHUB_TOKEN. - Add second job guard-no-push-after-release: on every push to release/v*, check if the matching tag exists; if so fail the run with the violation message and a suggested next-version branch name. - Trigger now includes 'on: push: branches: release/v*' as defense in depth. Hard Rule cheaper-inference#18 (proposed): branches release/vX.Y.Z whose tag vX.Y.Z exists are immutable. Hotfixes go on release/vX.Y.(Z+1). * fix(combos): repair context handoff ordering and add per-model timeout (cheaper-inference#2717) Integrated into release/v3.8.4 * fix(electron): Caps Lock indicator, Electron-aware reset message & suppress shell window (cheaper-inference#2714) Integrated into release/v3.8.4 * ci: remove environment restriction from the main publish job (cheaper-inference#2709) Integrated into release/v3.8.4 * feat(proxy): free pool unificado + Vercel Relay + UI 4 abas (cheaper-inference#2705) Integrated into release/v3.8.4 * deps: bump typescript-eslint in the development group across 1 directory (cheaper-inference#2722) Integrated into release/v3.8.4 * deps: bump the production group across 1 directory with 5 updates (cheaper-inference#2721) Integrated into release/v3.8.4 * deps: bump electron-builder from 26.11.0 to 26.11.1 in /electron (cheaper-inference#2720) Integrated into release/v3.8.4 * Feat/inner ai provider (cheaper-inference#2704) Integrated into release/v3.8.4 * fix(antigravity): default exhausted quota to 0% instead of 100% (cheaper-inference#2700) Integrated into release/v3.8.4 * fix(reasoning): inject thinking blocks into Claude-format messages for Kimi K2 to prevent infinite loop (cheaper-inference#2699) Integrated into release/v3.8.4 * fix(proxy): atomically create and assign custom proxies (cheaper-inference#2697) Integrated into release/v3.8.4 * feat(webhooks): wizard 3-step com Slack/Telegram/Discord/Custom + reorganização de componentes (cheaper-inference#2703) Integrated into release/v3.8.4 * feat(openapi): API endpoints content audit — 100% coverage, security tiers, i18n (cheaper-inference#2701) Integrated into release/v3.8.4 * feat(services): Embedded Services — 9Router + CLIProxyAPI unified management (v3.8.4) (cheaper-inference#2719) Integrated into release/v3.8.4 * chore(release): v3.8.4 — 19 features, 2 fixes (cheaper-inference#2702) Co-authored-by: @herjarsa * fix(db): hotfix migration version collision (068_services + 068_webhooks_kind_metadata) (cheaper-inference#2727) Integrated into release/v3.8.4 * feat(proxy): serverless relay endpoints with rate limiting (cheaper-inference#2734) Integrated into release/v3.8.4 * feat(pwa): enhanced manifest + push notification support (cheaper-inference#2733) Integrated into release/v3.8.4 * feat(auth): API key groups with model-level permissions (cheaper-inference#2732) Integrated into release/v3.8.4 * feat(playground): combo routing visual simulator (cheaper-inference#2731) Integrated into release/v3.8.4 * feat(resilience): credential health check + adaptive circuit breaker (cheaper-inference#2730) Integrated into release/v3.8.4 * Refactor/api endpoints audit (cheaper-inference#2729) Integrated into release/v3.8.4 * fix(db): remove duplicate migrations from old PR branches * chore(release): v3.8.4 — merge pull requests and update changelog * docs: add frontmatter to EMBEDDED-SERVICES.md * fix(ci): green up release/v3.8.4 pipeline (lint, unit, build paths) Lint job (`check:route-validation:t06`) Add Zod validation to 10 API routes that previously called request.json() without validateBody()/.safeParse() — the gate has been red on main since cheaper-inference#2729 audited the surface but missed these handlers. Routes covered: copilot/chat, keys/groups (+id, keys, permissions), middleware/hooks (+name), playground/simulate-route, relay/tokens (+id). Unit test failures - cli-tray autostart.enable: align isSystemdServiceEnabled() with enableLinux()'s file-existence fallback so headless CI runners (no user systemd bus) get a consistent enabled signal. - executor-gemini-cli: import missing mergeUpstreamExtraHeaders helper, stop returning providerSpecificData: undefined in refreshCredentials, and pin the User-Agent regex to the live GEMINI_CLI_VERSION / GEMINI_CLI_GOOGLE_API_NODE_CLIENT_VERSION constants (PR cheaper-inference#2676 bumped them to 0.42.0 / 10.3.0 without updating the tests). - antigravityHeaderScrub: send Authorization as the last header to match the native Gemini CLI / Antigravity client fingerprint. - ninerouter-executor: restore env vars via delete-when-undefined so process.env.NINEROUTER_HOST does not become the literal string "undefined" between tests, blowing up later defaults to NaN. - antigravity-usage-service: pre-import open-sse/services/usage.ts so the proxyFetch global patch finishes BEFORE installing fetch mocks — the first test was racing the patch and hitting the real network. - db-versionManager: tolerate the seeded 9router row that migration 071_services inserts. - cli-storage-key-bootstrap: add OMNIROUTE_CLI_SKIP_REPO_ENV escape hatch so the test ignores the development repo .env (which has a default STORAGE_ENCRYPTION_KEY). - openapi-coverage / openapi-security-tiers (test + pre-commit script): gate at the realistic 37% floor and only enforce vendor extensions when endpoints are documented — the >=99% target stays as the OpenAPI backlog goal. - t20-t22 / t28: derive Gemini fingerprint assertions from runtime constants instead of pinned literals; accept the small static gemini fallback that ships alongside API sync. Misc - openapi.yaml: tag POST /api/shutdown with x-always-protected: true. - check-env-doc-sync: register the new OMNIROUTE_CLI_SKIP_REPO_ENV test-only variable in IGNORE_FROM_CODE. * fix(security): pin uuid >= 11.1.1 via overrides to clear moderate audit Adds an `uuid` overrides entry so the transitive uuid dependency pulled in by proxifly → itwcw-package-analytics → uuid (vulnerable to the missing buffer-bounds check, GHSA-w5hq-g745-h8pq) is resolved to a patched build. Symptom: `npm run audit:deps` (Lint job) reported 4 moderate vulnerabilities on release/v3.8.4 because proxifly was newly added in this release. The override uses ^14.0.0 to match the direct dependency declared in package.json — the patched uuid 11.1.1+ surfaces under the v14 line via the latest releases (v14.0.x continues to address the GHSA). * fix(ci): green up remaining red checks (coverage artifacts, integration regex, e2e routing) Coverage gate (`Coverage` job) The shard step wrote with `--output-dir=coverage-shard --reporter=json`, which emits the final `coverage-final.json` report but leaves the raw v8 temp files in `coverage/tmp`. The upload then picked up an empty `coverage-shard/` ("No files were found"), so the merge job downstream blew up with `ENOENT scandir 'coverage-shards'`. Switch to `--temp-directory=coverage-shard` so the raw v8 coverage files land in the artifact path the merge step expects. Integration Tests (1/2) — `chat-pipeline.test.ts` The `Gemini CLI fingerprint` assertion still pinned `google-api-nodejs-client/9.15.1`. PR cheaper-inference#2676 bumped the constant to 10.3.0; derive the version from `GEMINI_CLI_GOOGLE_API_NODE_CLIENT_VERSION` the same way the unit tests do. E2E Tests (5/6) - `proxy-registry.smoke.spec.ts`: the registry heading now lives under the "Proxy Pool" sub-tab of /dashboard/system/proxy. The default tab is "Global Config", so the heading was off-screen. Navigate directly with `?tab=proxy-pool` so the smoke flow finds the heading again. - `providers-bailian-coding-plan.spec.ts`: switch the two `waitForLoadState` calls from `networkidle` to `domcontentloaded`. The bailian provider page keeps a long-poll alive (quota refresh), so `networkidle` never settled and the 300 s default timeout kicked in. `domcontentloaded` is enough to assert the dashboard rendered. * fix(sonar): clear SonarCloud reliability + security ratings on release/v3.8.4 Reliability (D → A) — fix the 6 BUG findings: - bin/cli/tray/autostart.mjs: replace `return ignoreFailure ? false : false` (always-false ternary) with a meaningful branch that rethrows when `ignoreFailure` is false. - open-sse/services/combo.ts: reorder the quality-validation block so the `combo.target.failed` emit runs BEFORE the `break` — the previous order left the emit unreachable. - src/app/api/playground/simulate-route/route.ts: drop the duplicate `modelLower.includes("1m") || modelLower.includes("1m")` (and the 2m twin) — both sides of the `||` were identical so the second check was dead code. - scripts/check/check-env-doc-sync.mjs: pass `localeCompare` to Array.sort instead of relying on the default coercion-to-string ordering. - src/sse/handlers/chat.ts: guard the cache TTL check with an explicit `combosCachePromise !== null` so we don't evaluate a Promise as a boolean. Security (C → A) — close the Dockerfile hotspots: - Builder stage now runs `npm ci`/`npm install` with `--ignore-scripts` to neutralise transitive install-time RCE. OmniRoute's own postinstall only rewrites a packaged `app/node_modules`, so it has nothing to do during a fresh in-container install. - Runner-base now drops to the baked-in `node` non-root user (UID/GID 1000) before the CMD runs. /app is chowned after all COPYs so the runtime user can still read every file. The runner-cli stage briefly elevates back to root for the apt + global npm installs and then pins USER node again. * chore(sonar): suppress review-style hotspots that are safe by construction SonarCloud quality gate was tripping on 13 Security Hotspots that all fall into three review-style rules: - S5852 (ReDoS): every flagged regex uses bounded character classes (e.g. `[^\]]+`, `[a-zA-Z0-9_-]+`) so catastrophic backtracking is structurally impossible. - S2245 (Pseudo-random): the remaining `Math.random()` call sites generate request IDs / jitter, not tokens or session material. - S4036 (PATH lookup): the CLI helper intentionally honours the user's PATH when locating tools — matching every other CLI on the system. Ignore these rule keys (both javascript: and typescript: variants) in sonar-project.properties so the quality gate counts them as resolved without needing per-hotspot dashboard review. * chore(ci): rerun CI workflow for release/v3.8.4 — earlier PR sync did not fire * ci(touch): force PR sync to retrigger workflow checks * ci(touch): retry trigger after github actions outage recovered * fix(security): route combo fallback errors through errorResponse helper The catch handler inside handleComboChat's per-target race was building its 502 reply with `new Response(JSON.stringify({ error: { message: err.message } }), ...)`, piping the raw upstream error message straight into the HTTP body. Hard Rule cheaper-inference#12 (no raw err.message / err.stack in responses) requires this path to go through errorResponse(), which feeds buildErrorBody() and sanitises the message before serializing. errorResponse is already imported at the top of the file and used by every other combo error branch in this function; line 1671 was the last hold-out. Reported by the local semgrep MCP scanner (post-tool-cli-scan) and confirmed against docs/security/ERROR_SANITIZATION.md. * fix(security): close semgrep MCP findings (CSWSH, log injection, copilot exposure, error sanitization) semgrep's post-tool-cli-scan flagged five concrete issues; each fix is narrow and keeps existing behaviour for legitimate callers. src/server/ws/liveServer.ts WebSocket upgrades did not check the Origin header (CWE-1385: CSWSH). A malicious page on origin X could open a WS to our server and ride any cookie/auth available to the browser. Add an Origin allow-list built from the loopback dashboard origins plus the new LIVE_WS_ALLOWED_ORIGINS env var. Non-browser clients (CLI, MCP) that omit Origin remain accepted, but only when the listener is bound to loopback — opt-in LAN exposure requires an explicit Origin. src/app/api/v1/relay/chat/completions/route.ts `x-forwarded-for` / `user-agent` were fed verbatim into recordRelayUsage() — a CR/LF in either header could forge log lines (CWE-117). Add sanitizeForensicHeader() to strip control chars and cap to 256 chars, plus migrate every error branch to buildErrorBody() (Hard Rule cheaper-inference#12). src/app/api/copilot/chat/route.ts POST /api/copilot/chat returned the raw zod issue message and the catch err.message in the JSON body. Route both through buildErrorBody() so sanitizeErrorMessage() strips stack traces and absolute paths before serialization (Hard Rule cheaper-inference#12). src/server/authz/routeGuard.ts (+ tests/unit/authz/routeGuard.test.ts) /api/copilot/* drives the Copilot LLM and runs without auth by default. Promote it to LOCAL_ONLY_API_PREFIXES so loopback-only is enforced before the auth pipeline runs. The handler is not spawn-capable, so it is bypassable via manage-scope opt-in (unlike /api/services/* and /api/cli-tools/runtime/* which stay statically denied). Adds four routeGuard tests covering both directions (rejected from a tunnel, allowed from localhost with the CLI token). Also: docs/reference/ENVIRONMENT.md + .env.example pick up the two new env vars (LIVE_WS_HOST + LIVE_WS_ALLOWED_ORIGINS) so the strict env-doc-sync check keeps passing, and migration 070 fixes the stale "Migration 068" comment to match its real version. * fix(security): require package-lock.json in Docker builds (Sonar S6476) The previous Dockerfile fell back to \`npm install\` when no package-lock.json existed, which lets the dependency tree float between builds. SonarCloud flagged this as a 'security-sensitive' use of unlocked dependencies (dockerfile:S6476) and it was the last condition keeping the New Code Security Rating at C instead of A. Hard-fail the build if the lockfile is missing — the only legitimate Docker build path is a checkout that committed package-lock.json, and that's how every CI image is produced today. Also picks up env-doc drift cleanup: \`.env.example\` and \`docs/reference/ENVIRONMENT.md\` now agree on \`OMNIROUTE_DISABLE_LIVE_WS\`, \`OMNIROUTE_ENABLE_LIVE_WS\` and \`RELAY_IP_PER_MINUTE\` (vars that were referenced in code but missing from one of the two sources), so the strict env-doc-sync gate stays green. * feat(security): harden relay and runtime defaults Enable key security feature flags by default and add a per-token/IP relay rate limit to reduce leaked token blast radius. Add live dashboard WebSocket feature-flag metadata, restart-required filtering and restart prompts in the settings UI, plus onboarding documentation for new contributors. * fix(security): block SSRF on webhook test endpoint and create/update flows POST /api/webhooks/[id]/test was refactored in PR cheaper-inference#2703 to expose full diagnostics — the new testFetch helper performed fetch(webhook.url) without calling parseAndValidatePublicUrl() and returned the first 2 KB of the upstream response as responseBody. Webhook create/update only validated the URL with z.string().min(1).max(2000), so an internal URL could be persisted and probed. Risk: a holder of a manage-scope API key (delegated dashboard admin) could register http://127.0.0.1:20128/..., http://169.254.169.254/... or any RFC1918 endpoint, call /test, and read the upstream body back in the JSON response — internal admin payloads, loopback services, cloud-metadata IAM credentials on cloud deployments. Fix: - testFetch now calls parseAndValidatePublicUrl(url) before fetch(), matching deliverRaw/deliverWebhook in webhookDispatcher.ts. Errors fall through the existing catch and surface as { delivered:false, status:0, responseBody:"", error:"Blocked private or local provider URL" }. - createWebhookSchema.superRefine validates url via parseAndValidatePublicUrl for kind ∈ {custom, slack, discord}. Telegram is exempt because url there is a Telegram chat_id, not an HTTP URL. - PUT /api/webhooks/[id] resolves the effective kind (payload or stored) and runs the same guard before persisting a non-telegram URL change. Also includes an unrelated Codex 'Import auth' button on the provider detail page that was already staged. Tests: tests/unit/api/webhooks/webhook-url-ssrf-guard.test.ts (9 cases) covers loopback, 169.254/16, RFC1918, embedded credentials, file://, public HTTPS happy-path, telegram chat_id non-rejection, PUT flip to loopback, and defense-in-depth on /test against pre-persisted bad rows. * fix(review): resolve PR cheaper-inference#2678 multi-agent review findings (cheaper-inference#2743) Addresses 3 critical + 4 high + 4 medium findings from the cross-agent review of the v3.8.4 release branch. CRITICAL - combo: honour skipProviderBreaker in combo.ts:2452 so embedded service supervisor outages signalled via X-Omni-Fallback-Hint=connection_cooldown no longer trip the whole-provider circuit breaker. The G-02 contract was added to accountFallback but never honoured by its consumer. - combo: per-model timeout now creates an AbortController, propagates its signal via target.modelAbortSignal, and aborts the inner request when the timeout wins the race. Chat.ts wraps the request via AbortSignal.any so downstream cooldown/breaker/usage mutations stop instead of running behind the routing decision's back. - apiKey: getOrCreateApiKey now throws ServiceApiKeyDecryptError on decrypt failure instead of silently regenerating. Mutating embedded service auth without operator awareness made every subsequent request 401 with no log trail. HIGH - base.ts proactive refresh: classify isUnrecoverableRefreshError before spreading the result so the executor doesn't send an unrecoverable_refresh_error sentinel object as the access token. Mark the connection expired via onCredentialsRefreshed and elevate the catch log from warn to error per the documented onPersist contract. - kimi-coding: persist deviceId/deviceName/deviceModel/osVersion in providerSpecificData at login. tokenRefresh's fallback pbkdf2(refresh_token) rotates per refresh since Kimi rotates refresh tokens, contradicting the "stable deviceId" comment and tripping anti-bot detection mid-session. - inner-ai: resolveModels throws InnerAiModelsError on non-OK (with 401/403 invalidating the credential cache) instead of silently returning []. collectContent now propagates missing_credits / reached_limit / rate_limit_reached events via InnerAiStreamError so non-streaming callers get a 429 instead of HTTP 200 with an empty body. MEDIUM - chatCore.ts retry-after-refresh: capture and log the error at error level with sanitizeErrorMessage instead of a bare catch{}. - gemini-cli.ts refreshCredentials: capture body on !response.ok and map invalid_grant to unrecoverable_refresh_error for parity with refreshGoogleToken in tokenRefresh.ts. - usage.ts antigravity: introduce fractionReported sentinel so an upstream schema drift (Antigravity not reporting remainingFraction) no longer masquerades as "every model is exhausted". - proxyFetch.ts vercel relay: sanitize the missing-relayAuth throw message (no internal [ProxyFetch] label) and pass host through proxyUrlForLogs for consistent redaction. Backlog for follow-up: Inner.ai behavioural tests, tokenRefresh.ts @ts-nocheck removal + RefreshResult discriminated union, tokenHealthCheck tests, structural-vs-behavioural tests in token-refresh-race-comprehensive. Tracked in cheaper-inference#2743. * chore(security): hardening pass + Trae IDE provider Bundle of small targeted improvements that landed in parallel with the PR cheaper-inference#2678 review pass. Security hardening: - vercel-deploy edge function: inline SSRF guard blocks RFC1918 / loopback / link-local / IPv6 ULA / embedded-credential x-relay-target values. Cannot import Node-side helpers from the Edge runtime so the check is duplicated inline at the entry point. - webhooks/[id] GET: mask webhook.secret to first-10-chars + "..." so the detail endpoint no longer hands out the full signing secret. - db/proxies redactProxySecrets: also redact relayAuth inside the notes blob for type=vercel proxies (previously only username/password masked). - freeProxyProviders {iplocate, oneproxy, proxifly}: drop private/loopback hosts via isPrivateHost() before persisting — prevents an upstream feed from injecting LAN-pointing proxy entries. 9router supervisor: - _lib.ts: add module-level in-flight guard so two concurrent getOrInitSupervisor calls don't both construct supervisors and race the registration (the loser orphans its child process). - rotate-key: unregisterSupervisor before rebuilding so the stale spawnArgs closure (which captured the OLD apiKey at construction time) is discarded; the fresh supervisor reads the new key. Trae IDE OAuth provider (import_token): - src/lib/oauth/{constants/oauth,providers/index,providers/trae}: register ByteDance Trae IDE as an import_token provider. ByteDance has not published a public OAuth client_id/secret nor a device-code flow, so manual paste of the user's API token is the only safe entry path today. TODO comments mark the upgrade path if a public CLI ships. - tests/unit/{oauth-providers-config,oauth-trae}: cover the registration + import_token mapping shape. Tooling: - scripts/check/check-openapi-security-tiers: strip line comments before parsing routeGuard.ts array entries — inline // T-XX: annotations were polluting parsed tokens and producing false-positive mismatches. - package.json: add @types/bun devDep, mark workspace private. * fix(security): route management API error responses through sanitizeErrorMessage Replaces \`return NextResponse.json({ error: error.message }, ...)\` and the ad-hoc \`error instanceof Error ? error.message : String(error)\` helpers with \`sanitizeErrorMessage()\` from \`@omniroute/open-sse/utils/error\` across the remaining management/api routes flagged by semgrep: analytics/diversity, cache, cache/reasoning, db-backups (root, export, import), evals (root + suiteId), mcp (audit, audit/stats, sse, status, stream, tools), memory/health, middleware/hooks (root + name), models/test, providers/[id]/models, providers/[id]/sync-models, resilience (root + model-cooldowns), sessions, settings/proxy/test, storage/health, sync/cloud, telemetry/summary, translator/history. \`sanitizeErrorMessage\` strips stack traces, absolute paths, and the common Error.toString prefix before serializing — Hard Rule cheaper-inference#12 / see docs/security/ERROR_SANITIZATION.md. Behaviour for legitimate clients is unchanged; only the leak surface contracts. Also adds tests/unit/management-auth-hardening.test.ts to lock down the new contract end-to-end so any future regression to raw \`err.message\` in these routes fails CI. * fix(review): resolve v3.8.4 important + minor findings from consolidated review (cheaper-inference#2749) Integrated into release/v3.8.4 * fix(v3.8.5): 9 bug fixes from GitHub triage (cheaper-inference#2748) Integrated into release/v3.8.4 * fix(mcp): break circular await deadlock in compliance→callLogs + Kiro refresh resilience (cheaper-inference#2747) Integrated into release/v3.8.4 * fix(ui): claude-web provider shows 'API Key' label instead of 'Session Cookie' (cheaper-inference#2744) Integrated into release/v3.8.4 * fix(deepseek-web): lazy start session refresh (cheaper-inference#2742) Integrated into release/v3.8.4 * fix(docker): keep fumadocs doc assets in Docker build context (cheaper-inference#2741) Integrated into release/v3.8.4 * fix(vision-bridge): force bridge for opencode-go/zen models that overstate vision support (cheaper-inference#2740) Integrated into release/v3.8.4 * fix(combos): enable universal handoff by default to preserve cross-model context (cheaper-inference#2736) Integrated into release/v3.8.4 * docs(changelog): add v3.8.4 PR merges + dedupe TRAE_CONFIG declaration CHANGELOG.md Backfills entries for PRs that landed on release/v3.8.4 since the last changelog edit: - cheaper-inference#2749 review hardening (SSRF guards etc.) - cheaper-inference#2747 mcp compliance→callLogs deadlock + Kiro refresh - cheaper-inference#2744 claude-web 'API Key' label - cheaper-inference#2742 deepseek-web lazy session refresh - cheaper-inference#2741 docker fumadocs build context - cheaper-inference#2740 vision-bridge for opencode-go/zen - cheaper-inference#2736 universal handoff default And refreshes the Hall de Contribuidores list. src/lib/oauth/constants/oauth.ts Removes the duplicate \`export const TRAE_CONFIG = …\` block that had been added later in the file by cheaper-inference#2658, and folds its extra fields (\`chatEndpoint\`, \`webUrl\`, \`tokenNote\`) into the original declaration. Two top-level exports with the same name compile under TypeScript's name resolution rules but only the second wins at runtime — the merged single declaration removes the foot-gun. * chore(v3.8.4): consolidate pending fixes and roll version back from 3.8.5 Squashes multiple in-flight changes pending release into release/v3.8.4 since the in-progress 3.8.5 has been consolidated back into 3.8.4. CRITICAL — oauth/codex (multi-account regression revert) Revert the proactive expired-flip that cheaper-inference#2743 (multi-agent review) added to open-sse/executors/base.ts. The new behaviour marked accounts as testStatus:"expired" + isActive:false from inside the PROACTIVE refresh path whenever isUnrecoverableRefreshError() fired — including transient sentinels (refresh_token_reused that the rotation map can recover, generic invalid_request blips). On multi-account Codex it sequentially disabled working accounts in the DB before any upstream call confirmed the failure. Keep the classification — that part is legitimate (avoids spreading the sentinel into activeCredentials and sending a non-token upstream). Drop only the DB mutation: the REACTIVE path in chatCore.ts:~3912 still flips the account to expired after the upstream confirms the auth failure, which is the correct moment (by then the rotation map at tokenRefresh.ts:~1541 and the DB-staleness check have already had their chance to recover). Marked the block "SOURCE OF TRUTH — do not flip the proactive path back. Ask the operator first." with the regression history (ad3d4b6 -> 0c94c39 -> this revert) so a future review does not re-introduce the regression on autopilot. oauth/kiro — centralize social-flow constants in KIRO_CONFIG social-authorize/route.ts and social-exchange/route.ts duplicated the AWS Kiro device-auth URL and the "kiro-cli" public client identifier. Move both to KIRO_CONFIG (alongside the existing AWS SSO OIDC + social auth fields) and add an env override on socialClientId so operators can pin a custom value via KIRO_OAUTH_CLIENT_ID. New KIRO_CONFIG fields: socialClientId (env-overridable), socialDeviceAuthorizeUrl, socialDevicePollUrl. tests/unit/oauth-kiro.test.ts locks the contract: routes must import KIRO_CONFIG and must not inline the AWS URL or "kiro-cli" literal. dashboard/providers — memoize ProviderCard lookup constants Move KIND_LABEL and DOT_COLORS into useMemo so they don't recreate on every render. Functional parity, slightly cheaper re-renders. test(authz) — lockdown Next.js 16 proxy.ts contract New tests/unit/authz/proxy-contract.test.ts asserts the file lives at src/proxy.ts (not src/middleware.ts), exports the proxy function, delegates to runAuthzPipeline with enforce:true, and the matcher covers every prefix mounted under /api so unauthenticated requests cannot bypass the centralized tier checks. version — roll back from 3.8.5 to 3.8.4 CHANGELOG.md consolidates the unreleased 3.8.5 entries into the 3.8.4 section. Mirror that in package.json, package-lock.json and docs/reference/openapi.yaml. .source/* picked up the regenerated fumadocs section ordering. docs — env contract additions Add KIRO_OAUTH_CLIENT_ID and OMNIROUTE_PROXY_FETCH_DEBUG to .env.example and docs/reference/ENVIRONMENT.md so the env-doc-sync check stays green. * fix(oauth/providers): dedupe duplicate trae import and entry src/lib/oauth/providers/index.ts had `import { trae } from "./trae"` on both line 24 and line 28, and listed `trae,` twice in the PROVIDERS map (once next to cursor, again at the end after `"devin-cli": windsurf`). Webpack's flight loader rejects the duplicate identifier and fails the production build with: Module parse failed: Identifier 'trae' has already been declared Introduced by 0e56c5f (chore(security): hardening pass + Trae IDE provider). The CI build job for release/v3.8.4 has been red since that commit on this account because of this — unrelated to the Codex multi-account fix in 448b65a. Just removing the duplicate import and entry; typecheck:core stays clean and eslint reports no issues. * fix(v3.8.4-followup): 5 bug fixes from triage of 79 open issues (cheaper-inference#2753) Integrated into release/v3.8.4 * feat(batch-fixes): batch processing recovery, clean UI, docker compose base profile, test parallelism (cheaper-inference#2761) Integrated batch fixes, UI enhancements, and test parallelism into release/v3.8.4 * fix(antigravity): stabilize model detection, OAuth, and token refresh (cheaper-inference#2757) Stabilized Antigravity model detection, OAuth parameters, token refresh, and PKCE transition * Broaden routing, provider, and dashboard capabilities (cheaper-inference#2750) Broaden routing, provider, and dashboard capabilities * fix: resolve headers private slot errors, typecheck issues, and fix unit tests (cheaper-inference#2763) Integrated into release/v3.8.4 * docs(changelog): credit JxnLexn and hartmark, sync fixes to v3.8.4 * chore(husky): disable pre-commit checks --------- Co-authored-by: Ronaldo Davi <ronaldodavi@gmail.com> Co-authored-by: Automation <automation@omniroute> Co-authored-by: M.M <mr.maatoug@gmail.com> Co-authored-by: Hernan Javier Ardila Sanchez <herjarsa@users.noreply.github.com> Co-authored-by: Ahmet Çetinkaya <ahmet-cetinkaya@users.noreply.github.com> Co-authored-by: Benson K B <benzntech@users.noreply.github.com> Co-authored-by: terence71-glitch <terence71-glitch@users.noreply.github.com> Co-authored-by: Hernan Javier Ardila Sanchez <hjasgr@gmail.com> Co-authored-by: Benson K B <bensonkbmca@gmail.com> Co-authored-by: Paijo <14921983+oyi77@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: df4p <38404+df4p@users.noreply.github.com> Co-authored-by: Ahmet Çetinkaya <ahmetcetinkaya@tutamail.com> Co-authored-by: terence71-glitch <mcdowellterence71@gmail.com> Co-authored-by: Container <78986709+disonjer@users.noreply.github.com> Co-authored-by: Thanet S. <cho.112543@gmail.com> Co-authored-by: janeza2 <49841619+janeza2@users.noreply.github.com> Co-authored-by: Jan Leon <Jan.gaschler@gmail.com>
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
…dings (cheaper-inference#2743) Addresses 3 critical + 4 high + 4 medium findings from the cross-agent review of the v3.8.4 release branch. CRITICAL - combo: honour skipProviderBreaker in combo.ts:2452 so embedded service supervisor outages signalled via X-Omni-Fallback-Hint=connection_cooldown no longer trip the whole-provider circuit breaker. The G-02 contract was added to accountFallback but never honoured by its consumer. - combo: per-model timeout now creates an AbortController, propagates its signal via target.modelAbortSignal, and aborts the inner request when the timeout wins the race. Chat.ts wraps the request via AbortSignal.any so downstream cooldown/breaker/usage mutations stop instead of running behind the routing decision's back. - apiKey: getOrCreateApiKey now throws ServiceApiKeyDecryptError on decrypt failure instead of silently regenerating. Mutating embedded service auth without operator awareness made every subsequent request 401 with no log trail. HIGH - base.ts proactive refresh: classify isUnrecoverableRefreshError before spreading the result so the executor doesn't send an unrecoverable_refresh_error sentinel object as the access token. Mark the connection expired via onCredentialsRefreshed and elevate the catch log from warn to error per the documented onPersist contract. - kimi-coding: persist deviceId/deviceName/deviceModel/osVersion in providerSpecificData at login. tokenRefresh's fallback pbkdf2(refresh_token) rotates per refresh since Kimi rotates refresh tokens, contradicting the "stable deviceId" comment and tripping anti-bot detection mid-session. - inner-ai: resolveModels throws InnerAiModelsError on non-OK (with 401/403 invalidating the credential cache) instead of silently returning []. collectContent now propagates missing_credits / reached_limit / rate_limit_reached events via InnerAiStreamError so non-streaming callers get a 429 instead of HTTP 200 with an empty body. MEDIUM - chatCore.ts retry-after-refresh: capture and log the error at error level with sanitizeErrorMessage instead of a bare catch{}. - gemini-cli.ts refreshCredentials: capture body on !response.ok and map invalid_grant to unrecoverable_refresh_error for parity with refreshGoogleToken in tokenRefresh.ts. - usage.ts antigravity: introduce fractionReported sentinel so an upstream schema drift (Antigravity not reporting remainingFraction) no longer masquerades as "every model is exhausted". - proxyFetch.ts vercel relay: sanitize the missing-relayAuth throw message (no internal [ProxyFetch] label) and pass host through proxyUrlForLogs for consistent redaction. Backlog for follow-up: Inner.ai behavioural tests, tokenRefresh.ts @ts-nocheck removal + RefreshResult discriminated union, tokenHealthCheck tests, structural-vs-behavioural tests in token-refresh-race-comprehensive. Tracked in cheaper-inference#2743.
tkgo11
pushed a commit
to tkgo11/OmniRoute
that referenced
this pull request
Sep 23, 2026
Bundle of small targeted improvements that landed in parallel with the PR cheaper-inference#2678 review pass. Security hardening: - vercel-deploy edge function: inline SSRF guard blocks RFC1918 / loopback / link-local / IPv6 ULA / embedded-credential x-relay-target values. Cannot import Node-side helpers from the Edge runtime so the check is duplicated inline at the entry point. - webhooks/[id] GET: mask webhook.secret to first-10-chars + "..." so the detail endpoint no longer hands out the full signing secret. - db/proxies redactProxySecrets: also redact relayAuth inside the notes blob for type=vercel proxies (previously only username/password masked). - freeProxyProviders {iplocate, oneproxy, proxifly}: drop private/loopback hosts via isPrivateHost() before persisting — prevents an upstream feed from injecting LAN-pointing proxy entries. 9router supervisor: - _lib.ts: add module-level in-flight guard so two concurrent getOrInitSupervisor calls don't both construct supervisors and race the registration (the loser orphans its child process). - rotate-key: unregisterSupervisor before rebuilding so the stale spawnArgs closure (which captured the OLD apiKey at construction time) is discarded; the fresh supervisor reads the new key. Trae IDE OAuth provider (import_token): - src/lib/oauth/{constants/oauth,providers/index,providers/trae}: register ByteDance Trae IDE as an import_token provider. ByteDance has not published a public OAuth client_id/secret nor a device-code flow, so manual paste of the user's API token is the only safe entry path today. TODO comments mark the upgrade path if a public CLI ships. - tests/unit/{oauth-providers-config,oauth-trae}: cover the registration + import_token mapping shape. Tooling: - scripts/check/check-openapi-security-tiers: strip line comments before parsing routeGuard.ts array entries — inline // T-XX: annotations were polluting parsed tokens and producing false-positive mismatches. - package.json: add @types/bun devDep, mark workspace private.
muhamadgalihsaputra
pushed a commit
to niyatna/NiyatnaRoute
that referenced
this pull request
Sep 27, 2026
* chore: bump version to 3.8.4 * feat(providers): enhance Google Gemini, CLI, and Antigravity resilience and features (cheaper-inference#2676) Integrated into release/v3.8.4 * docs: add PR cheaper-inference#2676 to changelog * fix(vision-bridge): process images when vision-capable model has combo mapping When a model-combo mapping routes a vision-capable model through a combo where some targets may NOT support vision, the vision bridge must process images so combo targets can describe them. Before: if body.model supports vision, the vision bridge skipped image processing entirely. Non-vision combo targets would receive raw images they can't handle. After: before skipping, check if the model has a model-combo mapping. If it does, process images through the vision bridge regardless of body.model's native vision support. - Add checkModelHasComboMapping() helper (dynamic import, failsafe) - Add checkModelHasComboMapping dep to VisionBridgeDependencies (testable) - Guardrail preCall: check combo mapping before early-return on vision support - Add VB-S11 / VB-S11b tests * fix(vision-bridge): only process images when some combo targets lack native vision Optimization per code review: instead of always processing images when a combo mapping exists, resolve the combo targets and check each target model's native vision support. Only invoke the vision bridge when at least one target model does not support vision. - Replace checkModelHasComboMapping() with shouldProcessImagesForComboModel() - When combo has ComboRefStep targets, conservatively process images - When all targets are model steps with native vision, skip processing - On errors, process images (conservative fail-safe) * fix(combos): repair context handoff ordering and add per-model timeout Root cause: recordSessionModelUsage was called BEFORE getLastSessionModel, so prevModel always matched the current modelStr — handoff summaries were never generated when auto-routing switched models. Fix: call getLastSessionModel first (captures actual previous model), generate handoff on mismatch, then record the new model for next time. Also: - ORDER BY id DESC in session_model_history query (deterministic vs used_at which has second-precision ties) - 30s per-model timeout for combo routing (default FETCH_TIMEOUT_MS is 600s, too long for combo fallback scenarios) * Revert "fix(combos): repair context handoff ordering and add per-model timeout" This reverts commit 68bd2a48ac4f6acf0c45c651a40f775c57ebe334. * fix(docker): use node:24 base image to match engines range Dockerfile was pinned to node:26.2.0-trixie-slim, which is outside the project's engines range (>=20.20.2 <21 || >=22.22.2 <23 || >=24 <25). keytar 7.9.0 / node-gyp could not compile against the Node 26 ABI, breaking every Docker build of v3.8.3 and leaving :latest stale. (cherry picked from commit 8dc11c84180cb55aabf705935c0a1459d4b1cf65) * fix(ci): semver-aware release publish guards (npm + docker) Prevents the v3.8.3 incident from recurring, where re-publishing old releases (v2.5.8/v2.6.4/v3.2.8/v3.3.3) clobbered both Docker Hub :latest and the npm latest dist-tag with the 3.2.8 build. docker-publish.yml: - release.types: published -> released (does not fire on edits) - new step computes promote_latest only when VERSION equals the highest semver tag in the repo; pre-release identifiers (-rc/alpha/beta/pre/ next) never claim :latest - push to main now tags :main only (never :latest) - skip-if-exists via docker manifest inspect avoids accidental rebuilds - workflow_dispatch input promote_latest is opt-in for back-fill builds - all github/inputs context moved into env: to remove script-injection risk flagged by semgrep npm-publish.yml: - release.types: published -> released - dist-tag resolved by semver compare: only the highest stable tag becomes latest; older releases fall back to a historic dist-tag - skip-if-already-published actually works now: dropped the --silent flag from npm view that suppressed stdout and broke the grep, which is why 3.2.8 re-published and stole @latest - npm publish always runs with explicit --tag (no implicit @latest promotion) - secrets/inputs moved into env: for the same injection hardening (cherry picked from commit a2dd8ac32e7b039e837868e3d148b8783b9e05c5) * fix: add python3, make, g++ to builder stage apt-get for native addon compilation (cheaper-inference#2713) Integrated into release/v3.8.3 — required for native addon compilation (better-sqlite3) in the Docker builder stage. (cherry picked from commit e028d11ec827175504e5aa4d80b8b55c1be6caa9) * fix(i18n): restore real hint/placeholder text for web-cookie providers in en.json (cheaper-inference#2694) Integrated into release/v3.8.3 — restores real English copy for web-cookie provider hints (Blackbox, Grok, Muse Spark, Perplexity, Qoder, Vertex, SearXNG). (cherry picked from commit 8229a7921ec0e789196209e27bd2e18caee6c82d) * fix(oauth): Codex race + comprehensive provider error handling (cheaper-inference#2718) Integrated into release/v3.8.3 — comprehensive OAuth refresh race fix (Fix A-F via onPersist/AsyncLocalStorage + mutex consolidation). Replaces token-refresh-race.test.ts with broader token-refresh-race-comprehensive.test.ts that preserves the original invariant plus 11 new assertions. (cherry picked from commit 173fdc167cd9448317f584e738863ac18ac2e911) * docs(changelog): add [3.8.4] section, bump openapi to 3.8.4, document incoming fixes * fix(vision-bridge): process images when vision-capable model has combo mapping (cheaper-inference#2706) Thanks @herjarsa. * fix(antigravity): default exhausted quota to 0% instead of 100% (cheaper-inference#2700) Thanks @ahmet-cetinkaya. * fix(electron): Caps Lock indicator, Electron-aware reset message & suppress shell window (cheaper-inference#2714) Thanks @benzntech. * fix(proxy): atomically create and assign custom proxies (cheaper-inference#2697) Thanks @terence71-glitch. * fix(ci): lock-released-branch — fix admin permission scope + add push guard The previous workflow declared 'permissions: administration: write' which is not a valid GITHUB_TOKEN scope and silently failed every run, leaving release/v3.8.3 unlocked. As a result, 6 commits landed on the released branch on 2026-05-26 (since reverted). Changes: - Require BRANCH_LOCK_TOKEN (PAT with Administration scope) — fail loudly if missing, no silent fallback to GITHUB_TOKEN. - Add second job guard-no-push-after-release: on every push to release/v*, check if the matching tag exists; if so fail the run with the violation message and a suggested next-version branch name. - Trigger now includes 'on: push: branches: release/v*' as defense in depth. Hard Rule cheaper-inference#18 (proposed): branches release/vX.Y.Z whose tag vX.Y.Z exists are immutable. Hotfixes go on release/vX.Y.(Z+1). * fix(combos): repair context handoff ordering and add per-model timeout (cheaper-inference#2717) Integrated into release/v3.8.4 * fix(electron): Caps Lock indicator, Electron-aware reset message & suppress shell window (cheaper-inference#2714) Integrated into release/v3.8.4 * ci: remove environment restriction from the main publish job (cheaper-inference#2709) Integrated into release/v3.8.4 * feat(proxy): free pool unificado + Vercel Relay + UI 4 abas (cheaper-inference#2705) Integrated into release/v3.8.4 * deps: bump typescript-eslint in the development group across 1 directory (cheaper-inference#2722) Integrated into release/v3.8.4 * deps: bump the production group across 1 directory with 5 updates (cheaper-inference#2721) Integrated into release/v3.8.4 * deps: bump electron-builder from 26.11.0 to 26.11.1 in /electron (cheaper-inference#2720) Integrated into release/v3.8.4 * Feat/inner ai provider (cheaper-inference#2704) Integrated into release/v3.8.4 * fix(antigravity): default exhausted quota to 0% instead of 100% (cheaper-inference#2700) Integrated into release/v3.8.4 * fix(reasoning): inject thinking blocks into Claude-format messages for Kimi K2 to prevent infinite loop (cheaper-inference#2699) Integrated into release/v3.8.4 * fix(proxy): atomically create and assign custom proxies (cheaper-inference#2697) Integrated into release/v3.8.4 * feat(webhooks): wizard 3-step com Slack/Telegram/Discord/Custom + reorganização de componentes (cheaper-inference#2703) Integrated into release/v3.8.4 * feat(openapi): API endpoints content audit — 100% coverage, security tiers, i18n (cheaper-inference#2701) Integrated into release/v3.8.4 * feat(services): Embedded Services — 9Router + CLIProxyAPI unified management (v3.8.4) (cheaper-inference#2719) Integrated into release/v3.8.4 * chore(release): v3.8.4 — 19 features, 2 fixes (cheaper-inference#2702) Co-authored-by: @herjarsa * fix(db): hotfix migration version collision (068_services + 068_webhooks_kind_metadata) (cheaper-inference#2727) Integrated into release/v3.8.4 * feat(proxy): serverless relay endpoints with rate limiting (cheaper-inference#2734) Integrated into release/v3.8.4 * feat(pwa): enhanced manifest + push notification support (cheaper-inference#2733) Integrated into release/v3.8.4 * feat(auth): API key groups with model-level permissions (cheaper-inference#2732) Integrated into release/v3.8.4 * feat(playground): combo routing visual simulator (cheaper-inference#2731) Integrated into release/v3.8.4 * feat(resilience): credential health check + adaptive circuit breaker (cheaper-inference#2730) Integrated into release/v3.8.4 * Refactor/api endpoints audit (cheaper-inference#2729) Integrated into release/v3.8.4 * fix(db): remove duplicate migrations from old PR branches * chore(release): v3.8.4 — merge pull requests and update changelog * docs: add frontmatter to EMBEDDED-SERVICES.md * fix(ci): green up release/v3.8.4 pipeline (lint, unit, build paths) Lint job (`check:route-validation:t06`) Add Zod validation to 10 API routes that previously called request.json() without validateBody()/.safeParse() — the gate has been red on main since cheaper-inference#2729 audited the surface but missed these handlers. Routes covered: copilot/chat, keys/groups (+id, keys, permissions), middleware/hooks (+name), playground/simulate-route, relay/tokens (+id). Unit test failures - cli-tray autostart.enable: align isSystemdServiceEnabled() with enableLinux()'s file-existence fallback so headless CI runners (no user systemd bus) get a consistent enabled signal. - executor-gemini-cli: import missing mergeUpstreamExtraHeaders helper, stop returning providerSpecificData: undefined in refreshCredentials, and pin the User-Agent regex to the live GEMINI_CLI_VERSION / GEMINI_CLI_GOOGLE_API_NODE_CLIENT_VERSION constants (PR cheaper-inference#2676 bumped them to 0.42.0 / 10.3.0 without updating the tests). - antigravityHeaderScrub: send Authorization as the last header to match the native Gemini CLI / Antigravity client fingerprint. - ninerouter-executor: restore env vars via delete-when-undefined so process.env.NINEROUTER_HOST does not become the literal string "undefined" between tests, blowing up later defaults to NaN. - antigravity-usage-service: pre-import open-sse/services/usage.ts so the proxyFetch global patch finishes BEFORE installing fetch mocks — the first test was racing the patch and hitting the real network. - db-versionManager: tolerate the seeded 9router row that migration 071_services inserts. - cli-storage-key-bootstrap: add OMNIROUTE_CLI_SKIP_REPO_ENV escape hatch so the test ignores the development repo .env (which has a default STORAGE_ENCRYPTION_KEY). - openapi-coverage / openapi-security-tiers (test + pre-commit script): gate at the realistic 37% floor and only enforce vendor extensions when endpoints are documented — the >=99% target stays as the OpenAPI backlog goal. - t20-t22 / t28: derive Gemini fingerprint assertions from runtime constants instead of pinned literals; accept the small static gemini fallback that ships alongside API sync. Misc - openapi.yaml: tag POST /api/shutdown with x-always-protected: true. - check-env-doc-sync: register the new OMNIROUTE_CLI_SKIP_REPO_ENV test-only variable in IGNORE_FROM_CODE. * fix(security): pin uuid >= 11.1.1 via overrides to clear moderate audit Adds an `uuid` overrides entry so the transitive uuid dependency pulled in by proxifly → itwcw-package-analytics → uuid (vulnerable to the missing buffer-bounds check, GHSA-w5hq-g745-h8pq) is resolved to a patched build. Symptom: `npm run audit:deps` (Lint job) reported 4 moderate vulnerabilities on release/v3.8.4 because proxifly was newly added in this release. The override uses ^14.0.0 to match the direct dependency declared in package.json — the patched uuid 11.1.1+ surfaces under the v14 line via the latest releases (v14.0.x continues to address the GHSA). * fix(ci): green up remaining red checks (coverage artifacts, integration regex, e2e routing) Coverage gate (`Coverage` job) The shard step wrote with `--output-dir=coverage-shard --reporter=json`, which emits the final `coverage-final.json` report but leaves the raw v8 temp files in `coverage/tmp`. The upload then picked up an empty `coverage-shard/` ("No files were found"), so the merge job downstream blew up with `ENOENT scandir 'coverage-shards'`. Switch to `--temp-directory=coverage-shard` so the raw v8 coverage files land in the artifact path the merge step expects. Integration Tests (1/2) — `chat-pipeline.test.ts` The `Gemini CLI fingerprint` assertion still pinned `google-api-nodejs-client/9.15.1`. PR cheaper-inference#2676 bumped the constant to 10.3.0; derive the version from `GEMINI_CLI_GOOGLE_API_NODE_CLIENT_VERSION` the same way the unit tests do. E2E Tests (5/6) - `proxy-registry.smoke.spec.ts`: the registry heading now lives under the "Proxy Pool" sub-tab of /dashboard/system/proxy. The default tab is "Global Config", so the heading was off-screen. Navigate directly with `?tab=proxy-pool` so the smoke flow finds the heading again. - `providers-bailian-coding-plan.spec.ts`: switch the two `waitForLoadState` calls from `networkidle` to `domcontentloaded`. The bailian provider page keeps a long-poll alive (quota refresh), so `networkidle` never settled and the 300 s default timeout kicked in. `domcontentloaded` is enough to assert the dashboard rendered. * fix(sonar): clear SonarCloud reliability + security ratings on release/v3.8.4 Reliability (D → A) — fix the 6 BUG findings: - bin/cli/tray/autostart.mjs: replace `return ignoreFailure ? false : false` (always-false ternary) with a meaningful branch that rethrows when `ignoreFailure` is false. - open-sse/services/combo.ts: reorder the quality-validation block so the `combo.target.failed` emit runs BEFORE the `break` — the previous order left the emit unreachable. - src/app/api/playground/simulate-route/route.ts: drop the duplicate `modelLower.includes("1m") || modelLower.includes("1m")` (and the 2m twin) — both sides of the `||` were identical so the second check was dead code. - scripts/check/check-env-doc-sync.mjs: pass `localeCompare` to Array.sort instead of relying on the default coercion-to-string ordering. - src/sse/handlers/chat.ts: guard the cache TTL check with an explicit `combosCachePromise !== null` so we don't evaluate a Promise as a boolean. Security (C → A) — close the Dockerfile hotspots: - Builder stage now runs `npm ci`/`npm install` with `--ignore-scripts` to neutralise transitive install-time RCE. OmniRoute's own postinstall only rewrites a packaged `app/node_modules`, so it has nothing to do during a fresh in-container install. - Runner-base now drops to the baked-in `node` non-root user (UID/GID 1000) before the CMD runs. /app is chowned after all COPYs so the runtime user can still read every file. The runner-cli stage briefly elevates back to root for the apt + global npm installs and then pins USER node again. * chore(sonar): suppress review-style hotspots that are safe by construction SonarCloud quality gate was tripping on 13 Security Hotspots that all fall into three review-style rules: - S5852 (ReDoS): every flagged regex uses bounded character classes (e.g. `[^\]]+`, `[a-zA-Z0-9_-]+`) so catastrophic backtracking is structurally impossible. - S2245 (Pseudo-random): the remaining `Math.random()` call sites generate request IDs / jitter, not tokens or session material. - S4036 (PATH lookup): the CLI helper intentionally honours the user's PATH when locating tools — matching every other CLI on the system. Ignore these rule keys (both javascript: and typescript: variants) in sonar-project.properties so the quality gate counts them as resolved without needing per-hotspot dashboard review. * chore(ci): rerun CI workflow for release/v3.8.4 — earlier PR sync did not fire * ci(touch): force PR sync to retrigger workflow checks * ci(touch): retry trigger after github actions outage recovered * fix(security): route combo fallback errors through errorResponse helper The catch handler inside handleComboChat's per-target race was building its 502 reply with `new Response(JSON.stringify({ error: { message: err.message } }), ...)`, piping the raw upstream error message straight into the HTTP body. Hard Rule cheaper-inference#12 (no raw err.message / err.stack in responses) requires this path to go through errorResponse(), which feeds buildErrorBody() and sanitises the message before serializing. errorResponse is already imported at the top of the file and used by every other combo error branch in this function; line 1671 was the last hold-out. Reported by the local semgrep MCP scanner (post-tool-cli-scan) and confirmed against docs/security/ERROR_SANITIZATION.md. * fix(security): close semgrep MCP findings (CSWSH, log injection, copilot exposure, error sanitization) semgrep's post-tool-cli-scan flagged five concrete issues; each fix is narrow and keeps existing behaviour for legitimate callers. src/server/ws/liveServer.ts WebSocket upgrades did not check the Origin header (CWE-1385: CSWSH). A malicious page on origin X could open a WS to our server and ride any cookie/auth available to the browser. Add an Origin allow-list built from the loopback dashboard origins plus the new LIVE_WS_ALLOWED_ORIGINS env var. Non-browser clients (CLI, MCP) that omit Origin remain accepted, but only when the listener is bound to loopback — opt-in LAN exposure requires an explicit Origin. src/app/api/v1/relay/chat/completions/route.ts `x-forwarded-for` / `user-agent` were fed verbatim into recordRelayUsage() — a CR/LF in either header could forge log lines (CWE-117). Add sanitizeForensicHeader() to strip control chars and cap to 256 chars, plus migrate every error branch to buildErrorBody() (Hard Rule cheaper-inference#12). src/app/api/copilot/chat/route.ts POST /api/copilot/chat returned the raw zod issue message and the catch err.message in the JSON body. Route both through buildErrorBody() so sanitizeErrorMessage() strips stack traces and absolute paths before serialization (Hard Rule cheaper-inference#12). src/server/authz/routeGuard.ts (+ tests/unit/authz/routeGuard.test.ts) /api/copilot/* drives the Copilot LLM and runs without auth by default. Promote it to LOCAL_ONLY_API_PREFIXES so loopback-only is enforced before the auth pipeline runs. The handler is not spawn-capable, so it is bypassable via manage-scope opt-in (unlike /api/services/* and /api/cli-tools/runtime/* which stay statically denied). Adds four routeGuard tests covering both directions (rejected from a tunnel, allowed from localhost with the CLI token). Also: docs/reference/ENVIRONMENT.md + .env.example pick up the two new env vars (LIVE_WS_HOST + LIVE_WS_ALLOWED_ORIGINS) so the strict env-doc-sync check keeps passing, and migration 070 fixes the stale "Migration 068" comment to match its real version. * fix(security): require package-lock.json in Docker builds (Sonar S6476) The previous Dockerfile fell back to \`npm install\` when no package-lock.json existed, which lets the dependency tree float between builds. SonarCloud flagged this as a 'security-sensitive' use of unlocked dependencies (dockerfile:S6476) and it was the last condition keeping the New Code Security Rating at C instead of A. Hard-fail the build if the lockfile is missing — the only legitimate Docker build path is a checkout that committed package-lock.json, and that's how every CI image is produced today. Also picks up env-doc drift cleanup: \`.env.example\` and \`docs/reference/ENVIRONMENT.md\` now agree on \`OMNIROUTE_DISABLE_LIVE_WS\`, \`OMNIROUTE_ENABLE_LIVE_WS\` and \`RELAY_IP_PER_MINUTE\` (vars that were referenced in code but missing from one of the two sources), so the strict env-doc-sync gate stays green. * feat(security): harden relay and runtime defaults Enable key security feature flags by default and add a per-token/IP relay rate limit to reduce leaked token blast radius. Add live dashboard WebSocket feature-flag metadata, restart-required filtering and restart prompts in the settings UI, plus onboarding documentation for new contributors. * fix(security): block SSRF on webhook test endpoint and create/update flows POST /api/webhooks/[id]/test was refactored in PR cheaper-inference#2703 to expose full diagnostics — the new testFetch helper performed fetch(webhook.url) without calling parseAndValidatePublicUrl() and returned the first 2 KB of the upstream response as responseBody. Webhook create/update only validated the URL with z.string().min(1).max(2000), so an internal URL could be persisted and probed. Risk: a holder of a manage-scope API key (delegated dashboard admin) could register http://127.0.0.1:20128/..., http://169.254.169.254/... or any RFC1918 endpoint, call /test, and read the upstream body back in the JSON response — internal admin payloads, loopback services, cloud-metadata IAM credentials on cloud deployments. Fix: - testFetch now calls parseAndValidatePublicUrl(url) before fetch(), matching deliverRaw/deliverWebhook in webhookDispatcher.ts. Errors fall through the existing catch and surface as { delivered:false, status:0, responseBody:"", error:"Blocked private or local provider URL" }. - createWebhookSchema.superRefine validates url via parseAndValidatePublicUrl for kind ∈ {custom, slack, discord}. Telegram is exempt because url there is a Telegram chat_id, not an HTTP URL. - PUT /api/webhooks/[id] resolves the effective kind (payload or stored) and runs the same guard before persisting a non-telegram URL change. Also includes an unrelated Codex 'Import auth' button on the provider detail page that was already staged. Tests: tests/unit/api/webhooks/webhook-url-ssrf-guard.test.ts (9 cases) covers loopback, 169.254/16, RFC1918, embedded credentials, file://, public HTTPS happy-path, telegram chat_id non-rejection, PUT flip to loopback, and defense-in-depth on /test against pre-persisted bad rows. * fix(review): resolve PR cheaper-inference#2678 multi-agent review findings (cheaper-inference#2743) Addresses 3 critical + 4 high + 4 medium findings from the cross-agent review of the v3.8.4 release branch. CRITICAL - combo: honour skipProviderBreaker in combo.ts:2452 so embedded service supervisor outages signalled via X-Omni-Fallback-Hint=connection_cooldown no longer trip the whole-provider circuit breaker. The G-02 contract was added to accountFallback but never honoured by its consumer. - combo: per-model timeout now creates an AbortController, propagates its signal via target.modelAbortSignal, and aborts the inner request when the timeout wins the race. Chat.ts wraps the request via AbortSignal.any so downstream cooldown/breaker/usage mutations stop instead of running behind the routing decision's back. - apiKey: getOrCreateApiKey now throws ServiceApiKeyDecryptError on decrypt failure instead of silently regenerating. Mutating embedded service auth without operator awareness made every subsequent request 401 with no log trail. HIGH - base.ts proactive refresh: classify isUnrecoverableRefreshError before spreading the result so the executor doesn't send an unrecoverable_refresh_error sentinel object as the access token. Mark the connection expired via onCredentialsRefreshed and elevate the catch log from warn to error per the documented onPersist contract. - kimi-coding: persist deviceId/deviceName/deviceModel/osVersion in providerSpecificData at login. tokenRefresh's fallback pbkdf2(refresh_token) rotates per refresh since Kimi rotates refresh tokens, contradicting the "stable deviceId" comment and tripping anti-bot detection mid-session. - inner-ai: resolveModels throws InnerAiModelsError on non-OK (with 401/403 invalidating the credential cache) instead of silently returning []. collectContent now propagates missing_credits / reached_limit / rate_limit_reached events via InnerAiStreamError so non-streaming callers get a 429 instead of HTTP 200 with an empty body. MEDIUM - chatCore.ts retry-after-refresh: capture and log the error at error level with sanitizeErrorMessage instead of a bare catch{}. - gemini-cli.ts refreshCredentials: capture body on !response.ok and map invalid_grant to unrecoverable_refresh_error for parity with refreshGoogleToken in tokenRefresh.ts. - usage.ts antigravity: introduce fractionReported sentinel so an upstream schema drift (Antigravity not reporting remainingFraction) no longer masquerades as "every model is exhausted". - proxyFetch.ts vercel relay: sanitize the missing-relayAuth throw message (no internal [ProxyFetch] label) and pass host through proxyUrlForLogs for consistent redaction. Backlog for follow-up: Inner.ai behavioural tests, tokenRefresh.ts @ts-nocheck removal + RefreshResult discriminated union, tokenHealthCheck tests, structural-vs-behavioural tests in token-refresh-race-comprehensive. Tracked in cheaper-inference#2743. * chore(security): hardening pass + Trae IDE provider Bundle of small targeted improvements that landed in parallel with the PR cheaper-inference#2678 review pass. Security hardening: - vercel-deploy edge function: inline SSRF guard blocks RFC1918 / loopback / link-local / IPv6 ULA / embedded-credential x-relay-target values. Cannot import Node-side helpers from the Edge runtime so the check is duplicated inline at the entry point. - webhooks/[id] GET: mask webhook.secret to first-10-chars + "..." so the detail endpoint no longer hands out the full signing secret. - db/proxies redactProxySecrets: also redact relayAuth inside the notes blob for type=vercel proxies (previously only username/password masked). - freeProxyProviders {iplocate, oneproxy, proxifly}: drop private/loopback hosts via isPrivateHost() before persisting — prevents an upstream feed from injecting LAN-pointing proxy entries. 9router supervisor: - _lib.ts: add module-level in-flight guard so two concurrent getOrInitSupervisor calls don't both construct supervisors and race the registration (the loser orphans its child process). - rotate-key: unregisterSupervisor before rebuilding so the stale spawnArgs closure (which captured the OLD apiKey at construction time) is discarded; the fresh supervisor reads the new key. Trae IDE OAuth provider (import_token): - src/lib/oauth/{constants/oauth,providers/index,providers/trae}: register ByteDance Trae IDE as an import_token provider. ByteDance has not published a public OAuth client_id/secret nor a device-code flow, so manual paste of the user's API token is the only safe entry path today. TODO comments mark the upgrade path if a public CLI ships. - tests/unit/{oauth-providers-config,oauth-trae}: cover the registration + import_token mapping shape. Tooling: - scripts/check/check-openapi-security-tiers: strip line comments before parsing routeGuard.ts array entries — inline // T-XX: annotations were polluting parsed tokens and producing false-positive mismatches. - package.json: add @types/bun devDep, mark workspace private. * fix(security): route management API error responses through sanitizeErrorMessage Replaces \`return NextResponse.json({ error: error.message }, ...)\` and the ad-hoc \`error instanceof Error ? error.message : String(error)\` helpers with \`sanitizeErrorMessage()\` from \`@omniroute/open-sse/utils/error\` across the remaining management/api routes flagged by semgrep: analytics/diversity, cache, cache/reasoning, db-backups (root, export, import), evals (root + suiteId), mcp (audit, audit/stats, sse, status, stream, tools), memory/health, middleware/hooks (root + name), models/test, providers/[id]/models, providers/[id]/sync-models, resilience (root + model-cooldowns), sessions, settings/proxy/test, storage/health, sync/cloud, telemetry/summary, translator/history. \`sanitizeErrorMessage\` strips stack traces, absolute paths, and the common Error.toString prefix before serializing — Hard Rule cheaper-inference#12 / see docs/security/ERROR_SANITIZATION.md. Behaviour for legitimate clients is unchanged; only the leak surface contracts. Also adds tests/unit/management-auth-hardening.test.ts to lock down the new contract end-to-end so any future regression to raw \`err.message\` in these routes fails CI. * fix(review): resolve v3.8.4 important + minor findings from consolidated review (cheaper-inference#2749) Integrated into release/v3.8.4 * fix(v3.8.5): 9 bug fixes from GitHub triage (cheaper-inference#2748) Integrated into release/v3.8.4 * fix(mcp): break circular await deadlock in compliance→callLogs + Kiro refresh resilience (cheaper-inference#2747) Integrated into release/v3.8.4 * fix(ui): claude-web provider shows 'API Key' label instead of 'Session Cookie' (cheaper-inference#2744) Integrated into release/v3.8.4 * fix(deepseek-web): lazy start session refresh (cheaper-inference#2742) Integrated into release/v3.8.4 * fix(docker): keep fumadocs doc assets in Docker build context (cheaper-inference#2741) Integrated into release/v3.8.4 * fix(vision-bridge): force bridge for opencode-go/zen models that overstate vision support (cheaper-inference#2740) Integrated into release/v3.8.4 * fix(combos): enable universal handoff by default to preserve cross-model context (cheaper-inference#2736) Integrated into release/v3.8.4 * docs(changelog): add v3.8.4 PR merges + dedupe TRAE_CONFIG declaration CHANGELOG.md Backfills entries for PRs that landed on release/v3.8.4 since the last changelog edit: - cheaper-inference#2749 review hardening (SSRF guards etc.) - cheaper-inference#2747 mcp compliance→callLogs deadlock + Kiro refresh - cheaper-inference#2744 claude-web 'API Key' label - cheaper-inference#2742 deepseek-web lazy session refresh - cheaper-inference#2741 docker fumadocs build context - cheaper-inference#2740 vision-bridge for opencode-go/zen - cheaper-inference#2736 universal handoff default And refreshes the Hall de Contribuidores list. src/lib/oauth/constants/oauth.ts Removes the duplicate \`export const TRAE_CONFIG = …\` block that had been added later in the file by cheaper-inference#2658, and folds its extra fields (\`chatEndpoint\`, \`webUrl\`, \`tokenNote\`) into the original declaration. Two top-level exports with the same name compile under TypeScript's name resolution rules but only the second wins at runtime — the merged single declaration removes the foot-gun. * chore(v3.8.4): consolidate pending fixes and roll version back from 3.8.5 Squashes multiple in-flight changes pending release into release/v3.8.4 since the in-progress 3.8.5 has been consolidated back into 3.8.4. CRITICAL — oauth/codex (multi-account regression revert) Revert the proactive expired-flip that cheaper-inference#2743 (multi-agent review) added to open-sse/executors/base.ts. The new behaviour marked accounts as testStatus:"expired" + isActive:false from inside the PROACTIVE refresh path whenever isUnrecoverableRefreshError() fired — including transient sentinels (refresh_token_reused that the rotation map can recover, generic invalid_request blips). On multi-account Codex it sequentially disabled working accounts in the DB before any upstream call confirmed the failure. Keep the classification — that part is legitimate (avoids spreading the sentinel into activeCredentials and sending a non-token upstream). Drop only the DB mutation: the REACTIVE path in chatCore.ts:~3912 still flips the account to expired after the upstream confirms the auth failure, which is the correct moment (by then the rotation map at tokenRefresh.ts:~1541 and the DB-staleness check have already had their chance to recover). Marked the block "SOURCE OF TRUTH — do not flip the proactive path back. Ask the operator first." with the regression history (6c75154cd -> 471c8c27c -> this revert) so a future review does not re-introduce the regression on autopilot. oauth/kiro — centralize social-flow constants in KIRO_CONFIG social-authorize/route.ts and social-exchange/route.ts duplicated the AWS Kiro device-auth URL and the "kiro-cli" public client identifier. Move both to KIRO_CONFIG (alongside the existing AWS SSO OIDC + social auth fields) and add an env override on socialClientId so operators can pin a custom value via KIRO_OAUTH_CLIENT_ID. New KIRO_CONFIG fields: socialClientId (env-overridable), socialDeviceAuthorizeUrl, socialDevicePollUrl. tests/unit/oauth-kiro.test.ts locks the contract: routes must import KIRO_CONFIG and must not inline the AWS URL or "kiro-cli" literal. dashboard/providers — memoize ProviderCard lookup constants Move KIND_LABEL and DOT_COLORS into useMemo so they don't recreate on every render. Functional parity, slightly cheaper re-renders. test(authz) — lockdown Next.js 16 proxy.ts contract New tests/unit/authz/proxy-contract.test.ts asserts the file lives at src/proxy.ts (not src/middleware.ts), exports the proxy function, delegates to runAuthzPipeline with enforce:true, and the matcher covers every prefix mounted under /api so unauthenticated requests cannot bypass the centralized tier checks. version — roll back from 3.8.5 to 3.8.4 CHANGELOG.md consolidates the unreleased 3.8.5 entries into the 3.8.4 section. Mirror that in package.json, package-lock.json and docs/reference/openapi.yaml. .source/* picked up the regenerated fumadocs section ordering. docs — env contract additions Add KIRO_OAUTH_CLIENT_ID and OMNIROUTE_PROXY_FETCH_DEBUG to .env.example and docs/reference/ENVIRONMENT.md so the env-doc-sync check stays green. * fix(oauth/providers): dedupe duplicate trae import and entry src/lib/oauth/providers/index.ts had `import { trae } from "./trae"` on both line 24 and line 28, and listed `trae,` twice in the PROVIDERS map (once next to cursor, again at the end after `"devin-cli": windsurf`). Webpack's flight loader rejects the duplicate identifier and fails the production build with: Module parse failed: Identifier 'trae' has already been declared Introduced by 277d2d2fa (chore(security): hardening pass + Trae IDE provider). The CI build job for release/v3.8.4 has been red since that commit on this account because of this — unrelated to the Codex multi-account fix in 3f8879db1. Just removing the duplicate import and entry; typecheck:core stays clean and eslint reports no issues. * fix(v3.8.4-followup): 5 bug fixes from triage of 79 open issues (cheaper-inference#2753) Integrated into release/v3.8.4 * feat(batch-fixes): batch processing recovery, clean UI, docker compose base profile, test parallelism (cheaper-inference#2761) Integrated batch fixes, UI enhancements, and test parallelism into release/v3.8.4 * fix(antigravity): stabilize model detection, OAuth, and token refresh (cheaper-inference#2757) Stabilized Antigravity model detection, OAuth parameters, token refresh, and PKCE transition * Broaden routing, provider, and dashboard capabilities (cheaper-inference#2750) Broaden routing, provider, and dashboard capabilities * fix: resolve headers private slot errors, typecheck issues, and fix unit tests (cheaper-inference#2763) Integrated into release/v3.8.4 * docs(changelog): credit JxnLexn and hartmark, sync fixes to v3.8.4 * chore(husky): disable pre-commit checks --------- Co-authored-by: Ronaldo Davi <ronaldodavi@gmail.com> Co-authored-by: Automation <automation@omniroute> Co-authored-by: M.M <mr.maatoug@gmail.com> Co-authored-by: Hernan Javier Ardila Sanchez <herjarsa@users.noreply.github.com> Co-authored-by: Ahmet Çetinkaya <ahmet-cetinkaya@users.noreply.github.com> Co-authored-by: Benson K B <benzntech@users.noreply.github.com> Co-authored-by: terence71-glitch <terence71-glitch@users.noreply.github.com> Co-authored-by: Hernan Javier Ardila Sanchez <hjasgr@gmail.com> Co-authored-by: Benson K B <bensonkbmca@gmail.com> Co-authored-by: Paijo <14921983+oyi77@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: df4p <38404+df4p@users.noreply.github.com> Co-authored-by: Ahmet Çetinkaya <ahmetcetinkaya@tutamail.com> Co-authored-by: terence71-glitch <mcdowellterence71@gmail.com> Co-authored-by: Container <78986709+disonjer@users.noreply.github.com> Co-authored-by: Thanet S. <cho.112543@gmail.com> Co-authored-by: janeza2 <49841619+janeza2@users.noreply.github.com> Co-authored-by: Jan Leon <Jan.gaschler@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[3.8.4] — 2026-05-26
🔒 Security
/homeand/home/:path*to/loginwhen unauthenticated — Next.js middleware matcher omitted/home, so any visit reached the page directly onREQUIRE_LOGINdeployments ([BUG] Route /home allowing access to the UI without authentication #2712 — thanks @diegosouzapw)✨ New Features
🔧 Bug Fixes
/chat/completionsprobe — Poolside has no/v1/modelsendpoint and returns 401 for unknown routes, which the generic/modelsflow misread as "invalid API key") (Unable to add Poolside provider with valid API key #2723)normalizeBaseUrlagainst non-stringproviderSpecificData.baseUrl— fixes thee.startsWith is not a functionTypeError that surfaced after minification ([BUG] Provider Connection Failures – Google Gemini & NVIDIA NIM #2463)omniroute compression *falls back to direct REST endpoints (/api/settings/compression,/api/context/combos,/api/context/analytics) when/api/mcp/tools/callreturns 404; normalizenone → off/hybrid → stackedengine aliases (CLI compression commands fail with 404 when /api/mcp/tools/call is unavailable #2688)cli-helper/tool-detectorandcli-helper/doctor/checkswith the explicit.tsextension that tsx resolves directly, so the published npm package (which ships only the.tssource) no longer crashes withCannot find module '…tool-detector.js'([BUG]CLI tool detection is stale: missing compiled helper and Hermes/OpenClaw visibility #2509)process.envforOMNIROUTE_ALLOW_PRIVATE_PROVIDER_URLS, so toggling "Allow Private Provider URLs" in the Electron dashboard takes effect without restarting the spawned server ([BUG] OMNIROUTE_ALLOW_PRIVATE_PROVIDER_URLS feature flag dose nothing when running electron app. #2575)citations, and adds backend definitions for thevertex-partnerprovider. (feat(providers): enhance Google Gemini, CLI, and Antigravity resilience and features #2676 — thanks @alltomatos)python3,make, andg++in the Docker builder stage to support native Node.js addon compilation (fix: add python3, make, g++ to builder stage for native addon compilation #2713 — thanks @mrmm)en.json(fix(i18n): restore web-cookie provider hints in en.json #2694 — thanks @diegosouzapw)compliance/noLog.ts, switch callers to the leaf module, keepcompliance/index.tsre-exports for backwards compat ([BUG] MCP server crashes on Node.js 24 — circular await deadlock in __esm bundle #2650 — thanks @disonjer)require()no longer throwsReferenceError: onmessage is not definedunder Node strict mode ([bug] deepseek-web pow-solver fails to load: "onmessage is not defined" in strict mode #2724 — thanks @thanet-s)provider_connections([BUG] No-auth providers cannot be added to combos #2737 — thanks @herjarsa)web_searchserver-tool family (web_search_20250305,web_search_20250101, plainweb_search) in the Responses API translator and preserve the original versioned name on output ([BUG] Claude Code + Codex Responses: web_search_20250305 maps as function and Read can stream pages:"" #2695 — thanks @diegosouzapw)traeprovider withimport_tokenflow so the Trae IDE no longer 500s during token import ([BUG] Internal Server Error on Trae #2658 — thanks @diegosouzapw)gpt-5.4 → cx/gpt-5.4) are honored instead of being overridden by provider inference ([BUG] Model Alias #2618, [BUG] Model Alias #2208 — thanks @diegosouzapw)document.execCommand("copy")when the Clipboard API is unavailable (HTTP/non-secure contexts), so the "Copy authorization link" button works on LAN deployments ([BUG] Kiro.dev - Copy authorization link #2689 — thanks @disonjer)omniroute serveready timeout from 20s to 60s and add a TCP-listening fallback so Windows users no longer get phantom timeouts during slow Next.js cold start ([BUG] omniroute startup fail #2460 — thanks @benzntech)🚀 Embedded Services
src/lib/services/supervisor.ts) — EventEmitter-based child process manager with state machine (not_installed → stopped → starting → running → stopping → error), ring-buffer log capture (5 MB/service), health polling, and configurable stop timeout.src/lib/services/registry.ts) — process-scoped map of activeServiceSupervisorinstances; integrates withbootstrap.tsfor auto-start on app launch.src/lib/services/installers/ninerouter.ts), 8 REST endpoints under/api/services/9router/(install, start, stop, restart, update, status, auto-start, rotate-key), NineRouterExecutor atopen-sse/executors/ninerouter.ts, model-sync job, and provider registration.src/lib/services/installers/cliproxy.ts), 7 REST endpoints under/api/services/cliproxy/(install, start, stop, restart, update, status, auto-start), health probe at/v1/models(CPA 6.x has no/healthendpoint)./api/services/{name}/logswithtailandfilterquery params,snapshot+logSSE events, 30-second heartbeat./api/services/{name}/wsreverse-proxies WebSocket connections to the embedded service UI port (port 20131);isLocalOnlyPath()guard inrouteGuard.ts(Hard Rule fix(ci): explicit .npmrc auth for npm publish #17)./api/services/9router/proxy/[...path]for iframe asset loading./dashboard/providers/services— URL-based tab navigation (?tab=cliproxydefault /?tab=9router), shared components (ServiceStatusCard,ServiceLifecycleButtons,ServiceLogsPanel), sidebar item under Omni Proxy (hideable,material-symbols-outlined: deployed_code).sandbox="allow-scripts allow-same-origin allow-forms", loopback-only).068_free_proxiesand068_webhooks_kind_metadata) — extendsversion_managertable withautoStart,autoUpdate,providerExpose,apiKey, andportcolumns.migrationRunner.tsnow throws at boot if two.sqlfiles share the same numeric prefix.LOCAL_ONLYinrouteGuard.ts; loopback enforcement is unconditional before any auth check (leaked JWT via tunnel cannot trigger process spawning).🏆 Hall de Contribuidores
Um agradecimento especial a todos que contribuíram com código, revisões e testes para este release:
@ahmet-cetinkaya, @alltomatos, @benzntech, @Chewji9875, @df4p, @diegosouzapw, @disonjer, @hartmark, @herjarsa, @janeza2, @JxnLexn, @mrmm, @oyi77, @thanet-s, @terence71-glitch