[herjarsa]

Interactive combo routing simulation:\n- Simulation API at /api/playground/simulate-route\n- Visual cascade UI showing each target hop with status\n- Cost, latency, and context window estimates per target\n- Warnings for misconfigured providers

[gemini-code-assist]

Code Review

This pull request introduces a "Combo Playground" feature, including a React client interface and a simulation API route to visualize routing paths, costs, and latencies. Feedback highlights several critical bugs, such as the use of undefined database functions and incorrect property access on combo objects. The reviewer also noted missing input validation and unit tests, which violate repository style guides. Additional improvements were suggested for error handling in the UI, string localization, and refactoring the brittle model estimation logic.

[gemini-code-assist]

The function getAllCombos is not exported from @/lib/db/combos. Based on the existing database module, you should use getCombos instead.

Suggested change

	import { getAllCombos } from "@/lib/db/combos";
	import { getCombos } from "@/lib/db/combos";

[gemini-code-assist]

Update the function call to getCombos as getAllCombos is not defined in the database module.

Suggested change

	const combos = (await getAllCombos()) as any[];
	const combos = (await getCombos()) as any[];

[gemini-code-assist]

The combo object retrieved from the database uses the property models to store the list of targets, but the code here attempts to access targets. This will likely result in an empty simulation. Please update the property access to combo.models.

[gemini-code-assist]

If the API request fails (e.g., 400 or 500), the returned JSON does not match the SimulateResponse interface (it lacks the targets array). Setting this as the result will cause the component to crash when attempting to map over result.targets at line 191. Handle API errors by using a safe fallback state.

      if (res.ok) {
        setResult(data);
      } else {
        setResult({
          comboName: "Error",
          strategy: "-",
          targets: [],
          totalEstimatedCost: 0,
          totalEstimatedLatencyMs: 0,
          warnings: [],
          errors: [data.error || "Unknown simulation error"],
        });
      }

[gemini-code-assist]

This PR introduces new production logic and API routes but does not include any tests. According to repository rule 9, all changes to production code in src/ must include corresponding tests. Please add unit or integration tests for the simulation logic in the tests/ directory.

References

1. Always include tests when changing production code (src/, open-sse/, electron/, bin/).

[gemini-code-assist]

The estimation logic for cost, latency, and context windows relies on hardcoded string matching against model names. This approach is brittle and will require frequent updates as new models are added. Consider centralizing this metadata or using a structured lookup table/configuration file to improve maintainability.

[gemini-code-assist]

Request body validation is missing. Adhere to the repository style guide (Rule 8) by validating the input using a Zod schema from src/shared/validation/schemas.ts. This ensures type safety and prevents processing of malformed data.

References

1. Always validate inputs with Zod schemas from src/shared/validation/schemas.ts.

[gemini-code-assist]

User-facing strings should not be hardcoded. Use the useTranslations hook from next-intl to manage localized strings, ensuring consistency with the rest of the dashboard.

[kilo-code-bot]

Kilo Code Review could not run — your account is out of credits.

Add credits or switch to a free model to enable reviews on this change.

[diegosouzapw]

Thank you! PR merged.