Skip to content

fix(dark-mode): correct background on Compression Override select in Combos page #2513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
May 21, 2026
Merged

fix(dark-mode): correct background on Compression Override select in Combos page #2513

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/app/(dashboard)/dashboard/combos/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1737,15 +1737,15 @@ function ComboCard({
value={compressionOverride}
onChange={(e) => handleCompressionOverrideChange(e.target.value)}
disabled={isSavingCompression}
className="text-xs py-1 px-2 rounded border border-black/10 dark:border-white/10 bg-white dark:bg-bg-main text-text-main focus:border-primary focus:outline-none transition-colors disabled:opacity-50 max-w-[130px] md:max-w-none"
className="text-xs py-1 px-2 rounded border border-black/10 dark:border-white/10 bg-surface text-text-main focus:border-primary focus:outline-none transition-colors disabled:opacity-50 max-w-[130px] md:max-w-none"

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Repository Style Guide (Rule 9) requires including tests when changing production code in src/. Please add a test case (e.g., using Vitest or Playwright) to verify that the compression override dropdown correctly applies the theme colors in both light and dark modes.

References
  1. Always include tests when changing production code (src/, open-sse/, electron/, bin/). (link)

title={t("compressionOverride")}
>
<option value="">Default</option>
<option value="off">Off</option>
<option value="lite">Lite</option>
<option value="standard">Standard</option>
<option value="aggressive">Aggressive</option>
<option value="ultra">Ultra</option>
<option value="" className="bg-surface text-text-main">Default</option>
<option value="off" className="bg-surface text-text-main">Off</option>
<option value="lite" className="bg-surface text-text-main">Lite</option>
<option value="standard" className="bg-surface text-text-main">Standard</option>
<option value="aggressive" className="bg-surface text-text-main">Aggressive</option>
<option value="ultra" className="bg-surface text-text-main">Ultra</option>
Comment on lines +1740 to +1748

@gemini-code-assist gemini-code-assist Bot May 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Instead of manually styling a native <select> and its <option> elements, consider migrating this control to the shared Select component from src/shared/components/Select.tsx. This would centralize the styling logic, ensure consistency with other parts of the application, and avoid the brittleness of styling native <option> tags, which are often ignored by browsers.

</select>
)}
<button
Expand Down