Repository navigation
alibaba provider consolidation - #2319
diegosouzapw merged 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the Alibaba provider integration, replacing legacy identifiers with alibaba, alibaba-cn, and bailian-coding-plan, and updates associated documentation, icons, and dashboard sorting logic. Feedback identifies critical omissions where the new bailian-coding-plan provider was not added to the necessary registries, which will prevent it from functioning. Additionally, the reviewer noted the potential accidental removal of Voyage AI models, suggested restoring a named constant for model lists to improve maintainability, and requested a formatting correction for the Alibaba China provider name. Per the repository style guide, unit tests must also be added for the new provider to verify its Claude-compatibility.
be24ef1 to
afb1729
Compare
cf3262a
into
cheaper-inference:release/v3.8.0
|
Thank you @backryun for the Alibaba provider consolidation! 🙏 Merging the old alicode/alicode-intl providers into a shared ALIBABA_DASHSCOPE_MODELS array reduces catalog confusion and keeps model lists in sync. The i18n llm.txt provider count updates across 42 locales are appreciated. Conflicts with the release branch were resolved during integration. This will be included in v3.8.0. 🚀 |
Integrated into release/v3.8.0 — consolidates Alibaba-related providers, updates model registries and docs.
Integrated into release/v3.8.0 — consolidates Alibaba-related providers, updates model registries and docs.
Integrated into release/v3.8.0 — consolidates Alibaba-related providers, updates model registries and docs.
Summary
alicode/alicode-intlentries.alibaba-cnfor DashScope China while keepingalibabafor DashScope international.Validation
npm run lintnpm run test:unitnpm run test:coverage>= 60%for statements, lines, functions, and branchesAdditional local validation run:
node --import tsx/esm --test tests/unit/cache-control-claude-providers.test.ts tests/unit/provider-models-config.test.ts tests/unit/providers-page-utils.test.tsTests Added Or Updated
tests/unit/cache-control-claude-providers.test.tsCoverage Notes
src/andopen-sse/.alicodeexpectation.Reviewer Notes
alicode/alicode-intlremoval and the supported Alibaba provider IDs now beingalibaba,alibaba-cn, andbailian-coding-plan.