Skip to content

fix(ci): reconcile release type contracts and generated skills - #18576

Draft
mrnicholasbcarter-code wants to merge 1 commit into
cheaper-inference:release/v3.8.53from
mrnicholasbcarter-code:fix/release-v3.8.53-basereds
Draft

mrnicholasbcarter-code wants to merge 1 commit into
cheaper-inference:release/v3.8.53from
mrnicholasbcarter-code:fix/release-v3.8.53-basereds

Conversation

@mrnicholasbcarter-code

Copy link
Copy Markdown
Contributor

Summary

release base repair
  cooldown reader -> shared AntigravityQuotaFamily (includes existing Argon family)
  CLI schema -> preserve optional codeBlock.title already used by Pi
  canonical skills generator -> refresh 3 skills and 2 endpoint references

No frozen typecheck baseline changes. No catalog, evidence, provider selection, workflow or dependency changes.

Related Issues

Target Branch

  • Active release/v3.8.53, refetched at 689b1eb573e21ea1bac4467c2ccfd9b8aaa7c518.
  • No open release-freeze marker at branch creation or push.
  • Not a new feature.

Validation / Evidence

  • Change type: other (release CI contract/snapshot repair).
  • npm run lint; targeted Prettier; git diff --check.
  • node scripts/check/check-api-typecheck.mjs: before fails two new TS diagnostics; after passes with 244 existing diagnostics within frozen baseline. Baseline unchanged.
  • npm run check:agent-skills-sync: before generated 3 / unchanged 43 and exits 2; after generated 0 / unchanged 46, exits 0. Applied canonical node --import tsx/esm scripts/skills/generate-agent-skills.mjs --apply.
  • Focused tests 27/27; adjacent CLI catalog/quota/free-catalog suites 128/128; Token Harbor provider regression 3/3.
  • Independent revised diff review: no findings; reviewer independently passed 14 tests including all 3 Token Harbor regressions. No different-model-family claim.
  • Native pre-commit gates passed without bypass. Private sibling UI-kit comparison unavailable and warned/skipped by its own supported fork behavior.
  • Base refetched unchanged before push; scope clean after commit.
  • npm run test:scoped: stopped owned process tree after 20 minutes while still building import-graph impact map, before test execution; exit 143. Direct focused/adjacent tests above completed. Full suite/build/coverage not claimed.
  • Full production build and complete suite remain CI requirements, not local success claims.

Tests Added Or Updated

  • tests/unit/antigravity-family-cooldown-reader.test.ts: Argon cooldown reader and expired deadline.
  • tests/unit/cli-catalog-schema.test.ts: Pi manual title survives schema parsing.

Coverage Notes

Runtime delta reuses existing shared family type and extends optional schema metadata; focused tests cover both. No coverage-baseline changes.

Remaining Blockers / Reviewer Notes

This PR intentionally does not claim all inherited CI failures resolved. check:free-catalog-evidence still fails for tokenharbor/claude-haiku-5.5:free, which has no exact policy evidence record. Removing its sole free catalog row breaks existing provider recognition; that attempted change was reverted following independent review. Current cited model URL displays "Model not found"; generic billing docs describe metered rolling allowance, not this exact uncapped claim. Genuine evidence / maintainer policy disposition is required, not invented proof or validation bypass.

Base documentation title failure is addressed separately by #18566. Base docs-count drift remains inherited. Internal compatibility/snapshot repair, no new public API or feature; no changelog fragment.

Merge Danger

Door: two-way

Blast Radius: contracts

Optional Pi metadata now survives validation; Argon family reader matches existing writer/shared family contract. Generated skill snapshots track existing routes. No merge or deployment requested.

@mrnicholasbcarter-code

Copy link
Copy Markdown
Contributor Author

Exact-head CI update (7f8e90f9092fdbc5c659f6d75c572ed1ace9d481): repaired gates now pass on GitHub: API Route Typecheck and Merge integrity / generated skills.

Remaining failures are exactly the preserved catalog evidence blocker: both Change Classification jobs report tokenharbor/claude-haiku-5.5:free: missing evidence; Gate / CI and Gate / Quality then fail closed. CI classification log, Quality classification log. No assertion that PR is green. Maintainer exact-model evidence/policy disposition remains required; no gate bypass or unsupported catalog behavior change included.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant