Skip to content

ci(i18n): make docs-mirror drift advisory on pull requests and the merge train #18420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Oct 28, 2026
Merged

ci(i18n): make docs-mirror drift advisory on pull requests and the merge train #18420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,19 +533,29 @@ jobs:
# (release/v3.8.53 inherited 14 drifted sources while the translation backend was down)
# is printed as inherited — the branch's own push run and the nightly Release-Green keep
# the full strict verdict, so the debt stays visible without painting every PR red.
#
# Advisory on pull requests since 2026-10-28: an English doc edit no longer has to ship
# its 66 mirrors in the same PR. Per-PR translation serialised every doc PR behind one
# translation backend (a 6-day quota outage froze 8 PRs; one doc took 6.6 h of retries)
# and every mirror PR collided on `.i18n-state.json`. Mirrors are refreshed in a batch
# `npm run i18n:run` after merge; the push run below, the nightly Release-Green and the
# release cut keep the strict verdict, so stale mirrors still cannot ship in a release.
- name: Base checkout for the i18n drift baseline (PR only)
if: ${{ github.event_name == 'pull_request' }}
uses: actions/checkout@v7
with:
ref: ${{ github.event.pull_request.base.sha }}
path: .i18n-base
persist-credentials: false
- name: i18n docs drift (PR — only drift introduced by this PR blocks)
- name: i18n docs drift (PR — advisory, mirrors are refreshed after merge)
if: ${{ github.event_name == 'pull_request' }}
run: |
set -euo pipefail
node scripts/i18n/check-translation-drift.mjs --root .i18n-base --json --warn > /tmp/i18n-base-drift.json
node scripts/i18n/check-translation-drift.mjs --base-report /tmp/i18n-base-drift.json
node scripts/i18n/check-translation-drift.mjs --base-report /tmp/i18n-base-drift.json --warn | tee /tmp/i18n-pr-drift.txt
if grep -q "WARN — drift detected" /tmp/i18n-pr-drift.txt; then
echo "::notice title=i18n mirrors pending::This PR changes English docs whose 66 mirrors are now stale. Nothing to do here: the mirrors are refreshed in the post-merge i18n batch."
fi
- name: i18n docs drift (sources changed since their translation)
if: ${{ github.event_name != 'pull_request' }}
run: node scripts/i18n/check-translation-drift.mjs
Expand Down
6 changes: 5 additions & 1 deletion scripts/release/merge-train.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,11 @@ STATIC_GATES=(
"npm run i18n:check-keys"
"npm run i18n:check-keys:cli"
"npm run i18n:check-ratio"
"node scripts/i18n/check-translation-drift.mjs"
# Docs mirrors are advisory on the train since 2026-10-28 (same policy as the PR CI step in
# ci.yml): a doc PR boards without its 66 mirrors and the post-merge `npm run i18n:run`
# batch refreshes them. `--warn` still prints every drifted source in the train log; the
# release push run, the nightly Release-Green and the release cut keep the strict verdict.
"node scripts/i18n/check-translation-drift.mjs --warn"
# ci.yml:lint family (2026-09-22): the same lesson as the i18n block above, for the
# rest of the lint job. A 170-PR drain left the tip red on eleven `ci.yml:lint` /
# `docs-sync-strict` gates the train never ran — every PR was green on its own and
Expand Down
Loading