Skip to content

fix(codex): omit compact client metadata #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegosouzapw merged 1 commit into from
Apr 30, 2026
Merged

fix(codex): omit compact client metadata #1822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion open-sse/executors/codex.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,6 +1146,7 @@ export class CodexExecutor extends BaseExecutor {
if (isCompactRequest) {
delete body.stream;
delete body.stream_options;
delete body.client_metadata;
} else {
body.stream = true;
}
Expand Down Expand Up @@ -1288,7 +1289,9 @@ export class CodexExecutor extends BaseExecutor {
body.prompt_cache_key = cacheSessionId;
}
}
applyCodexClientMetadata(body, credentials?.providerSpecificData?.codexClientIdentity);
if (!isCompactRequest) {
applyCodexClientMetadata(body, credentials?.providerSpecificData?.codexClientIdentity);
}

// Delete session_id and conversation_id from the body.
// These are often injected by OmniRoute's fallback logic for store=true,
Expand Down
27 changes: 27 additions & 0 deletions tests/unit/executor-codex.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,33 @@ test("CodexExecutor.transformRequest merges Codex installation metadata", () =>
});
});

test("CodexExecutor.transformRequest omits client metadata for compact requests", () => {
const executor = new CodexExecutor();
const result = executor.transformRequest(
"gpt-5.5",
{
model: "gpt-5.5",
input: [],
client_metadata: { existing: "drop" },
_nativeCodexPassthrough: true,
},
false,
{
requestEndpointPath: "/responses/compact",
providerSpecificData: {
codexClientIdentity: {
sessionId: "session-1",
turnId: "turn-1",
windowId: "session-1:0",
installationId: "11111111-1111-4111-a111-111111111111",
},
},
}
);

assert.equal(result.client_metadata, undefined);
});

test("CodexExecutor.execute falls back to HTTP when websocket transport is unavailable", async () => {
__setCodexWebSocketTransportForTesting(null);
const executor = new CodexExecutor();
Expand Down