Repository navigation
test(security): escape every RegExp metacharacter in the icon-map matcher (CodeQL #1166, #1167) - #18081
Closed
diegosouzapw wants to merge 1 commit into
Closed
test(security): escape every RegExp metacharacter in the icon-map matcher (CodeQL #1166, #1167)#18081diegosouzapw wants to merge 1 commit into
diegosouzapw wants to merge 1 commit into
Conversation
Collaborator
Author
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CodeQL alerts #1166 and #1167 (
js/incomplete-sanitization) intests/unit/icon-map-object-values.test.ts.The icon-map scanner built a
RegExpfrom an identifier and escaped only$. Identifiers matched by[A-Za-z_$][\w$]*cannot contain other metacharacters today, so this was not a live bug. The partial escape was still fragile, and it is the exact pattern the query flags. Both call sites now use a smallescapeRegExp()helper that escapes every metacharacter. This is the same remedy as #1144 / PR #16832.Test-only change, no production code touched.
Validation
node --import tsx/esm --test tests/unit/icon-map-object-values.test.ts: 3/3 pass before and after the change.eslint --suppressions-location config/quality/eslint-suppressions.jsonandprettier --checkare clean on the file.