Repository navigation
chore(dashboard): wave-2/3 checkpoint — release back-merge, two test realignments (KEA-7886) - #17907
Merged
Merged
Conversation
Fixes Dependabot alerts #315 and #319 (GHSA-rvq5-wwqv-78pq, GHSA-jm63-cq47-j5jp).
Fixes Dependabot alerts #312 and #313 (GHSA-q3jh-wrc6-jgq8, GHSA-8r9p-f939-6h3c).
Fixes Dependabot alert #311 (GHSA-5r4p-p66f-jhc7).
…EA-7886) /dashboard/settings answers with a page whose redirect() lands as a client navigation to /dashboard/settings/general a few hundred ms after the first load. The spec ran axe right after gotoDashboardRoute, so the navigation destroyed the evaluate context: flaky in the wave-1 checkpoint (green on retry), 3/3 red on the integrated wave-2/3 tree. Wait for the general URL and its load before analysing; the baseline assertion is unchanged. The file is reformatted by lint-staged (Prettier) in the same commit.
…pter (KEA-7886) Lote 6 moved PoolWizard's raw <input type="checkbox"> to the shared Checkbox adapter (cba0083), so the source-level test that pinned type="checkbox" went red in the integrated test:unit (passes on the release base). Same assertion on the new markup: the adapter import plus a <Checkbox> bound to checked={exclusive}; the wizardExclusiveLabel check is unchanged. Breaking the binding still fails it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the wave-2/3 checkpoint of the CI UI Kit migration (KEA-7886). All 11 lotes are integrated on
feat/new-uikit(95ff9c2f), and this branch adds therelease/v3.8.53back-merge. I validated it with:No adapter or cross-lote break turned up. The integration left two test reds, both realigned here with the assertion unchanged:
test:unitred caused by lote 6's markup change;Commits
07292564origin/release/v3.8.53(e8f4a829)package-lock.json, so I checked it: the root entry matchespackage.json, the release bumps and the kit deps are all present, andnpm ls --package-lock-onlyreports the same 12 optional-peer errors as the release's own lockfile.3ae3744a/dashboard/settingsredirects to/generalas a client navigation about 330 ms after load, and that navigation destroys axe's evaluate context. The test was flaky in wave 1 and fails 3/3 now. It now waits for the URL and the load. Route, spec and helper are identical to the release. Verified on the .113 with 3 runs and no retries: 5/5 each time.7b3491ffCheckboxadapter, so the source-level test that pinnedtype="checkbox"went red. It passes on the release. The same assertion now checks the adapter import plus<Checkbox … checked={exclusive}>. Result is 15/15, and it fails if the binding breaks.Validation (head
07292564; the two test commits verified as described above)modelsCombosCatalog,api-key-routing-editor,radar-guided-setup-action). All 3 pass alone with 60 s budgets, so the cause is load..git×17) and 17 are load or the copy without.git. Those were already classified in wave 1, or pass locally. The remaining 1 isquota-pool-wizard, a migration red fixed in7b3491ff.group-b-*specs, which hard-codehttp://localhost:20128while the run used port 20189 — an environment issue, identical on the release.3ae3744a: login 0/1, dashboard 1/4, providers 1/3, settings 0/5. Lote 5a cleared the settingsselect-name/labelviolations./landingat 390 px; 0 Material spans on every lote route (only/landing, which no lote owns, has 13)Leftovers for F4 (screen-level, inherited, or out of scope; not fixed here)
ProviderSummaryCard/Ndenominators (still present from wave 1);#484f58);/runtimeand/search-tools./landingis legacy and was in no lote.t.richpasses functions into{code}placeholders (React "Functions are not valid as a React child");not-foundinside the dashboard hitsMISSING_MESSAGE publicSystem;curlexample causes a hydration mismatch off port 20128.Screenshots are at
_artifacts/ckpt2-<route>-{light,dark,390}.png. The full report is in the private tasks repo atreports/uikit/wave2-checkpoint.md.