Skip to content

test(providers): regenerate the translate-path golden for the WorkBuddy compliance headers (#17046) - #17104

Closed
diegosouzapw wants to merge 2 commits into
release/v3.8.52from
fix/release-v3.8.52-basereds-1018-golden
Closed

diegosouzapw wants to merge 2 commits into
release/v3.8.52from
fix/release-v3.8.52-basereds-1018-golden

Conversation

@diegosouzapw

@diegosouzapw diegosouzapw commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

⚠️ base-red inherited: #15306 — this PR only regenerates one test golden.

GOLDEN provider.ts translate-path is stable across all providers (tests/unit/provider-translate-path-golden.test.ts) fails on the exact base tip (20d9b0403e, reproduced locally and in the CI shards of #17092) since #17046 (edc79d93, 2026-10-18 14:03) made the WorkBuddy executor send its gateway compliance headers on every translate path. The golden still recorded X-Product only.

Regenerated with UPDATE_GOLDEN=1: the delta is the three WorkBuddy entries gaining User-Agent: WorkBuddy/5.5.6, X-Agent-Intent/Purpose/Type, X-Domain, X-IDE-Name/Type/Version, X-Requested-With — exactly the headers #17046 introduced. Nothing else in the snapshot moved (one hunk, +30/−3).

Validation: the golden file's three tests 3/3 (stable, deterministic, …); prettier clean; pre-commit hooks green.

Second red from the same merge

workbuddy registry entry › declares the replayed-history flags and the streaming requirement (tests/unit/workbuddy-provider.test.ts) pinned the original four bodyStringReplacements; #17046 prepended four more (billing-header line, Claude Code self-description, branch hint, Codex project blurb). The fixture now lists the eight pairs the registry ships, in order. workbuddy-provider, workbuddy-gateway-compliance and the golden file: 40/40.

…dy compliance headers

#17046 made the WorkBuddy executor send the gateway compliance headers
(User-Agent, X-Agent-*, X-IDE-*, X-Domain, X-Requested-With) on every
translate path, but tests/snapshots/provider/translate-path.json still
recorded only X-Product, so "GOLDEN provider.ts translate-path is stable
across all providers" has been red on release/v3.8.52 since that merge.
Regenerated with UPDATE_GOLDEN=1; the delta is exactly the three WorkBuddy
entries gaining those headers. No production code changes.
… registry entry

"workbuddy registry entry › declares the replayed-history flags and the
streaming requirement" pinned the original four bodyStringReplacements;
#17046 prepended the billing-header line, the Claude Code self-description,
the branch hint and the Codex project blurb. The fixture now lists the eight
pairs the registry ships, in order. Same root cause as the golden in this PR.
@diegosouzapw

Copy link
Copy Markdown
Collaborator Author

Merging on the owner's drain authorization with local evidence: the CI and Quality Gates runs for this head have been queued for over an hour behind the hosted backlog (only CodeQL/semgrep/API typecheck ran). The change is two test files (a regenerated golden and a fixture), no production code; provider-translate-path-golden, workbuddy-provider and workbuddy-gateway-compliance pass 40/40 on the exact tip locally, prettier and hooks green. Both tests have been red in every PR shard since #17046 merged.

@diegosouzapw

Copy link
Copy Markdown
Collaborator Author

Superseded: #17102 (merged 20:09 UTC by the owner's other session) regenerated the same WorkBuddy golden and the same registry fixture; both tests pass on the live tip (40523566e6). Closing without merge.

@diegosouzapw
diegosouzapw deleted the fix/release-v3.8.52-basereds-1018-golden branch October 18, 2026 23:31
@github-actions

Copy link
Copy Markdown
Contributor

CI Coverage Report

  • Coverage job: skipped
  • PR test policy: success

Coverage artifact was not available for this run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant