Repository navigation
test(golden): add daoxe and nan to the translate-path golden (base-red) - #16962
Merged
diegosouzapw merged 1 commit intoOct 17, 2026
Merged
Conversation
…olden Both providers landed on release/v3.8.52 without regenerating tests/snapshots/provider/translate-path.json, so the GOLDEN translate-path test fails on the release tip. The regenerated snapshot only adds the two new entries; no existing provider entry changes.
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/provider-translate-path-golden.test.tsfails on therelease/v3.8.52tip: thedaoxeandnanproviders were registered without regeneratingtests/snapshots/provider/translate-path.json.UPDATE_GOLDEN=1; the diff is 46 added lines, 0 removed — only the two new provider entries, no existing entry changes.Test plan
a139bce79d):ℹ tests 3 ℹ pass 2 ℹ fail 1(GoldenMismatchError on provider/translate-path)node --import tsx/esm --test tests/unit/provider-translate-path-golden.test.ts→ℹ pass 3 ℹ fail 0