Repository navigation
fix(combos): keep duplicated snapshot weights within 100 percent - #16942
Merged
Merged
Conversation
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Duplicating a scored auto-combo with 131 candidates assigned a minimum integer weight of 1 to each candidate, producing a total weight of 131 instead of 100. A smaller highly skewed pool could overflow as well (108 in the regression fixture).
Normalize overflowing distributions into positive fractional shares and assign the residual to the last candidate. Existing integer distributions remain unchanged when they fit the percentage budget. Preserve every candidate and its order; do not change scoring or routing strategy.
Validation
virtualFactory.ts(lines 355 and 902), which is unchanged from the pinned base. A separate compiler reproduction on that base was not run; this extra check is not claimed green.Prepared and tested on release base
858d6022270b73489dfa8d89eee6fcc9a6a9e214. CI and Quality must pass on the final candidate before integration.