Repository navigation
fix(ui): dispose deferred FlowCanvas callbacks and test roots - #16689
Merged
Merged
Conversation
Collaborator
Author
|
Final lifecycle review found one additional timing window: a keyed graph was already disposed while its replacement's deferred
This strengthens the earlier 37-test evidence; it does not claim full current-base CI acceptance. No queue label or administrative bypass applied. |
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a -> b -> akey reuse.Reuses three existing, unpublished lifecycle fixes with
cherry-pick -x; the original branch/worktree and original commit authors are preserved. No timeout, assertion, baseline, or gate relaxations.Evidence
Pinned base:
88c1e3342b44978a72ce75beb0cc509cc83a93d2.window is not definederrors in the deferred FlowCanvasonInitfit despite passing UI assertions.The local dependency tree matches the candidate lockfile but was copied from a prior diagnostic install. Focused evidence is not full release or merge acceptance. Hosted required checks must validate the exact current candidate; known unrelated base API typecheck/file-size/unit/doc failures are being repaired separately. No queue label or bypass requested.
Part of the owner-approved ordered Relay closeout and base-red incident #15306.