Skip to content

fix(i18n): translate the Traditional Chinese UI strings that were left in English - #16639

Merged
diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.52from
pacocartones:i18n/zh-TW-untranslated
Oct 15, 2026
Merged

diegosouzapw merged 2 commits into
cheaper-inference:release/v3.8.52from
pacocartones:i18n/zh-TW-untranslated

Conversation

@pacocartones

Copy link
Copy Markdown
Contributor

Summary

  • 61 UI strings of the Traditional Chinese locale (src/i18n/messages/zh-TW.json) were still in English: the quota-share time windows (quotaShare.schedules*), the Codex cooldown and paid-credit labels, the proxy-subscription core errors, the per-model concurrency caps and the request-timeline labels. They are now translated, with the terminology the neighbouring zh-TW keys already use.
  • Root cause: these keys were added to en.json recently and fill-missing-from-en filled the other locales with the English text, so check-key-completeness passes while the value is untranslated.
  • Terminology follows scripts/i18n/glossary/zh-TW.json; check-glossary-consistency --locale=zh-TW passes.

Related Issues

  • Refs: none. Searched open pull requests for the locale (i18n, translation, locale); none changes these keys.

Target Branch

  • Base is the active release/v3.8.x branch (the highest open release/v*), not main

Proof Of Fix (required)

  • Other (explain) — translation-only change, no behaviour to test: the i18n gates below pass on the branch and the changed values are the only diff.
    • node scripts/i18n/check-key-completeness.mjs: OK, 66 locales carry all 13744 keys
    • node scripts/i18n/check-translation-ratio.mjs: OK, within baseline
    • node scripts/i18n/check-ui-icu.mjs: PASS, all messages compile (placeholders such as {entry}, {max} and {mode} are unchanged)

Tests Added Or Updated

  • None: only locale values change.

Scope

  • Only src/i18n/messages/zh-TW.json and the changelog fragment are touched
  • Keys listed in scripts/i18n/untranslatable-keys.json, brand names and code literals are left as they are
  • No test was weakened or deleted to make the suite pass

Validation

  • Change type: i18n
  • The i18n gates listed above pass; tests/unit/breadcrumbs-i18n-fallback.test.tsx and tests/unit/cli-i18n-catalog.test.ts fail the same way on the base branch without this change.

Reviewer Notes

  • The edit rewrites the file with the same 2-space JSON formatting, so only the changed values appear in the diff.

@diegosouzapw
diegosouzapw merged commit 99da83d into cheaper-inference:release/v3.8.52 Oct 15, 2026
47 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants