Repository navigation
test(video): enforce retention fixture network isolation - #16634
Conversation
…y-16634-reconcile-20261015
|
Owner-authorized continuation, preserving the original worktree. Updated this PR normally to Two additional regression checks now prove raw sockets are blocked before application imports and remain blocked while application resources/logs are flushed. Both failed before their respective corrections. Cleanup restores global fetch, the dispatcher and socket hook in Final scoped HTTP matrix: 14 PASS, 0 FAIL, 0 SKIP, 0 CANCELLED (68.7 s). Existing timeouts, assertions and outbound allowlist were not weakened. Prettier, changed-file ESLint and normal commit hooks passed; committed scope is only the existing test and a changelog fragment. Dependencies were borrowed with matching lock identity, so this is focused diagnostic evidence, not clean-install/full release certification. The original worktree remains clean and unchanged at |
Preserve release ad37e8f behavior and the HTTP fixture network guard. Current focused matrix: 14/14 pass, zero skips or cancellations.
Relay continuation — scoped reconciliation, not merge acceptanceThanks the retention test contributors. Reconciled this original PR with pinned release 14/14 actual HTTP retention matrix tests PASS, zero skipped/cancelled. Import-time and runtime network guards remain active. Node 24.20.0 / npm 11.15.0; unchanged lockfile SHA-256 |
…y-16634-reconcile-20261015
|
Exact-head checkpoint:
This is scoped test-harness evidence, not provider-real acceptance, a full release certificate or permission to bypass required CI/current-base admission. No paid video call, build or production mutation was performed. Marked ready for review; merge remains conditional on mandatory gates. |
CI Coverage Report
Coverage artifact was not available for this run. |
Current checkpoint — 2026-10-16
Head:
0a73291c76c8986c270eb74f2538f22f8028f5e5; reconciled base:8526008921e232eda3ede6bc67c2985f411a9831. Original two-file scope retained, including the strict exact127.0.0.1:fixture-port socket allowlist; no localhost/IPv6 broadening.VPS .15 Node integration execution, 21:30:42–21:31:10 UTC: 14 tests PASS, zero failures/skips/cancellations. The run used the repository's Node polyfill/data-isolation preloads, Node24.20.0, matching installed lockfile, isolated data and clean source fingerprints.
This is focused integration evidence, not the complete candidate matrix. The PR remains draft pending current-base reconciliation and applicable required checks. No merge, live-provider call, or deployment occurred.
Historical description and previous evidence (not current-head acceptance)
Summary
Repair the network-isolation contract of the existing Video Bridge HTTP retention
matrix without accepting
ECONNREFUSEDas evidence of blocked egress.Node's built-in fetch shares the same dispatcher registry.
already reject through MockAgent remain supported; a refused connection is not
accepted as an isolation success.
No production source or transport policy is changed. Related to #12150 / #12430.
Evidence
Tests run on the designated VPS, not the development machine. At base
e369ffc633131ef0b1ddbee9d2b40475e63c0808, the matrix reproduced 12 passing and2 failing counted tests (one network subtest plus its parent). An isolated owned
loopback-server probe confirmed native fetch connected while installed Undici
fetch rejected, both before and after application imports and guard reinstall.
After correction: 14 passing tests, zero failures/skips, covering JSON/SSE,
Responses continuation, policy rejection, pending/log/artifact/Memory/cache
retention, and an ordinary-traffic positive control. Dependencies were borrowed
from an existing installation: this is scoped evidence, not clean-lock or full
release certification. Final exact-head rerun at clean
6559412f68a1eb2f69561840da1c47915087be9cconfirms 14 PASS / 0 FAIL / 0 SKIPand changed-file ESLint exit 0. HEAD stayed unchanged and clean after both.
Admission
are not waived. Draft until that review finishes; no admin merge requested.