[diegosouzapw]

Summary

• The Add API key modal no longer keeps the previous credential after a save or cancel: reopening it starts from an empty form.
• ProviderModalsPanel now mounts AddApiKeyModal only while it is open, and the modal itself rebuilds its whole form on every open for callers that keep it mounted.

Attribution

Thanks to @hamedniroomand and @semihisikman for the original implementation.

Changes

• components/ProviderModalsPanel.tsx: render <AddApiKeyModal> only when showAddApiKeyModal is true, so closing it drops all form state (API key, token secret, AWS credentials, bulk text, OpenRouter preset, region step).
• components/modals/addApiKeyInitialFormData.ts (new): createInitialAddApiKeyFormData() holds the initial form shape that was inline in the modal.
• components/modals/AddApiKeyModal.tsx: the open-transition effect now replaces the form with createInitialAddApiKeyFormData() instead of patching name/baseUrl onto the old values, and resets mode, bulk text/result/warnings, the bulk "validate keys" toggle, advanced section, validation capabilities and the OpenRouter preset. The unique default name (fix(ui): prevent silent overwrite of existing API key connections on … #6499, [bug] ChatGPT Web: 5th connection replaces the 1st instead of appending #11033, fix(providers): adding a cookie connection can silently overwrite an existing one — count-based default name collides after a delete, and cookie rows upsert by name #15006) is still recomputed on each open. A failed save keeps the typed input and shows the error.
• Tests: components/modals/__tests__/addApiKeyModalReset.test.tsx (modal-level reset) and __tests__/addApiKeyModalMountOnOpen.test.tsx (panel mounts a fresh instance per open).

Test plan

• New tests fail before the fix (production files restored from HEAD with git show):
  • npx vitest run --config vitest.config.ts addApiKeyModalReset → Tests 3 failed | 2 passed (5) (API key kept after reopen, bulk tab + textarea kept, key kept after a successful save; the unique-name and failed-save cases pass as regression guards).
  • npx vitest run --config vitest.config.ts addApiKeyModalMountOnOpen → Tests 1 failed (1) (expected <div …> to be null: modal mounted while closed).
• After the fix: npx vitest run --config vitest.config.ts addApiKeyModalMountOnOpen addApiKeyModalReset → Test Files 2 passed (2), Tests 6 passed (6).
• Related suites (everything that imports AddApiKeyModal / ProviderModalsPanel): npx vitest run --config vitest.config.ts tests/unit/ui/confirm-delete-connection-7361 tests/unit/ui/add-api-key-modal tests/unit/ui/compatible-provider-apikey-setup tests/unit/ui/web-session-cookie-modal-size-6265 proxySaveRefresh useApiKeySaveSkipsFullSync addApiKeyModalMountOnOpen addApiKeyModalReset connModals addApiKeyModal-default-name-15006 → Test Files 13 passed (13), Tests 49 passed (49).
• node --import tsx/esm --test tests/unit/compute-connection-default-name-11033.test.ts tests/unit/compute-connection-default-name-6499.test.ts tests/unit/freebuff-risk-notice-15058.test.ts → ℹ tests 10 ℹ pass 10 ℹ fail 0.
• npx eslint --suppressions-location config/quality/eslint-suppressions.json <5 changed files> → exit 0; npx prettier --check <5 changed files> → all formatted.
• npm run typecheck:core → exit 0. Targeted tsc over the 5 changed files: identical pre-existing error set before and after (37 = 37, none in the new code).
• node scripts/check/check-pr-test-policy.mjs → Result: PASS; GITHUB_BASE_REF=release/v3.8.52 npm run check:test-masking → OK — 0 modified, 0 deleted.

⚠️ base-red inherited: #15306 — unit/vitest/integration/package-artifact gates on release/v3.8.52

[github-actions]

CI Coverage Report

• Coverage job: skipped
• PR test policy: success

Coverage artifact was not available for this run.