[pacocartones]

Summary

• When the HTTP client disconnects mid-stream, the devin-cli executor's child close handler calls controller.enqueue() / controller.close() on a cancelled stream. That throws ERR_INVALID_STATE inside a ChildProcess listener, an uncaught exception that can take down the server and every other stream in flight.
• Root cause: the ReadableStream has no cancel(); the abort listener only kills the child, and the child's close handler then writes to a controller whose consumer is gone.

Related Issues

• Related to fix(providers): devin-cli spawn error leaves SSE controller closed twice → uncaughtException #12517 (closed: a sibling case of this executor's controller being closed twice). No open PR covers this path (devin-cli matches only fix(devin): surface CLI auth and include auto-routing #15446, fix(authz): let remote dashboards validate provider keys #16449, fix(sse): derive the auto-combo noauth pool from emulated tool calling #16436 and fix(authz): let a tunnel-served dashboard verify and add provider API keys #16023, which touch other files).

Target Branch

• Base is the active release/v3.8.x branch (the highest open release/v*), not main

Proof Of Fix (required)

• TDD (preferred) — a test that fails before the fix and passes after it.
  • Test file(s): tests/unit/devin-cli-client-disconnect.test.ts (node as the fake acp CLI, the same trick as devin-cli-fallback-spawn-local-only-15159.test.ts)
  • Failing output before the fix:

    TypeError [ERR_INVALID_STATE]: Invalid state: Controller is already closed
    

Tests Added Or Updated

• tests/unit/devin-cli-client-disconnect.test.ts: the client cancels the body and aborts the signal mid-stream; the test asserts that no uncaughtException fires.

Coverage Notes

• Covers cancel() and the guarded enqueue / close in devin-cli.ts; the neighbouring devin unit tests keep passing.

Scope

• Only the files the failing test proves need changing are touched (devin-cli.ts, the test and the changelog fragment)
• No test was weakened or deleted to make the suite pass

Validation

• Change type: provider / executor
• Focused tests and category gates from the golden path: the devin unit tests pass (14 tests in the four neighbouring devin-cli files); check:ai-attribution, check:changelog-integrity and check:file-size pass
• npm run lint (the repository-wide run is left to CI; eslint reports one no-unused-vars on ProviderCredentials in devin-cli.ts that is already on the base)

Reviewer Notes

• Only the executor changes; streams that are not cancelled behave as before.