Repository navigation
fix(catalog): honour a member's max_output_tokens override in combo metadata - #16556
Merged
diegosouzapw merged 2 commits intoOct 15, 2026
Conversation
…etadata getComboTargetCatalogMetadata read max_output_tokens from the raw synced row, so an operator's max_output_tokens override reached the per-model catalog entry but not the combo built from it. Read canonical.limits.maxOutputTokens first, as max_input_tokens already does, and keep the synced row and the static spec as fallbacks. Fixes cheaper-inference#16515
diegosouzapw
merged commit Oct 15, 2026
3d458de
into
cheaper-inference:release/v3.8.52
31 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getComboTargetCatalogMetadata(src/app/api/v1/models/catalog.ts) took a combo member'smax_output_tokensfrom the raw synced row (synced.limit_output). An operator'smax_output_tokensoverride inmodel_capability_overridesreached the per-model catalog entry but not the combo built from it, so the combo advertised the pre-override minimum.canonical.limits.maxOutputTokens, resolved a few lines above, already applies the override.max_input_tokensalready readscanonical.limits. Output now does the same, with the synced row and the static spec kept as fallbacks.max_output_tokens: 384000to65536.Related Issues
Target Branch
release/v3.8.xbranch (the highest openrelease/v*), notmainv4-featurelabel for the v4 channelValidation
npm run lint(eslint on the changed files: no new findings; the existingno-unused-varsfindings incatalog.tsare on untouched lines and also show on the base)Tests Added Or Updated
tests/unit/16515-combo-max-output-override.test.ts(new): fails on the base (actual: 384000, expected: 65536) and passes with the fix.Coverage Notes
models-catalog-route,auto-combo-context-advertising,models-catalog-hidden-combo-leavesandcombo-context-prefix-resolutiongive 70/70 passing.Reviewer Notes
canonical.limits.maxOutputTokenstakes the synced row first, as before. It also takes the registry model's value before the static spec, which is the order the per-model entry already uses.