Repository navigation
fix(video): preserve short events within segment caption budget - #16518
Merged
diegosouzapw merged 1 commit intoOct 15, 2026
Merged
Conversation
diegosouzapw
marked this pull request as ready for review
October 15, 2026 19:56
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
The real FFmpeg rapid-cuts fixture contains black/white/black/white half-second events followed by a moving test pattern. With an eight-caption budget, structural sampling found all four short events, but the later 10-to-8 cap discarded the second black interval. The new public-helper integration test fails before the fix and passes afterward. A separate public-guardrail cache regression proves old metadata is not reused.
Validation
Executed on the dedicated VPS, not the development host:
[1, 1.5)short event.16 !== 8.npm run typecheck:core: PASS.Head:
7ccf49155ab39a9f93beea33ee4f12e4dc32954f.Base snapshot:
47688ba5ea28223cf240d4a3a1b542e249ad63b2.The 18-arm frozen-corpus resource rerun retained every declared fact interval for all nine segment-aware cases, within the original CPU/RSS/pre-analysis caps. Its aggregate remains FAIL because the unchanged uniform baseline misses short events; sampled temporal coverage is not semantic/model-quality proof. Tests used existing VPS dependencies, so these receipts do not certify a clean-lock release build, packaging, deployment, corpus/model promotion, or current-base merge admission. Keep this PR draft until required exact-candidate gates are complete.