Skip to content

fix(release): drain v3.8.52 base-reds — ConnectionRow type, drifted skills mirrors - #16496

Merged
diegosouzapw merged 2 commits into
release/v3.8.52from
fix/release-v3.8.52-basereds-r3
Oct 14, 2026
Merged

diegosouzapw merged 2 commits into
release/v3.8.52from
fix/release-v3.8.52-basereds-r3

Conversation

@diegosouzapw

@diegosouzapw diegosouzapw commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

⚠️ base-red inherited: #15306

Summary

Drains two deterministic base-reds on release/v3.8.52 that every PR inherits. They are not covered by #15682 or #16150.

  1. check:dashboard-typecheck: ConnectionRow.tsx:479 reads connection.rateLimitAutoProtected. b16bf50 added that read, and GET /api/providers already returns the field via isConnectionAutoProtected(), but ConnectionRowConnection never declared it, which raises TS2339 (baseline 0, live 1). The fix adds the optional field to the type. No runtime change.
  2. check:agent-skills-sync: 22 skills/** mirrors had drifted from docs/openapi.yaml (new llmlingua service routes, test-message routes, PUT /api/provider-models, and the OIDC callback text where oidcAllowedSubjects is now required). Regenerated with node --import tsx/esm scripts/skills/generate-agent-skills.mjs --apply. All output comes from the generator; nothing was hand-edited.

Note: this touches skills/**/SKILL.md, which is an agent-instruction surface. It merges with the owner's explicit approval, and the diff is generator output only.

Validation

  • npm run check:dashboard-typecheck → FAIL before (1 new TS2339), OK after (195 pre-existing, all within baseline)
  • npm run check:agent-skills-sync → FAIL before (Generated: 20), exit 0 after
  • Both re-run after the pre-commit hook reformatted the files
  • tests/unit/connection-row-connection-fields.test.ts (new): fails on the base version of ConnectionRow.tsx (2/2 red: rateLimitAutoProtected read but undeclared) and passes with the fix (2/2). It guards every connection.<field> read against the interface, because the dashboard sits outside typecheck:core.

@github-actions

Copy link
Copy Markdown
Contributor

CI Coverage Report

  • Coverage job: skipped
  • PR test policy: success

Coverage artifact was not available for this run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant