Repository navigation
fix(release): drain v3.8.52 base-reds — ConnectionRow type, drifted skills mirrors - #16496
Merged
Merged
Conversation
…s is declared on its type
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This was referenced Oct 14, 2026
This was referenced Oct 15, 2026
11 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drains two deterministic base-reds on
release/v3.8.52that every PR inherits. They are not covered by #15682 or #16150.check:dashboard-typecheck:ConnectionRow.tsx:479readsconnection.rateLimitAutoProtected. b16bf50 added that read, andGET /api/providersalready returns the field viaisConnectionAutoProtected(), butConnectionRowConnectionnever declared it, which raises TS2339 (baseline 0, live 1). The fix adds the optional field to the type. No runtime change.check:agent-skills-sync: 22skills/**mirrors had drifted fromdocs/openapi.yaml(newllmlinguaservice routes,test-messageroutes,PUT /api/provider-models, and the OIDC callback text whereoidcAllowedSubjectsis now required). Regenerated withnode --import tsx/esm scripts/skills/generate-agent-skills.mjs --apply. All output comes from the generator; nothing was hand-edited.Note: this touches
skills/**/SKILL.md, which is an agent-instruction surface. It merges with the owner's explicit approval, and the diff is generator output only.Validation
npm run check:dashboard-typecheck→ FAIL before (1 new TS2339), OK after (195 pre-existing, all within baseline)npm run check:agent-skills-sync→ FAIL before (Generated: 20), exit 0 aftertests/unit/connection-row-connection-fields.test.ts(new): fails on the base version ofConnectionRow.tsx(2/2 red:rateLimitAutoProtectedread but undeclared) and passes with the fix (2/2). It guards everyconnection.<field>read against the interface, because the dashboard sits outsidetypecheck:core.