Repository navigation
fix: route newer GitHub GPT models through Responses - #1641
diegosouzapw merged 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the providerRegistry.ts file to include the targetFormat: "openai-responses" property for several GPT-5.4 and GPT-5.5 models. Feedback suggests using the shared GPT_5_5_CODEX_CAPABILITIES object for the gpt-5.5 model to ensure consistency in capability flags and prevent potential issues with reasoning parameters.
| { id: "gpt-5.4-nano", name: "GPT-5.4 Nano", targetFormat: "openai-responses" }, | ||
| { id: "gpt-5.4-mini", name: "GPT-5.4 Mini", targetFormat: "openai-responses" }, | ||
| { id: "gpt-5.4", name: "GPT-5.4", targetFormat: "openai-responses" }, | ||
| { id: "gpt-5.5", name: "GPT-5.5", targetFormat: "openai-responses" }, |
There was a problem hiding this comment.
For consistency with the codex provider (see line 388), consider using the shared GPT_5_5_CODEX_CAPABILITIES object for the gpt-5.5 model. This ensures that capability flags like supportsReasoning, supportsVision, and the correct contextLength are applied to this model in the github provider as well, preventing potential issues where reasoning parameters might be stripped by translators.
| { id: "gpt-5.5", name: "GPT-5.5", targetFormat: "openai-responses" }, | |
| { id: "gpt-5.5", name: "GPT-5.5", ...GPT_5_5_CODEX_CAPABILITIES }, |
There was a problem hiding this comment.
Thanks @gemini-code-assist[bot], I verified that GPT_5_5_CODEX_CAPABILITIES is safe to reuse for the GitHub gpt-5.5 registry entry: it keeps targetFormat: "openai-responses" and only adds model capability metadata (toolCalling, supportsReasoning, supportsVision, supportsXHighEffort, and contextLength). The GitHub executor still routes by provider/model through getModelTargetFormat("gh", model), so this does not switch the model to the Codex executor.
Applied your suggestion in commit 50ca79bd.
There was a problem hiding this comment.
Thank you for verifying that, @dhaern. That sounds correct; reusing the GPT_5_5_CODEX_CAPABILITIES object is the right approach to ensure consistent metadata application while maintaining the intended routing behavior.
acf6ad4
into
cheaper-inference:release/v3.7.1
|
Thanks @dhaern for this clean, minimal fix! 🎉 The GitHub Copilot GPT 5.4/5.5 models are now correctly routed through the Responses API. Merged into |
…ce#1641) Integrated into release/v3.7.1 — routes gpt-5.4-nano, gpt-5.4-mini, gpt-5.4, and gpt-5.5 through the Responses API on GitHub Copilot.
…ce#1641) Integrated into release/v3.7.1 — routes gpt-5.4-nano, gpt-5.4-mini, gpt-5.4, and gpt-5.5 through the Responses API on GitHub Copilot.
…ce#1641) Integrated into release/v3.7.1 — routes gpt-5.4-nano, gpt-5.4-mini, gpt-5.4, and gpt-5.5 through the Responses API on GitHub Copilot.
Summary
gpt-5.4-nano,gpt-5.4-mini,gpt-5.4, andgpt-5.5) withtargetFormat: \"openai-responses\".https://api.githubcopilot.com/responsesinstead of/chat/completions.Why
GitHub Copilot rejects at least
gpt-5.4-minion the Chat Completions endpoint with:OmniRoute already supports per-model Responses routing for GitHub Copilot through
targetFormat: \"openai-responses\". Existing Codex-style GitHub models already use that path. The newer GPT 5.4/5.5 entries were added without that marker, so they were routed to the wrong upstream endpoint.This change only updates the static model registry metadata. It does not change request/response translators or executor behavior; it reuses the existing Responses translation and GitHub
responsesBaseUrlpath.Validation
git diff --checknpm run lint(passes with existing warnings, 0 errors)Notes
This is intentionally a minimal registry-only fix so GitHub Copilot GPT 5.4/5.5 models use the same Responses routing mechanism already used by other GitHub models that require Responses.