Repository navigation
fix(i18n,build): /home route provider + pack-artifact bun execution (#16321) - #16323
Merged
Conversation
diegosouzapw
pushed a commit
that referenced
this pull request
Oct 15, 2026
perf(sse): defer two conditional chatCore imports to first use. Boarded with #16342, #16324, and #16323 on detached `62049e9cb8` (each PR head is an ancestor). Local gates on that tree: file-size OK (chatCore 3932/3938), changelog integrity OK, eslint on the changed files exit 0, focused tests 23/23, typecheck:core exit 0, complexity OK (3038/3218), cognitive complexity OK (1400/1437), docs-counts exit 0 on retry. The open-sse typecheck red is on `copilotAutoModel.ts` and `openai-responses.ts`, byte-identical to the board base. CI Lint is the inherited `executeTargetAttempt.ts` ceiling (1288/1284), a file this PR does not touch, and Build was cancelled. Thanks @opensource-elearning.⚠️ base-red inherited: #15306
diegosouzapw
pushed a commit
that referenced
this pull request
Oct 15, 2026
…16342) perf(build): enable incremental TypeScript on the four typecheck configs. Build-info files stay gitignored. Boarded with #16346, #16324, and #16323 on detached `62049e9cb8`. Local gates: file-size OK, changelog integrity OK, eslint on the changed files exit 0, focused tests 23/23, typecheck:core exit 0, complexity OK (3038/3218), cognitive complexity OK (1400/1437), docs-counts exit 0 on retry. CI Lint is the inherited `executeTargetAttempt.ts` ceiling, a file this PR does not touch, and Build was cancelled. Thanks @opensource-elearning.⚠️ base-red inherited: #15306
diegosouzapw
pushed a commit
that referenced
this pull request
Oct 15, 2026
… JWT FATAL (#16320) (#16324) fix(build,docs): document the expected production-build warnings and suppress the JWT_SECRET FATAL log only during `next build`. POST /api/auth/login still fail-closes when the secret is missing. Closes #16320 Boarded with #16346, #16342, and #16323 on detached `62049e9cb8`. Focused tests: tests/unit/16320-build-warnings.test.ts 4 pass, tests/unit/build/known-build-warnings.test.ts 7 pass (23/23 across the batch). File-size, changelog integrity, eslint, typecheck:core, complexity (3038/3218), cognitive complexity (1400/1437), and docs-counts (retry) passed. CI Lint is the inherited `executeTargetAttempt.ts` ceiling, a file this PR does not touch, and Build was cancelled. Thanks @opensource-elearning.⚠️ base-red inherited: #15306
diegosouzapw
merged commit Oct 15, 2026
a12a0e7
into
cheaper-inference:release/v3.8.52
30 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two production-only defects reported together in #16321, each with a regression test.
/homeroute i18n providerMISSING_MESSAGE: cheaperInferenceSponsorBanner / vscodeCopilotBanner / home (en)on every visit/dashboardredirects to/home, but only(dashboard)/dashboard/layout.tsxmountedSectionI18nProvider;(dashboard)/home/had no layout, so the route inherited the chrome-only provider. Nested next-intl providers replace the message set, they do not mergenpm-cli.jsbefore spawning npmbun run check:pack-artifactfails with... /home/temp/.bun/bin/bun:1followed by raw ELF bytesprocess.env.npm_execpathas a JS entry point, butbun runsets it to the barebunbinary, so it executednode /path/to/bun …and Node dumped the executableIssues addressed
MISSING_MESSAGEerrors and the pack-artifact validation failure under Bun.What was happening
1.
/homehad no catalog of its ownsrc/app/(dashboard)/dashboard/page.tsxonlyredirect("/home"); the real page issrc/app/(dashboard)/home/page.tsx, which rendersHomePageClient,KimiSponsorBanner,CheaperInferenceSponsorBanner,VscodeCopilotBanner,NewsBanner,FirstRunReadinessCard.The generated map already had a complete
homenamespace set — but only(dashboard)/dashboard/layout.tsx(the redirect route) mounted it. The/homeroute fellthrough to the dashboard root layout (
routeNamespaces.chrome), andchromedeliberatelyexcludes
homeand every banner namespace. Since nestedNextIntlClientProviders replace themessage set, those namespaces were simply absent at render time.
The key-completeness check still passed because the messages exist in the catalogs — they were
never serialized into the
/homeflight payload.2. The validator ran
node <bun>isBunRuntimeis evaluated in the script's process. The npm script isnode --import tsx scripts/build/validate-pack-artifact.ts, so even underbun runthe scriptruns on Node —
"Bun" in globalThisisfalse— whilenpm_execpathpoints at the Bun binary.The result was
node /home/temp/.bun/bin/bun run build:cli, and Node printed the ELF header intothe validator's error message.
Changes
Commit 1 —
fix(i18n): mount /home route provider …scripts/i18n/lib/routeNamespacesAnalyzer.mjs— thehomeset is now the union of thedashboard/companion files and the real(dashboard)/home/route directory.scripts/i18n/generate-route-namespaces.mjs— also emits the/homeprovider layout.src/app/(dashboard)/home/layout.tsx— new generatedSectionI18nProviderfor/home.src/i18n/routeNamespaces.generated.json— regenerated (usageadded tohome).tests/unit/i18n-route-namespaces.test.ts— asserts the/homelayout exists and mounts theprovider, and documents that the home namespaces are intentionally absent from
chrome.Commit 2 —
fix(build): resolve npm-cli.js …scripts/build/resolveNpmEntry.ts— newresolveNpmInvocation(): prefersprocess.execPath <npm-cli.js>(via the existingresolveBundledNpmEntry, [v3.8.50] fix(build): prepublish no longer spawns .cmd shims on Windows #8858) and fallsback to the plain
npmcommand. It never trustsnpm_execpathas a JS entry.scripts/build/validate-pack-artifact.ts—runNpm()uses it instead of theisBunRuntimeheuristic.
tests/unit/build/resolve-npm-invocation.test.ts— 5 cases, including "the bun binary mustnever be passed to node as a script".
Testing
Real reproduction of the reported failure path (bun runtime, policy-only path):
Before the fix the same invocation reached
node <bun-binary>and emitted the…:1+ELF …dump from the issue.
Also checked:
prettier --checkclean on all changed files,check:changelog-integrityOK, andtsc -p tsconfig.typecheck-dashboard.jsonreports no errors in the new file (the errors it doesreport are pre-existing under
src/shared/*).Notes
release/v3.8.52tip is currently red for unrelatedreasons (hung unit/integration gates, MCP audit Vitest shutdown, pack-artifact gate timeout).
This branch does not touch those surfaces.