Repository navigation
fix(sse): record unknown previous response rejections in the request journal - #16193
Merged
diegosouzapw merged 3 commits intoOct 15, 2026
Conversation
maxmad64bis
force-pushed
the
fix/previous-response-not-found-call-log
branch
2 times, most recently
from
October 10, 2026 12:33
680130d to
2ffe147
Compare
maxmad64bis
marked this pull request as ready for review
October 10, 2026 12:53
Collaborator
|
Hi @maxmad64bis — closing this pull request to clear the open queue. The branch |
Contributor
Author
|
Hi @diegosouzapw — following up on your note: please reopen this one when you get a chance. The branch is still there on my side, happy to rebase or rework it after the release if needed. Thanks! |
Collaborator
|
Hi @maxmad64bis — reopening this pull request. The close was a mistake, and it is back in the merge queue. The branch |
…journal The previous_response_not_found 400 returns untouched but now routes through logHandlerRejection; the unknown-id case fails without the change and the other two guard the reply.
maxmad64bis
marked this pull request as draft
October 11, 2026 12:38
maxmad64bis
force-pushed
the
fix/previous-response-not-found-call-log
branch
from
October 11, 2026 12:38
2ffe147 to
4ff2777
Compare
maxmad64bis
marked this pull request as ready for review
October 11, 2026 14:36
5 of 7 tasks
6 tasks done
# Conflicts: # src/sse/handlers/admissionRejectionLog.ts # src/sse/handlers/chat.ts
diegosouzapw
merged commit Oct 15, 2026
01039ae
into
cheaper-inference:release/v3.8.52
8 of 9 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a request references an unknown previous response, it gets a 400 with no row in the request journal, so a client retrying that refusal stays invisible. That 400 is built by hand and returns without calling the rejection logger the file's other rejections share. Now the reply is byte-identical and a row with its status and code is written without delaying it.
Related Issues
Target Branch
release/v3.8.xbranch (the highest openrelease/v*), notmainv4-featurelabel for the v4 channelValidation
npm run lintTests Added Or Updated
tests/unit/handler-rejection-call-log.test.ts— three new cases: an unknown id writes one 400 row, a known id writes no rejection row, and the 400 body stays byte-identical.Coverage Notes
src/sse/handlers/chat.ts— covered by the three new cases intests/unit/handler-rejection-call-log.test.ts.src/sse/handlers/admissionRejectionLog.ts— covered by the three new cases intests/unit/handler-rejection-call-log.test.ts(shared rejection logger used by the new envelope).Reviewer Notes