Repository navigation
fix(sse): clear network dedup when provider breaker resets (#13899) - #16077
Merged
Merged
Conversation
clearProviderFailure() now also clears the network-error and per-connection failure dedup windows, so a fresh network blip right after a provider breaker reset is counted instead of swallowed (#13887). Co-authored-by: diegosouzapw <8016841+diegosouzapw@users.noreply.github.com>
5 tasks done
Contributor
CI Coverage Report
Coverage artifact was not available for this run. |
This was referenced Oct 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-land of #13899 by @onexer88-blip (closes #13887). The original PR has been a contributor draft since 2026-09-19 and could not be merged; the validated net diff is carried here with the original commit authorship preserved.
clearProviderFailure()now also clears the network-error and per-connection failure dedup windows, so a fresh network blip right after a provider breaker reset is counted instead of swallowed. Includes the contributor's regression test and changelog fragment.Validation (local):
breaker-network-error-guard16/16; 262 related tests with 1 failure,auto-combo-candidates-locked-model-visible, which also fails on the tip without this change;typecheck:core,check:open-sse-typecheck,check:file-sizegreen.